diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-11 18:04:43 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-11 19:38:25 +0100 |
| commit | 6b67f867cca1cb62ca045b60635f6da0a347c4f2 (patch) | |
| tree | 726c4b4b59dded0cb2cc2b852636d10170b79505 /editeng | |
| parent | b7f022234589c84ddb8566ddf7d91701eba55d3d (diff) | |
tdf#120703 PVS: V560 A part of conditional expression is always true/false
Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041
Reviewed-on: https://gerrit.libreoffice.org/63266
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'editeng')
| -rw-r--r-- | editeng/source/accessibility/AccessibleEditableTextPara.cxx | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/editeng/source/accessibility/AccessibleEditableTextPara.cxx b/editeng/source/accessibility/AccessibleEditableTextPara.cxx index 8023887dcfb0..b42e895f67e0 100644 --- a/editeng/source/accessibility/AccessibleEditableTextPara.cxx +++ b/editeng/source/accessibility/AccessibleEditableTextPara.cxx @@ -926,14 +926,10 @@ namespace accessibility sal_Int32 reeBegin = ree.aPosition.nIndex + nAllFieldLen; sal_Int32 reeEnd = reeBegin + ree.aCurrentText.getLength(); nAllFieldLen += (ree.aCurrentText.getLength() - 1); - if (reeBegin > nIndex) - { + if (nIndex < reeBegin) break; - } - if (nIndex >= reeBegin && nIndex < reeEnd) - { + if (nIndex < reeEnd) return GetFieldTypeNameFromField(ree); - } } return OUString(); } @@ -1584,13 +1580,11 @@ namespace accessibility reeBegin = ree.aPosition.nIndex + nAllFieldLen; reeEnd = reeBegin + ree.aCurrentText.getLength(); nAllFieldLen += (ree.aCurrentText.getLength() - 1); - if( reeBegin > nIndex ) - { + if (nIndex < reeBegin) break; - } if (!ree.pFieldItem) continue; - if (nIndex >= reeBegin && nIndex < reeEnd) + if (nIndex < reeEnd) { if (ree.pFieldItem->GetField()->GetClassId() != text::textfield::Type::URL) { |