diff options
author | Noel Grandin <noelgrandin@gmail.com> | 2015-06-13 22:15:31 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2015-06-15 14:46:41 +0200 |
commit | 4729774b244db7a175077ed0c70aa48be62bc60e (patch) | |
tree | 9f0f2e329d269835d4c20a8183a2772b734608f3 /editeng | |
parent | 9db80b1499e09cde000160434728f7b231c30db8 (diff) |
remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
Diffstat (limited to 'editeng')
-rw-r--r-- | editeng/source/items/bulitem.cxx | 3 | ||||
-rw-r--r-- | editeng/source/rtf/svxrtf.cxx | 6 |
2 files changed, 3 insertions, 6 deletions
diff --git a/editeng/source/items/bulitem.cxx b/editeng/source/items/bulitem.cxx index d35a20edbde9..e99cb023c2d2 100644 --- a/editeng/source/items/bulitem.cxx +++ b/editeng/source/items/bulitem.cxx @@ -181,8 +181,7 @@ SvxBulletItem::SvxBulletItem( const SvxBulletItem& rItem) : SfxPoolItem( rItem ) SvxBulletItem::~SvxBulletItem() { - if( pGraphicObject ) - delete pGraphicObject; + delete pGraphicObject; } diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx index b70fd01a3a24..1bc5cf1c5dbb 100644 --- a/editeng/source/rtf/svxrtf.cxx +++ b/editeng/source/rtf/svxrtf.cxx @@ -101,8 +101,7 @@ SvxRTFParser::~SvxRTFParser() void SvxRTFParser::SetInsPos( const SvxPosition& rNew ) { - if( pInsPos ) - delete pInsPos; + delete pInsPos; pInsPos = rNew.Clone(); } @@ -1037,8 +1036,7 @@ void SvxRTFParser::AttrGroupEnd() // process the current, delete from Stack } while( false ); - if( pOld ) - delete pOld; + delete pOld; bNewGroup = false; } |