diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2013-11-29 17:42:08 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2013-11-29 17:42:08 +0100 |
| commit | d694313b57f2edca8fb04cd8655476df6d879784 (patch) | |
| tree | cb57be46efdad23147b3175dc5694115a8cefb86 /embeddedobj | |
| parent | f304c906320a3258f5baf6bfa7d43f678ce3f534 (diff) | |
Catch block smells like leftover debugging code
...especially as it doesn't change hr from S_OK, and compiling with /EHsc
(instead of /EHa) reveals that OleRun does not throw any (C++) exceptions (and
thus produces an "unreachable code" warning for the catch block).
Change-Id: Ic34e83e6ede3a214ccb073e3e54d6fcc493d46ea
Diffstat (limited to 'embeddedobj')
| -rw-r--r-- | embeddedobj/source/msole/olecomponent.cxx | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/embeddedobj/source/msole/olecomponent.cxx b/embeddedobj/source/msole/olecomponent.cxx index 1bbec2121ca2..7181083246ae 100644 --- a/embeddedobj/source/msole/olecomponent.cxx +++ b/embeddedobj/source/msole/olecomponent.cxx @@ -988,16 +988,7 @@ void OleComponent::RunObject() if ( !OleIsRunning( m_pNativeImpl->m_pOleObject ) ) { - HRESULT hr = S_OK; - try - { - hr = OleRun( m_pNativeImpl->m_pObj ); - } - catch( ... ) - { - int i = 0; - i++; - } + HRESULT hr = OleRun( m_pNativeImpl->m_pObj ); if ( FAILED( hr ) ) { |