Remove dubious #pragma pack

...that were introduced with 21584b304b21bfe6b99b6f29018c6b754ea28fc0 "make
OUString(OUStringLiteral) constructor constexpr", apparently to mimic the
corresponding #pragma pack for rtl_uString in include/rtl/ustring.h.  But
neither of them appear to have any value:  All struct member types involved
(oslInterlockedCount aka sal_Int32, sal_Int32 itself, and sal_Unicode) have size
<= 4, so the member alignment ("on a boundary that's either a multiple of [the
pragma pack value], or a multiple of the size of the member, whichever is
smaller", according to
<https://docs.microsoft.com/en-us/cpp/preprocessor/pack?view=msvc-160>) is not
affected.  And neither are alignof(rtl_uString) and alignof(OUStringLiteral<N>)
affected, which remain e.g. 4 on x86-64.  (And prior to
21584b304b21bfe6b99b6f29018c6b754ea28fc0, OUStringLiteral did not have any
pragma pack cargo cult, but which did not cause OUStringLiteral::assertLayout to
fail, or raise any other documented issues.)

So remove the pragma pack cargo cult again at least from OUStringLiteral.  (And
leave potential removal from rtl_uString for another commit.)

Change-Id: I1a3626f0db1a0413ff792bd00ebaf76e4249b13f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114484
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins

0 files changed, 0 insertions, 0 deletions