summaryrefslogtreecommitdiff
path: root/emfio
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2020-08-05 09:58:34 +0200
committerStephan Bergmann <sbergman@redhat.com>2020-08-05 11:30:20 +0200
commit2e12d210cac8d031c21cdda9c37c1551f967ddc4 (patch)
treefc65a051484b7eab2ad5132f18aa88187206cefa /emfio
parented3ccdbde9ace7d2e3d67a9cc83a189cfaf1cad9 (diff)
Silence loplugin:staticmethods when the definition involves preprocessing
...to help avoid false positives. (Another option to silence such warnings is to add (void) this; to false-positive function bodies, but this new approach may be more natural in certain cases.) Change-Id: Ie6ea908730c596dbfb62ff42ae60dbd0a00a8fc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100152 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'emfio')
-rw-r--r--emfio/source/reader/emfreader.cxx8
1 files changed, 4 insertions, 4 deletions
diff --git a/emfio/source/reader/emfreader.cxx b/emfio/source/reader/emfreader.cxx
index 5d2749d16356..8c128d2965c6 100644
--- a/emfio/source/reader/emfreader.cxx
+++ b/emfio/source/reader/emfreader.cxx
@@ -386,9 +386,11 @@ namespace emfio
const sal_uInt32 EMR_COMMENT_ENDGROUP = 0x00000003;
const sal_uInt32 EMR_COMMENT_MULTIFORMATS = 0x40000004;
const sal_uInt32 EMR_COMMENT_WINDOWS_METAFILE = 0x80000001;
+#endif
void EmfReader::ReadGDIComment(sal_uInt32 nCommentId)
{
+#if OSL_DEBUG_LEVEL > 0
sal_uInt32 nPublicCommentIdentifier;
mpInputStream->ReadUInt32(nPublicCommentIdentifier);
@@ -442,12 +444,10 @@ namespace emfio
SAL_WARN("emfio", "\t\tEMR_COMMENT_PUBLIC not implemented, id: 0x" << std::hex << nCommentId << std::dec);
break;
}
- }
#else
- void EmfReader::ReadGDIComment(sal_uInt32)
- {
- }
+ (void) nCommentId;
#endif
+ }
void EmfReader::ReadEMFPlusComment(sal_uInt32 length, bool& bHaveDC)
{