diff options
| author | Noel Grandin <noel@peralex.com> | 2015-01-20 12:38:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2015-01-26 08:42:28 +0200 |
| commit | b44cbb26efe1d0b0950b1e1613e131b506dc3876 (patch) | |
| tree | 9b4d5d99e5dad0971079b997a02a6d96536709ca /extensions/source/plugin | |
| parent | 26ad60aec69310fecd918f1c2e09056aa4782320 (diff) | |
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
Diffstat (limited to 'extensions/source/plugin')
| -rw-r--r-- | extensions/source/plugin/inc/plugin/impl.hxx | 2 | ||||
| -rw-r--r-- | extensions/source/plugin/inc/plugin/plcom.hxx | 4 | ||||
| -rw-r--r-- | extensions/source/plugin/inc/plugin/unx/sysplug.hxx | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/extensions/source/plugin/inc/plugin/impl.hxx b/extensions/source/plugin/inc/plugin/impl.hxx index a22af7c8ba6f..6f1cc352c4a5 100644 --- a/extensions/source/plugin/inc/plugin/impl.hxx +++ b/extensions/source/plugin/inc/plugin/impl.hxx @@ -303,7 +303,7 @@ public: virtual Reference< com::sun::star::plugin::XPluginContext > SAL_CALL createPluginContext() throw(std::exception) SAL_OVERRIDE; // has to be implemented per system - virtual Sequence< com::sun::star::plugin::PluginDescription > SAL_CALL impl_getPluginDescriptions() throw(css::uno::RuntimeException, std::exception); + Sequence< com::sun::star::plugin::PluginDescription > SAL_CALL impl_getPluginDescriptions() throw(css::uno::RuntimeException, std::exception); // calls system specific impl_getPluginDescriptions // checks whether plugins are disabled virtual Sequence< com::sun::star::plugin::PluginDescription > SAL_CALL getPluginDescriptions() diff --git a/extensions/source/plugin/inc/plugin/plcom.hxx b/extensions/source/plugin/inc/plugin/plcom.hxx index e08c264b519e..883a5a5122ce 100644 --- a/extensions/source/plugin/inc/plugin/plcom.hxx +++ b/extensions/source/plugin/inc/plugin/plcom.hxx @@ -78,8 +78,8 @@ public: virtual NPError NPP_SetValue( NPP instance, NPNVariable variable, void *value) = 0; - virtual NPError NPP_SetWindow( XPlugin_Impl* ); - virtual NPError NPP_Destroy( XPlugin_Impl*, NPSavedData** save ); + NPError NPP_SetWindow( XPlugin_Impl* ); + NPError NPP_Destroy( XPlugin_Impl*, NPSavedData** save ); }; #endif diff --git a/extensions/source/plugin/inc/plugin/unx/sysplug.hxx b/extensions/source/plugin/inc/plugin/unx/sysplug.hxx index b12675f98a97..59979da4f921 100644 --- a/extensions/source/plugin/inc/plugin/unx/sysplug.hxx +++ b/extensions/source/plugin/inc/plugin/unx/sysplug.hxx @@ -71,7 +71,7 @@ public: virtual int32_t NPP_Write( NPP instance, NPStream* stream, int32_t offset, int32_t len, void* buffer ) SAL_OVERRIDE; virtual int32_t NPP_WriteReady( NPP instance, NPStream* stream ) SAL_OVERRIDE; - virtual char* NPP_GetMIMEDescription(); + char* NPP_GetMIMEDescription(); virtual NPError NPP_GetValue( NPP instance, NPPVariable variable, void* value ) SAL_OVERRIDE; virtual NPError NPP_SetValue( NPP instance, NPNVariable variable, void *value) SAL_OVERRIDE; |