diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-07-30 15:21:11 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-07-30 17:34:39 +0200 |
commit | 0c1b49048f1127d352b43847353392f0512f19e3 (patch) | |
tree | 81bbe680c12a5a1fa5e4c98f73881ca14e4fc1e2 /extensions/source/propctrlr | |
parent | 64cf52d47968d512afd383ce9a7321a4bd72b2ca (diff) |
loplugin:unusedmethods
and tweak the plugin a little to speed it up
Change-Id: Ia59456232602184c4f1b5d1d75ad94a9a2e2d0be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99799
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'extensions/source/propctrlr')
-rw-r--r-- | extensions/source/propctrlr/modulepcr.cxx | 17 | ||||
-rw-r--r-- | extensions/source/propctrlr/modulepcr.hxx | 13 | ||||
-rw-r--r-- | extensions/source/propctrlr/objectinspectormodel.cxx | 1 |
3 files changed, 2 insertions, 29 deletions
diff --git a/extensions/source/propctrlr/modulepcr.cxx b/extensions/source/propctrlr/modulepcr.cxx index 37d119e8e824..fdaf3b2a6348 100644 --- a/extensions/source/propctrlr/modulepcr.cxx +++ b/extensions/source/propctrlr/modulepcr.cxx @@ -23,23 +23,6 @@ namespace pcr { - PcrModule::PcrModule() - { - } - - PcrModule& PcrModule::getInstance() - { - static PcrModule* pModule = new PcrModule; - return *pModule; - /* yes, in theory, this is a resource leak, since the PcrModule - will never be cleaned up. However, using a non-heap instance of PcrModule - would not work: It would be cleaned up when the module is unloaded. - This might happen (and is likely to happen) *after* the tools-library - has been unloaded. However, the module's dtor is where we would delete - our resource manager (in case not all our clients de-registered) - which - would call into the already-unloaded tools-library. */ - } - OUString PcrRes(const char* pId) { return Translate::get(pId, Translate::Create("pcr")); diff --git a/extensions/source/propctrlr/modulepcr.hxx b/extensions/source/propctrlr/modulepcr.hxx index d29c2fd2c969..ee44cc6bbad3 100644 --- a/extensions/source/propctrlr/modulepcr.hxx +++ b/extensions/source/propctrlr/modulepcr.hxx @@ -20,21 +20,10 @@ #ifndef INCLUDED_EXTENSIONS_SOURCE_PROPCTRLR_MODULEPCR_HXX #define INCLUDED_EXTENSIONS_SOURCE_PROPCTRLR_MODULEPCR_HXX -#include <comphelper/componentmodule.hxx> +#include <rtl/ustring.hxx> namespace pcr { - /* -------------------------------------------------------------------- */ - class PcrModule : public ::comphelper::OModule - { - friend struct CreateModuleClass; - typedef ::comphelper::OModule BaseClass; - public: - static PcrModule& getInstance(); - private: - PcrModule(); - }; - OUString PcrRes(const char* pId); } // namespace pcr diff --git a/extensions/source/propctrlr/objectinspectormodel.cxx b/extensions/source/propctrlr/objectinspectormodel.cxx index 49e876b0a232..99447d5c8a3f 100644 --- a/extensions/source/propctrlr/objectinspectormodel.cxx +++ b/extensions/source/propctrlr/objectinspectormodel.cxx @@ -23,6 +23,7 @@ #include <com/sun/star/ucb/AlreadyInitializedException.hpp> #include <com/sun/star/lang/IllegalArgumentException.hpp> +#include <com/sun/star/uno/XComponentContext.hpp> namespace pcr |