clang-tidy modernize-pass-by-value in extensions

Change-Id: I9f31d6ddea3f99ed3334fa00d0f2c8448f9b9583
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136203
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 15 insertions, 14 deletions

diff --git a/extensions/source/update/feed/updatefeed.cxx b/extensions/source/update/feed/updatefeed.cxx
index ee83c3f9b436..632724118c98 100644
--- a/extensions/source/update/feed/updatefeed.cxx
+++ b/extensions/source/update/feed/updatefeed.cxx
@@ -53,6 +53,7 @@
 #include <sal/log.hxx>
 #include <osl/diagnose.h>
 #include <osl/conditn.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 
 namespace beans = com::sun::star::beans ;
@@ -159,10 +160,10 @@ public:
     virtual sal_Bool SAL_CALL supportsService(OUString const & serviceName) override;
     virtual uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() override;
 
-    UpdateInformationProvider(const uno::Reference<uno::XComponentContext>& xContext,
-                              const uno::Reference< ucb::XUniversalContentBroker >& xUniversalContentBroker,
-                              const uno::Reference< xml::dom::XDocumentBuilder >& xDocumentBuilder,
-                              const uno::Reference< xml::xpath::XXPathAPI >& xXPathAPI);
+    UpdateInformationProvider(uno::Reference<uno::XComponentContext> xContext,
+                              uno::Reference< ucb::XUniversalContentBroker > xUniversalContentBroker,
+                              uno::Reference< xml::dom::XDocumentBuilder > xDocumentBuilder,
+                              uno::Reference< xml::xpath::XXPathAPI > xXPathAPI);
 
 protected:
 
@@ -199,8 +200,8 @@ class UpdateInformationEnumeration : public ::cppu::WeakImplHelper< container::X
 {
 public:
     UpdateInformationEnumeration(const uno::Reference< xml::dom::XNodeList >& xNodeList,
-                                 const rtl::Reference< UpdateInformationProvider >& xUpdateInformationProvider) :
-        m_xUpdateInformationProvider(xUpdateInformationProvider),
+                                 rtl::Reference< UpdateInformationProvider > xUpdateInformationProvider) :
+        m_xUpdateInformationProvider(std::move(xUpdateInformationProvider)),
         m_xNodeList(xNodeList),
         m_nNodes(xNodeList.is() ? xNodeList->getLength() : 0),
         m_nCount(0)
@@ -288,14 +289,14 @@ private:
 };
 
 UpdateInformationProvider::UpdateInformationProvider(
-    const uno::Reference<uno::XComponentContext>& xContext,
-    const uno::Reference< ucb::XUniversalContentBroker >& xUniversalContentBroker,
-    const uno::Reference< xml::dom::XDocumentBuilder >& xDocumentBuilder,
-    const uno::Reference< xml::xpath::XXPathAPI >& xXPathAPI)
-    : m_xContext(xContext)
-    , m_xUniversalContentBroker(xUniversalContentBroker)
-    , m_xDocumentBuilder(xDocumentBuilder)
-    , m_xXPathAPI(xXPathAPI)
+    uno::Reference<uno::XComponentContext> xContext,
+    uno::Reference< ucb::XUniversalContentBroker > xUniversalContentBroker,
+    uno::Reference< xml::dom::XDocumentBuilder > xDocumentBuilder,
+    uno::Reference< xml::xpath::XXPathAPI > xXPathAPI)
+    : m_xContext(std::move(xContext))
+    , m_xUniversalContentBroker(std::move(xUniversalContentBroker))
+    , m_xDocumentBuilder(std::move(xDocumentBuilder))
+    , m_xXPathAPI(std::move(xXPathAPI))
     , m_aRequestHeaderList(2)
     , m_nCommandId(0)
 {