diff options
| author | Noel Grandin <noel@peralex.com> | 2014-10-27 14:02:38 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-10-29 09:36:17 +0200 |
| commit | bacee60a5920585feeff58840357aa7ac33e50a7 (patch) | |
| tree | 75da30b17723f95d35e47e4794dd6c3537833fc1 /extensions | |
| parent | 7344923ffdf751646396b38af6a23be93b53a06a (diff) | |
ref-counting vcl::Window subclasses
Points of discussion
--------------------
(*) where in the Window destructor should dispose() be called?
It's a seriously large method.
(*) we're going to need similar typedefs and declarations for every
single sub-class of vcl::Window, I assume that I will need to create a
macro to make it less verbose.
TODO
----
Update clang plugin to verify that:
(a) dispose() methods always call their superclass dispose()
(b) dispose() methods don't forget to clear any references owned
by that class.
Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/source/bibliography/bibload.cxx | 1 | ||||
| -rw-r--r-- | extensions/source/bibliography/general.cxx | 1 | ||||
| -rw-r--r-- | extensions/source/bibliography/toolbar.cxx | 2 |
3 files changed, 1 insertions, 3 deletions
diff --git a/extensions/source/bibliography/bibload.cxx b/extensions/source/bibliography/bibload.cxx index 8a732ccb2b58..3d9f5c250c39 100644 --- a/extensions/source/bibliography/bibload.cxx +++ b/extensions/source/bibliography/bibload.cxx @@ -62,7 +62,6 @@ #include <bibconfig.hxx> #include <cppuhelper/implbase4.hxx> -using namespace ::rtl; using namespace ::com::sun::star; using namespace ::com::sun::star::uno; using namespace ::com::sun::star::beans; diff --git a/extensions/source/bibliography/general.cxx b/extensions/source/bibliography/general.cxx index 7c2ca8d81842..26a2512774e2 100644 --- a/extensions/source/bibliography/general.cxx +++ b/extensions/source/bibliography/general.cxx @@ -51,7 +51,6 @@ using namespace ::com::sun::star; using namespace ::com::sun::star::uno; using namespace ::com::sun::star::form; using namespace ::com::sun::star::sdb; -using namespace ::rtl; static OUString lcl_GetColumnName( const Mapping* pMapping, sal_uInt16 nIndexPos ) { diff --git a/extensions/source/bibliography/toolbar.cxx b/extensions/source/bibliography/toolbar.cxx index 2a5d07b55fd1..bf7e81ded27c 100644 --- a/extensions/source/bibliography/toolbar.cxx +++ b/extensions/source/bibliography/toolbar.cxx @@ -281,7 +281,7 @@ void BibToolBar::InitListener() pListener=new BibToolBarListener(this,aURL.Complete,nId); } - BibToolBarListenerRef* pxInsert = new Reference<frame::XStatusListener>; + BibToolBarListenerRef* pxInsert = new uno::Reference<frame::XStatusListener>; (*pxInsert) = pListener; aListenerArr.push_back( pxInsert ); xDisp->addStatusListener(uno::Reference< frame::XStatusListener > (pListener),aURL); |