Improved loplugin:stringconstant (now that GCC 7 supports it): extensions

Change-Id: Ic99c822e8461ab46056be05846314bb772ef2957
Reviewed-on: https://gerrit.libreoffice.org/76678
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

32 files changed, 36 insertions, 36 deletions

diff --git a/extensions/source/abpilot/unodialogabp.cxx b/extensions/source/abpilot/unodialogabp.cxx
index 636fb2fbe485..ded9cd8c3049 100644
--- a/extensions/source/abpilot/unodialogabp.cxx
+++ b/extensions/source/abpilot/unodialogabp.cxx
@@ -74,7 +74,7 @@ namespace abp
 
     OUString SAL_CALL OABSPilotUno::getImplementationName()
     {
-        return OUString("org.openoffice.comp.abp.OAddressBookSourcePilot");
+        return "org.openoffice.comp.abp.OAddressBookSourcePilot";
     }
 
     css::uno::Sequence<OUString> SAL_CALL OABSPilotUno::getSupportedServiceNames()
diff --git a/extensions/source/bibliography/bibload.cxx b/extensions/source/bibliography/bibload.cxx
index 55a02482ec40..21676f75e10b 100644
--- a/extensions/source/bibliography/bibload.cxx
+++ b/extensions/source/bibliography/bibload.cxx
@@ -105,7 +105,7 @@ public:
 
                             {
                                 //!
-                                return OUString("com.sun.star.extensions.Bibliography");
+                                return "com.sun.star.extensions.Bibliography";
                                 //!
                             }
 
diff --git a/extensions/source/bibliography/framectr.cxx b/extensions/source/bibliography/framectr.cxx
index 6ca93186599c..0488e15745b5 100644
--- a/extensions/source/bibliography/framectr.cxx
+++ b/extensions/source/bibliography/framectr.cxx
@@ -165,7 +165,7 @@ BibFrameController_Impl::~BibFrameController_Impl()
 
 OUString SAL_CALL BibFrameController_Impl::getImplementationName()
 {
-    return OUString("com.sun.star.comp.extensions.Bibliography");
+    return "com.sun.star.comp.extensions.Bibliography";
 }
 
 sal_Bool SAL_CALL BibFrameController_Impl::supportsService( const OUString& sServiceName )
diff --git a/extensions/source/config/ldap/ldapuserprofilebe.cxx b/extensions/source/config/ldap/ldapuserprofilebe.cxx
index 9e5460b7b5fd..f1f3143417a9 100644
--- a/extensions/source/config/ldap/ldapuserprofilebe.cxx
+++ b/extensions/source/config/ldap/ldapuserprofilebe.cxx
@@ -204,7 +204,7 @@ css::uno::Any LdapUserProfileBe::getPropertyValue(
 
 
 OUString LdapUserProfileBe::getLdapUserProfileBeName() {
-    return OUString("com.sun.star.comp.configuration.backend.LdapUserProfileBe");
+    return "com.sun.star.comp.configuration.backend.LdapUserProfileBe";
 }
 
 
diff --git a/extensions/source/dbpilots/wizardservices.cxx b/extensions/source/dbpilots/wizardservices.cxx
index 09a2b7e2ee78..2f7b91b45a36 100644
--- a/extensions/source/dbpilots/wizardservices.cxx
+++ b/extensions/source/dbpilots/wizardservices.cxx
@@ -57,7 +57,7 @@ namespace dbp
 
     OUString OGroupBoxSI::getImplementationName()
     {
-        return OUString("org.openoffice.comp.dbp.OGroupBoxWizard");
+        return "org.openoffice.comp.dbp.OGroupBoxWizard";
     }
 
 
@@ -69,7 +69,7 @@ namespace dbp
 
     OUString OListComboSI::getImplementationName()
     {
-        return OUString("org.openoffice.comp.dbp.OListComboWizard");
+        return "org.openoffice.comp.dbp.OListComboWizard";
     }
 
 
@@ -81,7 +81,7 @@ namespace dbp
 
     OUString OGridSI::getImplementationName()
     {
-        return OUString("org.openoffice.comp.dbp.OGridWizard");
+        return "org.openoffice.comp.dbp.OGridWizard";
     }
 
 
diff --git a/extensions/source/logging/consolehandler.cxx b/extensions/source/logging/consolehandler.cxx
index 346880936e3f..a241126cc7d6 100644
--- a/extensions/source/logging/consolehandler.cxx
+++ b/extensions/source/logging/consolehandler.cxx
@@ -233,7 +233,7 @@ namespace logging
 
     OUString SAL_CALL ConsoleHandler::getImplementationName()
     {
-        return OUString("com.sun.star.comp.extensions.ConsoleHandler");
+        return "com.sun.star.comp.extensions.ConsoleHandler";
     }
 
     sal_Bool SAL_CALL ConsoleHandler::supportsService( const OUString& _rServiceName )
diff --git a/extensions/source/logging/csvformatter.cxx b/extensions/source/logging/csvformatter.cxx
index 80395cb4023b..bce6922dcb62 100644
--- a/extensions/source/logging/csvformatter.cxx
+++ b/extensions/source/logging/csvformatter.cxx
@@ -300,7 +300,7 @@ namespace logging
 
     OUString SAL_CALL CsvFormatter::getImplementationName()
     {
-        return OUString("com.sun.star.comp.extensions.CsvFormatter");
+        return "com.sun.star.comp.extensions.CsvFormatter";
     }
 
     Sequence< OUString > SAL_CALL CsvFormatter::getSupportedServiceNames()
diff --git a/extensions/source/logging/filehandler.cxx b/extensions/source/logging/filehandler.cxx
index 3aa0927ce54d..bec33521418c 100644
--- a/extensions/source/logging/filehandler.cxx
+++ b/extensions/source/logging/filehandler.cxx
@@ -332,7 +332,7 @@ namespace logging
 
     OUString SAL_CALL FileHandler::getImplementationName()
     {
-        return OUString("com.sun.star.comp.extensions.FileHandler");
+        return "com.sun.star.comp.extensions.FileHandler";
     }
 
     sal_Bool SAL_CALL FileHandler::supportsService( const OUString& _rServiceName )
diff --git a/extensions/source/logging/logger.cxx b/extensions/source/logging/logger.cxx
index 32f60a70d315..43dbe1a3a2a2 100644
--- a/extensions/source/logging/logger.cxx
+++ b/extensions/source/logging/logger.cxx
@@ -215,7 +215,7 @@ namespace logging
 
     OUString SAL_CALL LoggerPool::getImplementationName()
     {
-        return OUString("com.sun.star.comp.extensions.LoggerPool");
+        return "com.sun.star.comp.extensions.LoggerPool";
     }
 
     sal_Bool SAL_CALL LoggerPool::supportsService( const OUString& _rServiceName )
diff --git a/extensions/source/logging/plaintextformatter.cxx b/extensions/source/logging/plaintextformatter.cxx
index 3a3d0fce686d..a4ac9c35000c 100644
--- a/extensions/source/logging/plaintextformatter.cxx
+++ b/extensions/source/logging/plaintextformatter.cxx
@@ -129,7 +129,7 @@ namespace logging
 
     OUString SAL_CALL PlainTextFormatter::getImplementationName()
     {
-        return OUString("com.sun.star.comp.extensions.PlainTextFormatter");
+        return "com.sun.star.comp.extensions.PlainTextFormatter";
     }
 
     Sequence< OUString > SAL_CALL PlainTextFormatter::getSupportedServiceNames()
diff --git a/extensions/source/logging/simpletextformatter.cxx b/extensions/source/logging/simpletextformatter.cxx
index a5eb3deaf547..003c978233b1 100644
--- a/extensions/source/logging/simpletextformatter.cxx
+++ b/extensions/source/logging/simpletextformatter.cxx
@@ -83,7 +83,7 @@ sal_Bool SAL_CALL SimpleTextFormatter::supportsService(const OUString& _rService
 
 OUString SAL_CALL SimpleTextFormatter::getImplementationName()
 {
-    return OUString("com.sun.star.comp.extensions.SimpleTextFormatter");
+    return "com.sun.star.comp.extensions.SimpleTextFormatter";
 }
 
 Sequence<OUString> SAL_CALL SimpleTextFormatter::getSupportedServiceNames()
diff --git a/extensions/source/propctrlr/MasterDetailLinkDialog.cxx b/extensions/source/propctrlr/MasterDetailLinkDialog.cxx
index 4df51cddcd39..b69d6d540509 100644
--- a/extensions/source/propctrlr/MasterDetailLinkDialog.cxx
+++ b/extensions/source/propctrlr/MasterDetailLinkDialog.cxx
@@ -63,7 +63,7 @@ namespace pcr
 
     OUString MasterDetailLinkDialog::getImplementationName_static()
     {
-        return OUString("org.openoffice.comp.form.ui.MasterDetailLinkDialog");
+        return "org.openoffice.comp.form.ui.MasterDetailLinkDialog";
     }
 
 
diff --git a/extensions/source/propctrlr/buttonnavigationhandler.cxx b/extensions/source/propctrlr/buttonnavigationhandler.cxx
index 5488d9b5428b..5313fafec170 100644
--- a/extensions/source/propctrlr/buttonnavigationhandler.cxx
+++ b/extensions/source/propctrlr/buttonnavigationhandler.cxx
@@ -57,7 +57,7 @@ namespace pcr
 
     OUString ButtonNavigationHandler::getImplementationName_static(  )
     {
-        return OUString( "com.sun.star.comp.extensions.ButtonNavigationHandler" );
+        return "com.sun.star.comp.extensions.ButtonNavigationHandler";
     }
 
 
diff --git a/extensions/source/propctrlr/cellbindinghandler.cxx b/extensions/source/propctrlr/cellbindinghandler.cxx
index 3a9bda45a9c6..5db199db94ef 100644
--- a/extensions/source/propctrlr/cellbindinghandler.cxx
+++ b/extensions/source/propctrlr/cellbindinghandler.cxx
@@ -59,7 +59,7 @@ namespace pcr
 
     OUString CellBindingPropertyHandler::getImplementationName_static(  )
     {
-        return OUString( "com.sun.star.comp.extensions.CellBindingPropertyHandler" );
+        return "com.sun.star.comp.extensions.CellBindingPropertyHandler";
     }
 
 
diff --git a/extensions/source/propctrlr/controlfontdialog.cxx b/extensions/source/propctrlr/controlfontdialog.cxx
index 01238a5af478..5b34d7a76008 100644
--- a/extensions/source/propctrlr/controlfontdialog.cxx
+++ b/extensions/source/propctrlr/controlfontdialog.cxx
@@ -87,7 +87,7 @@ namespace pcr
 
     OUString OControlFontDialog::getImplementationName_static()
     {
-        return OUString("org.openoffice.comp.form.ui.OControlFontDialog");
+        return "org.openoffice.comp.form.ui.OControlFontDialog";
     }
 
 
diff --git a/extensions/source/propctrlr/defaultforminspection.cxx b/extensions/source/propctrlr/defaultforminspection.cxx
index e139745d79d8..9d19aef5fc56 100644
--- a/extensions/source/propctrlr/defaultforminspection.cxx
+++ b/extensions/source/propctrlr/defaultforminspection.cxx
@@ -78,7 +78,7 @@ namespace pcr
 
     OUString DefaultFormComponentInspectorModel::getImplementationName_static(  )
     {
-        return OUString("org.openoffice.comp.extensions.DefaultFormComponentInspectorModel");
+        return "org.openoffice.comp.extensions.DefaultFormComponentInspectorModel";
     }
 
 
diff --git a/extensions/source/propctrlr/defaulthelpprovider.cxx b/extensions/source/propctrlr/defaulthelpprovider.cxx
index 4f4a4b0b9cbf..322a04f8926c 100644
--- a/extensions/source/propctrlr/defaulthelpprovider.cxx
+++ b/extensions/source/propctrlr/defaulthelpprovider.cxx
@@ -69,7 +69,7 @@ namespace pcr
 
     OUString DefaultHelpProvider::getImplementationName_static(  )
     {
-        return OUString("org.openoffice.comp.extensions.DefaultHelpProvider");
+        return "org.openoffice.comp.extensions.DefaultHelpProvider";
     }
 
 
diff --git a/extensions/source/propctrlr/editpropertyhandler.cxx b/extensions/source/propctrlr/editpropertyhandler.cxx
index a1016e2075cd..f60edd92e0af 100644
--- a/extensions/source/propctrlr/editpropertyhandler.cxx
+++ b/extensions/source/propctrlr/editpropertyhandler.cxx
@@ -64,7 +64,7 @@ namespace pcr
 
     OUString EditPropertyHandler::getImplementationName_static(  )
     {
-        return OUString( "com.sun.star.comp.extensions.EditPropertyHandler" );
+        return "com.sun.star.comp.extensions.EditPropertyHandler";
     }
 
 
diff --git a/extensions/source/propctrlr/eformspropertyhandler.cxx b/extensions/source/propctrlr/eformspropertyhandler.cxx
index d85474156463..5bf819e099f2 100644
--- a/extensions/source/propctrlr/eformspropertyhandler.cxx
+++ b/extensions/source/propctrlr/eformspropertyhandler.cxx
@@ -75,7 +75,7 @@ namespace pcr
 
     OUString EFormsPropertyHandler::getImplementationName_static(  )
     {
-        return OUString( "com.sun.star.comp.extensions.EFormsPropertyHandler" );
+        return "com.sun.star.comp.extensions.EFormsPropertyHandler";
     }
 
 
diff --git a/extensions/source/propctrlr/eventhandler.cxx b/extensions/source/propctrlr/eventhandler.cxx
index 9d414a4be13a..d53cdba2172c 100644
--- a/extensions/source/propctrlr/eventhandler.cxx
+++ b/extensions/source/propctrlr/eventhandler.cxx
@@ -463,7 +463,7 @@ namespace pcr
 
     OUString EventHandler::getImplementationName_static(  )
     {
-        return OUString(  "com.sun.star.comp.extensions.EventHandler"  );
+        return "com.sun.star.comp.extensions.EventHandler";
     }
 
     Sequence< OUString > EventHandler::getSupportedServiceNames_static(  )
diff --git a/extensions/source/propctrlr/formcomponenthandler.cxx b/extensions/source/propctrlr/formcomponenthandler.cxx
index ed7348bfaa5d..93464c0f2669 100644
--- a/extensions/source/propctrlr/formcomponenthandler.cxx
+++ b/extensions/source/propctrlr/formcomponenthandler.cxx
@@ -164,7 +164,7 @@ namespace pcr
 
     OUString FormComponentPropertyHandler::getImplementationName_static(  )
     {
-        return OUString(  "com.sun.star.comp.extensions.FormComponentPropertyHandler"  );
+        return "com.sun.star.comp.extensions.FormComponentPropertyHandler";
     }
 
 
diff --git a/extensions/source/propctrlr/formcontroller.cxx b/extensions/source/propctrlr/formcontroller.cxx
index 3c85a0ac4190..5ac5f7fed1fb 100644
--- a/extensions/source/propctrlr/formcontroller.cxx
+++ b/extensions/source/propctrlr/formcontroller.cxx
@@ -121,7 +121,7 @@ namespace pcr
 
     OUString FormController::getImplementationName_static(  )
     {
-        return OUString("org.openoffice.comp.extensions.FormController");
+        return "org.openoffice.comp.extensions.FormController";
     }
 
 
@@ -248,7 +248,7 @@ namespace pcr
 
     OUString DialogController::getImplementationName_static(  )
     {
-        return OUString("org.openoffice.comp.extensions.DialogController");
+        return "org.openoffice.comp.extensions.DialogController";
     }
 
 
diff --git a/extensions/source/propctrlr/formgeometryhandler.cxx b/extensions/source/propctrlr/formgeometryhandler.cxx
index d97301c743ab..28c5aa03901a 100644
--- a/extensions/source/propctrlr/formgeometryhandler.cxx
+++ b/extensions/source/propctrlr/formgeometryhandler.cxx
@@ -310,7 +310,7 @@ namespace pcr
 
     OUString FormGeometryHandler::getImplementationName_static(  )
     {
-        return OUString( "com.sun.star.comp.extensions.FormGeometryHandler" );
+        return "com.sun.star.comp.extensions.FormGeometryHandler";
     }
 
 
diff --git a/extensions/source/propctrlr/genericpropertyhandler.cxx b/extensions/source/propctrlr/genericpropertyhandler.cxx
index 267ab9bc6c78..20e668c569a3 100644
--- a/extensions/source/propctrlr/genericpropertyhandler.cxx
+++ b/extensions/source/propctrlr/genericpropertyhandler.cxx
@@ -283,7 +283,7 @@ namespace pcr
 
     OUString GenericPropertyHandler::getImplementationName_static(  )
     {
-        return OUString( "com.sun.star.comp.extensions.GenericPropertyHandler" );
+        return "com.sun.star.comp.extensions.GenericPropertyHandler";
     }
 
     Sequence< OUString > GenericPropertyHandler::getSupportedServiceNames_static(  )
diff --git a/extensions/source/propctrlr/objectinspectormodel.cxx b/extensions/source/propctrlr/objectinspectormodel.cxx
index 794a6561298f..aa0628555e59 100644
--- a/extensions/source/propctrlr/objectinspectormodel.cxx
+++ b/extensions/source/propctrlr/objectinspectormodel.cxx
@@ -159,7 +159,7 @@ namespace pcr
 
     OUString ObjectInspectorModel::getImplementationName_static(  )
     {
-        return OUString( "org.openoffice.comp.extensions.ObjectInspectorModel" );
+        return "org.openoffice.comp.extensions.ObjectInspectorModel";
     }
 
 
diff --git a/extensions/source/propctrlr/pcrunodialogs.cxx b/extensions/source/propctrlr/pcrunodialogs.cxx
index fb11a982401b..e072caa70b47 100644
--- a/extensions/source/propctrlr/pcrunodialogs.cxx
+++ b/extensions/source/propctrlr/pcrunodialogs.cxx
@@ -91,7 +91,7 @@ namespace pcr
 
     OUString OTabOrderDialog::getImplementationName_static()
     {
-        return OUString("org.openoffice.comp.form.ui.OTabOrderDialog");
+        return "org.openoffice.comp.form.ui.OTabOrderDialog";
     }
 
 
diff --git a/extensions/source/propctrlr/propcontroller.cxx b/extensions/source/propctrlr/propcontroller.cxx
index 50cd32f0d12b..1b789bf86764 100644
--- a/extensions/source/propctrlr/propcontroller.cxx
+++ b/extensions/source/propctrlr/propcontroller.cxx
@@ -550,7 +550,7 @@ namespace pcr
 
     OUString OPropertyBrowserController::getImplementationName_static(  )
     {
-        return OUString("org.openoffice.comp.extensions.ObjectInspector");
+        return "org.openoffice.comp.extensions.ObjectInspector";
     }
 
 
diff --git a/extensions/source/propctrlr/stringrepresentation.cxx b/extensions/source/propctrlr/stringrepresentation.cxx
index 3d2fc67e0efb..42d638c2f9e5 100644
--- a/extensions/source/propctrlr/stringrepresentation.cxx
+++ b/extensions/source/propctrlr/stringrepresentation.cxx
@@ -613,8 +613,8 @@ bool StringRepresentation::convertStringToGenericValue( const OUString& _rString
 namespace comp_StringRepresentation {
 
 OUString _getImplementationName() {
-    return OUString(
-        "StringRepresentation");
+    return
+        "StringRepresentation";
 }
 
 uno::Sequence< OUString > _getSupportedServiceNames()
diff --git a/extensions/source/propctrlr/submissionhandler.cxx b/extensions/source/propctrlr/submissionhandler.cxx
index 63a9e5a98e35..921008c42091 100644
--- a/extensions/source/propctrlr/submissionhandler.cxx
+++ b/extensions/source/propctrlr/submissionhandler.cxx
@@ -106,7 +106,7 @@ namespace pcr
 
     OUString SubmissionPropertyHandler::getImplementationName_static(  )
     {
-        return OUString( "com.sun.star.comp.extensions.SubmissionPropertyHandler" );
+        return "com.sun.star.comp.extensions.SubmissionPropertyHandler";
     }
 
 
diff --git a/extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx b/extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx
index fb99949ca40d..0ead90425b61 100644
--- a/extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx
+++ b/extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx
@@ -87,7 +87,7 @@ namespace pcr
 
     OUString XSDValidationPropertyHandler::getImplementationName_static(  )
     {
-        return OUString( "com.sun.star.comp.extensions.XSDValidationPropertyHandler" );
+        return "com.sun.star.comp.extensions.XSDValidationPropertyHandler";
     }
 
 
diff --git a/extensions/source/scanner/scanner.cxx b/extensions/source/scanner/scanner.cxx
index d51fca0b1ef9..ae0bd96893c8 100644
--- a/extensions/source/scanner/scanner.cxx
+++ b/extensions/source/scanner/scanner.cxx
@@ -67,7 +67,7 @@ css::uno::Sequence<OUString> ScannerManager::getSupportedServiceNames()
 
 OUString ScannerManager::getImplementationName_Static() throw()
 {
-    return OUString( "com.sun.star.scanner.ScannerManager" );
+    return "com.sun.star.scanner.ScannerManager";
 }
 
 
diff --git a/extensions/source/update/feed/updatefeed.cxx b/extensions/source/update/feed/updatefeed.cxx
index 6998da2f941b..e49fb29c4c54 100644
--- a/extensions/source/update/feed/updatefeed.cxx
+++ b/extensions/source/update/feed/updatefeed.cxx
@@ -756,7 +756,7 @@ UpdateInformationProvider::getServiceNames()
 OUString
 UpdateInformationProvider::getImplName()
 {
-    return OUString("vnd.sun.UpdateInformationProvider");
+    return "vnd.sun.UpdateInformationProvider";
 }