summaryrefslogtreecommitdiff
path: root/extensions
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2016-03-09 14:31:56 +0200
committerNoel Grandin <noel@peralex.com>2016-03-10 10:09:59 +0200
commit451dd390894e0adb6ac1349fcef88eaedff79d29 (patch)
treeddd485568113834d354feb618a3ff5c50af1fce6 /extensions
parent7da15debe39b50255cc08b3fef7ae38185a9174f (diff)
loplugin:constantparam in extensions
Change-Id: Icdfde86b1291a9b831f6eac4d8c00faa326106b7
Diffstat (limited to 'extensions')
-rw-r--r--extensions/source/dbpilots/listcombowizard.cxx12
-rw-r--r--extensions/source/dbpilots/listcombowizard.hxx2
2 files changed, 7 insertions, 7 deletions
diff --git a/extensions/source/dbpilots/listcombowizard.cxx b/extensions/source/dbpilots/listcombowizard.cxx
index 0de84f5b5e63..2a7e529f8097 100644
--- a/extensions/source/dbpilots/listcombowizard.cxx
+++ b/extensions/source/dbpilots/listcombowizard.cxx
@@ -231,9 +231,9 @@ namespace dbp
}
- Sequence< OUString > OLCPage::getTableFields(bool _bNeedIt)
+ Sequence< OUString > OLCPage::getTableFields()
{
- Reference< XNameAccess > xTables = getTables(_bNeedIt);
+ Reference< XNameAccess > xTables = getTables(true);
Sequence< OUString > aColumnNames;
if (xTables.is())
{
@@ -242,7 +242,7 @@ namespace dbp
// the list table as XColumnsSupplier
Reference< XColumnsSupplier > xSuppCols;
xTables->getByName(getSettings().sListContentTable) >>= xSuppCols;
- DBG_ASSERT(!_bNeedIt || xSuppCols.is(), "OLCPage::getTableFields: no columns supplier!");
+ DBG_ASSERT(xSuppCols.is(), "OLCPage::getTableFields: no columns supplier!");
// the columns
Reference< XNameAccess > xColumns;
@@ -255,7 +255,7 @@ namespace dbp
}
catch(const Exception&)
{
- DBG_ASSERT(!_bNeedIt, "OLinkFieldsPage::initializePage: caught an exception while retrieving the columns!");
+ DBG_ASSERT(false, "OLinkFieldsPage::initializePage: caught an exception while retrieving the columns!");
}
}
return aColumnNames;
@@ -384,7 +384,7 @@ namespace dbp
OLCPage::initializePage();
// fill the list of fields
- fillListBox(*m_pSelectTableField, getTableFields(true));
+ fillListBox(*m_pSelectTableField, getTableFields());
m_pSelectTableField->SelectEntry(getSettings().sListContentField);
m_pDisplayedField->SetText(getSettings().sListContentField);
@@ -462,7 +462,7 @@ namespace dbp
// fill the value list
fillListBox(*m_pValueListField, getContext().aFieldNames);
// fill the table field list
- fillListBox(*m_pTableField, getTableFields(true));
+ fillListBox(*m_pTableField, getTableFields());
// the initial selections
m_pValueListField->SetText(getSettings().sLinkedFormField);
diff --git a/extensions/source/dbpilots/listcombowizard.hxx b/extensions/source/dbpilots/listcombowizard.hxx
index 3e90a01138bc..07d859660074 100644
--- a/extensions/source/dbpilots/listcombowizard.hxx
+++ b/extensions/source/dbpilots/listcombowizard.hxx
@@ -90,7 +90,7 @@ namespace dbp
protected:
css::uno::Reference< css::container::XNameAccess > getTables(bool _bNeedIt);
- css::uno::Sequence< OUString > getTableFields(bool _bNeedIt);
+ css::uno::Sequence< OUString > getTableFields();
};
class OContentTableSelection : public OLCPage