More -Werror,-Wunused-private-field

...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628

1 files changed, 2 insertions, 6 deletions

diff --git a/extensions/source/plugin/base/context.cxx b/extensions/source/plugin/base/context.cxx
index 7ab64f7b8c84..eaf5eab46e61 100644
--- a/extensions/source/plugin/base/context.cxx
+++ b/extensions/source/plugin/base/context.cxx
@@ -63,14 +63,12 @@ private:
     Reference< ::com::sun::star::uno::XComponentContext >   m_xContext;
     FILE*                   fp;
     Reference< ::com::sun::star::plugin::XPlugin >          m_xPlugin;
-    OUString                 m_aMIMEType;
     OUString                 m_aTarget;
     OUString                 m_aFileName;
 
 public:
     FileSink( const Reference< ::com::sun::star::uno::XComponentContext > &,
               const Reference< ::com::sun::star::plugin::XPlugin > & plugin,
-              const OUString& mimetype,
               const OUString& target,
               const Reference< ::com::sun::star::io::XActiveDataSource > & source );
     virtual ~FileSink();
@@ -259,21 +257,19 @@ void XPluginContext_Impl::postURLNotify(const Reference< ::com::sun::star::plugi
         listener->disposing( ::com::sun::star::lang::EventObject() );
 }
 
-void XPluginContext_Impl::newStream( const Reference< ::com::sun::star::plugin::XPlugin > & plugin, const OUString& mimetype, const OUString& target, const Reference< ::com::sun::star::io::XActiveDataSource > & source )
+void XPluginContext_Impl::newStream( const Reference< ::com::sun::star::plugin::XPlugin > & plugin, const OUString&, const OUString& target, const Reference< ::com::sun::star::io::XActiveDataSource > & source )
     throw( ::com::sun::star::plugin::PluginException, RuntimeException, std::exception )
 {
-    FileSink*  pNewSink = new FileSink( m_xContext, plugin, mimetype, target, source );
+    FileSink*  pNewSink = new FileSink( m_xContext, plugin, target, source );
     pNewSink->acquire();
 }
 
 
 
 FileSink::FileSink( const Reference< ::com::sun::star::uno::XComponentContext >  & rxContext, const Reference< ::com::sun::star::plugin::XPlugin > & plugin,
-                    const OUString& mimetype,
                     const OUString& target, const Reference< ::com::sun::star::io::XActiveDataSource > & source ) :
         m_xContext( rxContext ),
         m_xPlugin( plugin ),
-        m_aMIMEType( mimetype ),
         m_aTarget( target )
 {
     osl::FileBase::createTempFile( 0, 0, &m_aFileName );