diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-09-15 10:43:33 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-09-15 10:44:00 +0100 |
commit | 3c68751f6beecccda7857e414b39c8cc8db6e57a (patch) | |
tree | 62f7f2152dc0fbe8100f96b44594d7b6ff212946 /extensions | |
parent | 1ed0f437679d702b633e381eaf6f6d6f9aecdd9b (diff) |
cppcheck: noExplicitConstructor
Change-Id: If00a2de2c23271baaee126230c6bf9e657666ff4
Diffstat (limited to 'extensions')
27 files changed, 44 insertions, 41 deletions
diff --git a/extensions/source/abpilot/abpfinalpage.hxx b/extensions/source/abpilot/abpfinalpage.hxx index 1a876545a814..d7581439fb0f 100644 --- a/extensions/source/abpilot/abpfinalpage.hxx +++ b/extensions/source/abpilot/abpfinalpage.hxx @@ -50,7 +50,7 @@ namespace abp StringBag m_aInvalidDataSourceNames; public: - FinalPage( OAddessBookSourcePilot* _pParent ); + explicit FinalPage(OAddessBookSourcePilot* _pParent); virtual ~FinalPage(); virtual void dispose() SAL_OVERRIDE; diff --git a/extensions/source/abpilot/admininvokationpage.hxx b/extensions/source/abpilot/admininvokationpage.hxx index 36153d07f94a..86ec9186c88c 100644 --- a/extensions/source/abpilot/admininvokationpage.hxx +++ b/extensions/source/abpilot/admininvokationpage.hxx @@ -34,7 +34,7 @@ namespace abp bool m_bSuccessfullyExecutedDialog; public: - AdminDialogInvokationPage( OAddessBookSourcePilot* _pParent ); + explicit AdminDialogInvokationPage(OAddessBookSourcePilot* _pParent); virtual ~AdminDialogInvokationPage(); virtual void dispose() SAL_OVERRIDE; protected: diff --git a/extensions/source/abpilot/datasourcehandling.cxx b/extensions/source/abpilot/datasourcehandling.cxx index f74c5307fa06..b8df4f31ba8f 100644 --- a/extensions/source/abpilot/datasourcehandling.cxx +++ b/extensions/source/abpilot/datasourcehandling.cxx @@ -187,7 +187,10 @@ namespace abp Reference< XNameAccess > xContext; /// the UNO data source context StringBag aDataSourceNames; /// for quicker name checks (without the UNO overhead) - ODataSourceContextImpl( const Reference< XComponentContext >& _rxORB ) : xORB( _rxORB ) { } + explicit ODataSourceContextImpl(const Reference< XComponentContext >& _rxORB) + : xORB(_rxORB) + { + } }; ODataSourceContext::ODataSourceContext(const Reference< XComponentContext >& _rxORB) @@ -321,9 +324,9 @@ namespace abp OUString sName; bool bTablesUpToDate; // table name cache up-to-date? - ODataSourceImpl( const Reference< XComponentContext >& _rxORB ) - :xORB( _rxORB ) - ,bTablesUpToDate( false ) + explicit ODataSourceImpl(const Reference< XComponentContext >& _rxORB) + : xORB(_rxORB) + , bTablesUpToDate(false) { } diff --git a/extensions/source/abpilot/datasourcehandling.hxx b/extensions/source/abpilot/datasourcehandling.hxx index 8f8cb6c7a6c5..656409f50a7f 100644 --- a/extensions/source/abpilot/datasourcehandling.hxx +++ b/extensions/source/abpilot/datasourcehandling.hxx @@ -48,7 +48,7 @@ namespace abp ODataSourceContextImpl* m_pImpl; public: - ODataSourceContext( + explicit ODataSourceContext( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB ); ~ODataSourceContext(); @@ -112,7 +112,7 @@ namespace abp // - ctor/dtor/assignment /// constructs an object which is initially invalid - ODataSource( + explicit ODataSource( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB ); diff --git a/extensions/source/abpilot/fieldmappingpage.hxx b/extensions/source/abpilot/fieldmappingpage.hxx index 5244ddb9d62d..655573a6c27c 100644 --- a/extensions/source/abpilot/fieldmappingpage.hxx +++ b/extensions/source/abpilot/fieldmappingpage.hxx @@ -34,7 +34,7 @@ namespace abp VclPtr<FixedText> m_pHint; public: - FieldMappingPage( OAddessBookSourcePilot* _pParent ); + explicit FieldMappingPage(OAddessBookSourcePilot* _pParent); virtual ~FieldMappingPage(); virtual void dispose() SAL_OVERRIDE; protected: diff --git a/extensions/source/abpilot/tableselectionpage.hxx b/extensions/source/abpilot/tableselectionpage.hxx index 050191312a5d..de58a65be2b1 100644 --- a/extensions/source/abpilot/tableselectionpage.hxx +++ b/extensions/source/abpilot/tableselectionpage.hxx @@ -34,7 +34,7 @@ namespace abp VclPtr<ListBox> m_pTableList; public: - TableSelectionPage( OAddessBookSourcePilot* _pParent ); + explicit TableSelectionPage( OAddessBookSourcePilot* _pParent ); virtual ~TableSelectionPage(); virtual void dispose() SAL_OVERRIDE; protected: diff --git a/extensions/source/abpilot/typeselectionpage.hxx b/extensions/source/abpilot/typeselectionpage.hxx index d5f13a880aed..a8c1830145d8 100644 --- a/extensions/source/abpilot/typeselectionpage.hxx +++ b/extensions/source/abpilot/typeselectionpage.hxx @@ -61,7 +61,7 @@ namespace abp ::std::vector< ButtonItem > m_aAllTypes; public: - TypeSelectionPage( OAddessBookSourcePilot* _pParent ); + explicit TypeSelectionPage( OAddessBookSourcePilot* _pParent ); virtual ~TypeSelectionPage(); virtual void dispose() SAL_OVERRIDE; diff --git a/extensions/source/bibliography/bibresid.hxx b/extensions/source/bibliography/bibresid.hxx index bb96b885e1e6..808b815219da 100644 --- a/extensions/source/bibliography/bibresid.hxx +++ b/extensions/source/bibliography/bibresid.hxx @@ -27,7 +27,7 @@ class BibResId : public ResId { public: - BibResId( sal_uInt16 nId ); + explicit BibResId(sal_uInt16 nId); }; #define BIB_RESSTR(i) BibResId(i).toString() diff --git a/extensions/source/bibliography/bibshortcuthandler.hxx b/extensions/source/bibliography/bibshortcuthandler.hxx index d6310f549629..a16750b366f6 100644 --- a/extensions/source/bibliography/bibshortcuthandler.hxx +++ b/extensions/source/bibliography/bibshortcuthandler.hxx @@ -34,7 +34,7 @@ private: VclPtr<vcl::Window> pBaseClass; // in cases, where BibShortCutHandler also has to be a window protected: - inline BibShortCutHandler( vcl::Window* pBaseClass ); + explicit BibShortCutHandler( vcl::Window* pBaseClass ); public: virtual ~BibShortCutHandler(); diff --git a/extensions/source/bibliography/bibview.hxx b/extensions/source/bibliography/bibview.hxx index 86719c11b936..bfa6f57c686c 100644 --- a/extensions/source/bibliography/bibview.hxx +++ b/extensions/source/bibliography/bibview.hxx @@ -50,7 +50,7 @@ namespace bib using FormControlContainer::connectForm; using FormControlContainer::disconnectForm; using FormControlContainer::isFormConnected; - BibViewFormControlContainer(BibView *pBibView); + explicit BibViewFormControlContainer(BibView *pBibView); }; class BibView : public BibWindow diff --git a/extensions/source/bibliography/formcontrolcontainer.cxx b/extensions/source/bibliography/formcontrolcontainer.cxx index ffd71e099ee2..51265d4ef9b7 100644 --- a/extensions/source/bibliography/formcontrolcontainer.cxx +++ b/extensions/source/bibliography/formcontrolcontainer.cxx @@ -78,7 +78,7 @@ namespace bib struct ControlModeSwitch : public ::std::unary_function< Reference< XControl >, void > { bool bDesign; - ControlModeSwitch( bool _bDesign ) : bDesign( _bDesign ) { } + explicit ControlModeSwitch( bool _bDesign ) : bDesign( _bDesign ) { } void operator() ( const Reference< XControl >& _rxControl ) const { diff --git a/extensions/source/bibliography/general.cxx b/extensions/source/bibliography/general.cxx index bab2494a6cb2..d613df6dce7f 100644 --- a/extensions/source/bibliography/general.cxx +++ b/extensions/source/bibliography/general.cxx @@ -72,7 +72,7 @@ class BibPosListener :public cppu::WeakImplHelper <sdbc::XRowSetListener> { VclPtr<BibGeneralPage> pParentPage; public: - BibPosListener(BibGeneralPage* pParent); + explicit BibPosListener(BibGeneralPage* pParent); //XPositioningListener virtual void SAL_CALL cursorMoved(const lang::EventObject& event) throw( uno::RuntimeException, std::exception ) SAL_OVERRIDE; diff --git a/extensions/source/bibliography/general.hxx b/extensions/source/bibliography/general.hxx index af34aa6d6b6f..44ee591090d1 100644 --- a/extensions/source/bibliography/general.hxx +++ b/extensions/source/bibliography/general.hxx @@ -50,7 +50,7 @@ class BibGeneralPageFocusListener : public cppu::WeakAggImplHelper1 < ::com::sun private: VclPtr<BibGeneralPage> mpBibGeneralPage; public: - BibGeneralPageFocusListener(BibGeneralPage *pBibGeneralPage); + explicit BibGeneralPageFocusListener(BibGeneralPage *pBibGeneralPage); virtual void SAL_CALL focusGained( const ::com::sun::star::awt::FocusEvent& e ) throw( com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL focusLost( const ::com::sun::star::awt::FocusEvent& e ) throw( com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL disposing( const ::com::sun::star::lang::EventObject& Source ) throw( com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE; diff --git a/extensions/source/bibliography/loadlisteneradapter.hxx b/extensions/source/bibliography/loadlisteneradapter.hxx index 8bd3346d3853..bff35f2ddbc6 100644 --- a/extensions/source/bibliography/loadlisteneradapter.hxx +++ b/extensions/source/bibliography/loadlisteneradapter.hxx @@ -40,7 +40,7 @@ namespace bib OComponentAdapterBase* m_pAdapter; ::osl::Mutex& m_rMutex; protected: - OComponentListener( ::osl::Mutex& _rMutex ) + explicit OComponentListener( ::osl::Mutex& _rMutex ) :m_pAdapter( NULL ) ,m_rMutex( _rMutex ) { @@ -110,7 +110,7 @@ namespace bib friend class OLoadListenerAdapter; protected: - OLoadListener( ::osl::Mutex& _rMutex ) : OComponentListener( _rMutex ) { } + explicit OLoadListener( ::osl::Mutex& _rMutex ) : OComponentListener( _rMutex ) { } // XLoadListener equivalents virtual void _loaded( const ::com::sun::star::lang::EventObject& aEvent ) = 0; diff --git a/extensions/source/config/ldap/ldapuserprofilebe.hxx b/extensions/source/config/ldap/ldapuserprofilebe.hxx index 9f56e8d62daf..9c23200a71c9 100644 --- a/extensions/source/config/ldap/ldapuserprofilebe.hxx +++ b/extensions/source/config/ldap/ldapuserprofilebe.hxx @@ -54,7 +54,7 @@ class LdapUserProfileBe : private LdapProfileMutexHolder, public BackendBase { public: - LdapUserProfileBe(const uno::Reference<uno::XComponentContext>& xContext); + explicit LdapUserProfileBe(const uno::Reference<uno::XComponentContext>& xContext); virtual ~LdapUserProfileBe() ; // XServiceInfo diff --git a/extensions/source/dbpilots/commonpagesdbp.hxx b/extensions/source/dbpilots/commonpagesdbp.hxx index 7b8131fb1f00..36001317b8ff 100644 --- a/extensions/source/dbpilots/commonpagesdbp.hxx +++ b/extensions/source/dbpilots/commonpagesdbp.hxx @@ -41,7 +41,7 @@ namespace dbp m_xDSContext; public: - OTableSelectionPage(OControlWizard* _pParent); + explicit OTableSelectionPage(OControlWizard* _pParent); virtual ~OTableSelectionPage(); virtual void dispose() SAL_OVERRIDE; @@ -105,7 +105,7 @@ namespace dbp VclPtr<ListBox> m_pStoreWhere; public: - ODBFieldPage( OControlWizard* _pParent ); + explicit ODBFieldPage( OControlWizard* _pParent ); virtual ~ODBFieldPage(); virtual void dispose() SAL_OVERRIDE; diff --git a/extensions/source/dbpilots/gridwizard.hxx b/extensions/source/dbpilots/gridwizard.hxx index 89f311b268cc..c93f0ec64795 100644 --- a/extensions/source/dbpilots/gridwizard.hxx +++ b/extensions/source/dbpilots/gridwizard.hxx @@ -80,7 +80,7 @@ namespace dbp VclPtr<ListBox> m_pSelFields; public: - OGridFieldsSelection( OGridWizard* _pParent ); + explicit OGridFieldsSelection( OGridWizard* _pParent ); virtual ~OGridFieldsSelection(); virtual void dispose() SAL_OVERRIDE; diff --git a/extensions/source/dbpilots/groupboxwiz.hxx b/extensions/source/dbpilots/groupboxwiz.hxx index 453a93dd141a..567eebf9b86c 100644 --- a/extensions/source/dbpilots/groupboxwiz.hxx +++ b/extensions/source/dbpilots/groupboxwiz.hxx @@ -87,7 +87,7 @@ namespace dbp VclPtr<ListBox> m_pExistingRadios; public: - ORadioSelectionPage( OControlWizard* _pParent ); + explicit ORadioSelectionPage( OControlWizard* _pParent ); virtual ~ORadioSelectionPage(); virtual void dispose() SAL_OVERRIDE; @@ -115,7 +115,7 @@ namespace dbp VclPtr<ListBox> m_pDefSelection; public: - ODefaultFieldSelectionPage( OControlWizard* _pParent ); + explicit ODefaultFieldSelectionPage( OControlWizard* _pParent ); virtual ~ODefaultFieldSelectionPage(); virtual void dispose() SAL_OVERRIDE; @@ -138,7 +138,7 @@ namespace dbp m_nLastSelection; public: - OOptionValuesPage( OControlWizard* _pParent ); + explicit OOptionValuesPage( OControlWizard* _pParent ); virtual ~OOptionValuesPage(); virtual void dispose() SAL_OVERRIDE; @@ -158,7 +158,7 @@ namespace dbp class OOptionDBFieldPage : public ODBFieldPage { public: - OOptionDBFieldPage( OControlWizard* _pParent ); + explicit OOptionDBFieldPage( OControlWizard* _pParent ); protected: OOptionGroupSettings& getSettings() { return static_cast<OGroupBoxWizard*>(getDialog())->getSettings(); } @@ -173,7 +173,7 @@ namespace dbp VclPtr<Edit> m_pName; public: - OFinalizeGBWPage( OControlWizard* _pParent ); + explicit OFinalizeGBWPage( OControlWizard* _pParent ); virtual ~OFinalizeGBWPage(); virtual void dispose() SAL_OVERRIDE; diff --git a/extensions/source/dbpilots/listcombowizard.hxx b/extensions/source/dbpilots/listcombowizard.hxx index 57aee28352d8..d0b7ff3c1d97 100644 --- a/extensions/source/dbpilots/listcombowizard.hxx +++ b/extensions/source/dbpilots/listcombowizard.hxx @@ -101,7 +101,7 @@ namespace dbp VclPtr<ListBox> m_pSelectTable; public: - OContentTableSelection( OListComboWizard* _pParent ); + explicit OContentTableSelection( OListComboWizard* _pParent ); virtual ~OContentTableSelection(); virtual void dispose() SAL_OVERRIDE; @@ -128,7 +128,7 @@ namespace dbp public: - OContentFieldSelection( OListComboWizard* _pParent ); + explicit OContentFieldSelection( OListComboWizard* _pParent ); virtual ~OContentFieldSelection(); virtual void dispose() SAL_OVERRIDE; @@ -153,7 +153,7 @@ namespace dbp public: - OLinkFieldsPage( OListComboWizard* _pParent ); + explicit OLinkFieldsPage( OListComboWizard* _pParent ); virtual ~OLinkFieldsPage(); virtual void dispose() SAL_OVERRIDE; @@ -175,7 +175,7 @@ namespace dbp class OComboDBFieldPage : public ODBFieldPage { public: - OComboDBFieldPage( OControlWizard* _pParent ); + explicit OComboDBFieldPage( OControlWizard* _pParent ); protected: OListComboSettings& getSettings() { return static_cast<OListComboWizard*>(getDialog())->getSettings(); } diff --git a/extensions/source/dbpilots/optiongrouplayouter.hxx b/extensions/source/dbpilots/optiongrouplayouter.hxx index c3910eeb135f..2c1c41f256ca 100644 --- a/extensions/source/dbpilots/optiongrouplayouter.hxx +++ b/extensions/source/dbpilots/optiongrouplayouter.hxx @@ -41,7 +41,7 @@ namespace dbp mxContext; public: - OOptionGroupLayouter( + explicit OOptionGroupLayouter( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext ); diff --git a/extensions/source/dbpilots/unoautopilot.hxx b/extensions/source/dbpilots/unoautopilot.hxx index 638e97e3066a..5be6570c444f 100644 --- a/extensions/source/dbpilots/unoautopilot.hxx +++ b/extensions/source/dbpilots/unoautopilot.hxx @@ -38,7 +38,7 @@ namespace dbp ,public ::comphelper::OPropertyArrayUsageHelper< OUnoAutoPilot< TYPE, SERVICEINFO > > ,public OModuleResourceClient { - OUnoAutoPilot(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB) + explicit OUnoAutoPilot(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB) : OUnoAutoPilot_Base(_rxORB) { } diff --git a/extensions/source/inc/componentmodule.hxx b/extensions/source/inc/componentmodule.hxx index ecd6d73a4450..3515ef45b9dd 100644 --- a/extensions/source/inc/componentmodule.hxx +++ b/extensions/source/inc/componentmodule.hxx @@ -150,7 +150,7 @@ typedef ::com::sun::star::uno::Reference< ::com::sun::star::lang::XSingleService class ModuleRes : public ::ResId { public: - ModuleRes(sal_uInt16 _nId) : ResId(_nId, *OModule::getResManager()) { } + explicit ModuleRes(sal_uInt16 _nId) : ResId(_nId, *OModule::getResManager()) { } }; diff --git a/extensions/source/logging/consolehandler.cxx b/extensions/source/logging/consolehandler.cxx index f08dd6653b95..d05f0dfd6ce3 100644 --- a/extensions/source/logging/consolehandler.cxx +++ b/extensions/source/logging/consolehandler.cxx @@ -73,7 +73,7 @@ namespace logging sal_Int32 m_nThreshold; protected: - ConsoleHandler( const Reference< XComponentContext >& _rxContext ); + explicit ConsoleHandler( const Reference< XComponentContext >& _rxContext ); virtual ~ConsoleHandler(); // XConsoleHandler diff --git a/extensions/source/logging/filehandler.cxx b/extensions/source/logging/filehandler.cxx index 23ff7ec1776c..7db279da0615 100644 --- a/extensions/source/logging/filehandler.cxx +++ b/extensions/source/logging/filehandler.cxx @@ -94,7 +94,7 @@ namespace logging FileValidity m_eFileValidity; protected: - FileHandler( const Reference< XComponentContext >& _rxContext ); + explicit FileHandler( const Reference< XComponentContext >& _rxContext ); virtual ~FileHandler(); // XLogHandler diff --git a/extensions/source/logging/logger.cxx b/extensions/source/logging/logger.cxx index 5a62c8944850..fdb3360c4707 100644 --- a/extensions/source/logging/logger.cxx +++ b/extensions/source/logging/logger.cxx @@ -120,7 +120,7 @@ namespace logging ImplPool m_aImpl; public: - LoggerPool( const Reference< XComponentContext >& _rxContext ); + explicit LoggerPool( const Reference< XComponentContext >& _rxContext ); // XServiceInfo virtual OUString SAL_CALL getImplementationName() throw(RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/extensions/source/logging/methodguard.hxx b/extensions/source/logging/methodguard.hxx index a0f8cda88ca5..167b3a379617 100644 --- a/extensions/source/logging/methodguard.hxx +++ b/extensions/source/logging/methodguard.hxx @@ -38,7 +38,7 @@ namespace logging }; public: - ComponentMethodGuard( COMPONENT& _rHandler ) + explicit ComponentMethodGuard( COMPONENT& _rHandler ) :m_rHandler( _rHandler ) { m_rHandler.enterMethod( Access() ); diff --git a/extensions/source/ole/ole2uno.hxx b/extensions/source/ole/ole2uno.hxx index ae96a6932a8d..346de1e95496 100644 --- a/extensions/source/ole/ole2uno.hxx +++ b/extensions/source/ole/ole2uno.hxx @@ -71,9 +71,9 @@ void o2u_attachCurrentThread(); class BridgeRuntimeError { public: - BridgeRuntimeError(const OUString& sMessage) + explicit BridgeRuntimeError(const OUString& sMessage) + : message(sMessage) { - message = sMessage; } OUString message; }; |