diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-02 10:40:26 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-03 10:51:57 +0200 |
| commit | 054c0e7177cbef26942f8ca7cb7b1422ceea721c (patch) | |
| tree | 7390a1be5ee0797b7f43d7d433822315fd75c6dd /extensions | |
| parent | 0f499af8c2c22ccc8f1c19edeeb2bdac8cbcb7f0 (diff) | |
loplugin:simplifypointertobool improve
to look for the
x.get() != null
pattern, which can be simplified to
x
I'll do the
x.get() == nullptr
pattern in a separate patch, to reduce the chances of a mistake
Change-Id: I45e0d178e75359857cdf50d712039cb526016555
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/source/propctrlr/browserlistbox.cxx | 2 | ||||
| -rw-r--r-- | extensions/source/propctrlr/propcontroller.hxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/extensions/source/propctrlr/browserlistbox.cxx b/extensions/source/propctrlr/browserlistbox.cxx index ca62420b4d2d..6ac118cc91ba 100644 --- a/extensions/source/propctrlr/browserlistbox.cxx +++ b/extensions/source/propctrlr/browserlistbox.cxx @@ -428,7 +428,7 @@ namespace pcr _out_rpLine = line->pLine; else _out_rpLine.reset(); - return ( nullptr != _out_rpLine.get() ); + return bool(_out_rpLine); } void OBrowserListBox::EnablePropertyControls( const OUString& _rEntryName, sal_Int16 _nControls, bool _bEnable ) diff --git a/extensions/source/propctrlr/propcontroller.hxx b/extensions/source/propctrlr/propcontroller.hxx index 1afc7a7728b2..11b9a7b5cdf6 100644 --- a/extensions/source/propctrlr/propcontroller.hxx +++ b/extensions/source/propctrlr/propcontroller.hxx @@ -227,7 +227,7 @@ namespace pcr // stop the inspection void stopInspection( bool _bCommitModified ); - bool haveView() const { return m_xPropView.get() != nullptr; } + bool haveView() const { return bool(m_xPropView); } OPropertyEditor& getPropertyBox() { return m_xPropView->getPropertyBox(); } // does the inspection of the objects as indicated by our model |