diff options
| author | Noel Grandin <noel@peralex.com> | 2015-07-13 16:17:00 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2015-08-03 06:37:16 +0000 |
| commit | 2660d24a07866e083c5135ea263030f3e3a2e729 (patch) | |
| tree | 0089d6018d4fc33a7fde955e585e77191cdd258b /extensions | |
| parent | baba1d14766282bd2c592bffd79ed69f9078cfe1 (diff) | |
new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.
It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.
Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/source/scanner/sanedlg.cxx | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/extensions/source/scanner/sanedlg.cxx b/extensions/source/scanner/sanedlg.cxx index 9078823b2b94..30b3778b3f9a 100644 --- a/extensions/source/scanner/sanedlg.cxx +++ b/extensions/source/scanner/sanedlg.cxx @@ -906,8 +906,8 @@ void SaneDlg::AcquirePreview() else mrSane.SetOptionValue( nOption, true ); - BitmapTransporter aTransporter; - if( ! mrSane.Start( aTransporter ) ) + Reference<BitmapTransporter> xTransporter(new BitmapTransporter); + if( ! mrSane.Start( *xTransporter.get() ) ) { ScopedVclPtrInstance< MessageDialog > aErrorBox(this, SaneResId(STR_ERROR_SCAN)); aErrorBox->Execute(); @@ -915,11 +915,11 @@ void SaneDlg::AcquirePreview() else { #if OSL_DEBUG_LEVEL > 1 - aTransporter.getStream().Seek( STREAM_SEEK_TO_END ); - fprintf( stderr, "Previewbitmapstream contains %d bytes\n", (int)aTransporter.getStream().Tell() ); + xTransporter->getStream().Seek( STREAM_SEEK_TO_END ); + fprintf( stderr, "Previewbitmapstream contains %d bytes\n", (int)xTransporter->getStream().Tell() ); #endif - aTransporter.getStream().Seek( STREAM_SEEK_TO_BEGIN ); - mpPreview->SetBitmap(aTransporter.getStream()); + xTransporter->getStream().Seek( STREAM_SEEK_TO_BEGIN ); + mpPreview->SetBitmap(xTransporter->getStream()); } SetAdjustedNumericalValue( "resolution", fResl ); |