diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-12-12 10:45:44 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-12-13 08:12:34 +0100 |
commit | b4641df5de7842d6a8fc2c4f839214bf01160c8c (patch) | |
tree | b4ad3b357ad956a7664715d61bd7da9cc568da01 /extensions | |
parent | 753084a3f73bb8a88412feac7aa40a2750e6e9f3 (diff) |
loplugin:unusedmethods
Change-Id: I8ad75d1251df4d6f8097aaa68e4ec92331e38ad4
Reviewed-on: https://gerrit.libreoffice.org/85077
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'extensions')
-rw-r--r-- | extensions/source/propctrlr/browserline.cxx | 5 | ||||
-rw-r--r-- | extensions/source/propctrlr/browserline.hxx | 1 | ||||
-rw-r--r-- | extensions/source/propctrlr/browserlistbox.cxx | 25 | ||||
-rw-r--r-- | extensions/source/propctrlr/browserlistbox.hxx | 9 | ||||
-rw-r--r-- | extensions/source/propctrlr/browserpage.hxx | 2 | ||||
-rw-r--r-- | extensions/source/propctrlr/commoncontrol.cxx | 13 | ||||
-rw-r--r-- | extensions/source/propctrlr/commoncontrol.hxx | 5 | ||||
-rw-r--r-- | extensions/source/propctrlr/propertyeditor.cxx | 13 | ||||
-rw-r--r-- | extensions/source/propctrlr/propertyeditor.hxx | 3 | ||||
-rw-r--r-- | extensions/source/propctrlr/standardcontrol.hxx | 32 | ||||
-rw-r--r-- | extensions/source/propctrlr/usercontrol.hxx | 2 |
11 files changed, 1 insertions, 109 deletions
diff --git a/extensions/source/propctrlr/browserline.cxx b/extensions/source/propctrlr/browserline.cxx index 9d8d0360ba8e..10beadbc3ba7 100644 --- a/extensions/source/propctrlr/browserline.cxx +++ b/extensions/source/propctrlr/browserline.cxx @@ -163,11 +163,6 @@ namespace pcr Show(false); } - bool OBrowserLine::IsVisible() const - { - return m_xFtTitle->get_visible(); - } - void OBrowserLine::SetTitle(const OUString& rNewTitle ) { if ( GetTitle() == rNewTitle ) diff --git a/extensions/source/propctrlr/browserline.hxx b/extensions/source/propctrlr/browserline.hxx index 0610f8220faa..e3e668a26bb7 100644 --- a/extensions/source/propctrlr/browserline.hxx +++ b/extensions/source/propctrlr/browserline.hxx @@ -95,7 +95,6 @@ namespace pcr int GetRowHeight() const { return m_xContainer->get_preferred_size().Height(); } void Show(bool bFlag=true); void Hide(); - bool IsVisible() const; bool GrabFocus(); void ShowBrowseButton( const OUString& rImageURL, bool bPrimary ); diff --git a/extensions/source/propctrlr/browserlistbox.cxx b/extensions/source/propctrlr/browserlistbox.cxx index e2b5f82999f6..b626731b3c4c 100644 --- a/extensions/source/propctrlr/browserlistbox.cxx +++ b/extensions/source/propctrlr/browserlistbox.cxx @@ -40,8 +40,6 @@ namespace pcr { - #define FRAME_OFFSET 4 - using ::com::sun::star::uno::Any; using ::com::sun::star::uno::Exception; using ::com::sun::star::inspection::XPropertyControlContext; @@ -358,11 +356,6 @@ namespace pcr } } - long OBrowserListBox::impl_getPrefererredHelpHeight() - { - return HasHelpSection() ? m_xHelpWindow->GetOptimalHeightPixel() : 0; - } - void OBrowserListBox::SetListener( IPropertyLineListener* _pListener ) { m_pLineListener = _pListener; @@ -504,24 +497,6 @@ namespace pcr m_xScrolledWindow->vadjustment_set_step_increment(m_nRowHeight); } - sal_Int32 OBrowserListBox::GetMinimumWidth() const - { - return m_nTheNameSize + 2 * FRAME_OFFSET + (m_nRowHeight - 4) * 8; - } - - sal_Int32 OBrowserListBox::GetMinimumHeight() - { - // assume that we want to display 5 rows, at least - sal_Int32 nMinHeight = m_nRowHeight * 5; - - if ( HasHelpSection() ) - { - nMinHeight += m_xHelpWindow->GetMinimalHeightPixel(); - } - - return nMinHeight; - } - void OBrowserListBox::ShowEntry(sal_uInt16 nPos) { if (nPos == 0) diff --git a/extensions/source/propctrlr/browserlistbox.hxx b/extensions/source/propctrlr/browserlistbox.hxx index a250816dd7fb..1a1b63aaf2ef 100644 --- a/extensions/source/propctrlr/browserlistbox.hxx +++ b/extensions/source/propctrlr/browserlistbox.hxx @@ -116,10 +116,6 @@ namespace pcr void EnablePropertyControls( const OUString& _rEntryName, sal_Int16 _nControls, bool _bEnable ); void EnablePropertyLine( const OUString& _rEntryName, bool _bEnable ); - sal_Int32 GetMinimumWidth() const; - sal_Int32 GetMinimumHeight(); - - bool IsModified( ) const; void CommitModified( ); @@ -166,11 +162,6 @@ namespace pcr found. */ bool impl_getBrowserLineForName( const OUString& _rEntryName, BrowserLinePointer& _out_rpLine ) const; - - /** returns the preferred height (in pixels) of the help section, or 0 if we - currently don't have a help section - */ - long impl_getPrefererredHelpHeight(); }; diff --git a/extensions/source/propctrlr/browserpage.hxx b/extensions/source/propctrlr/browserpage.hxx index 14999217431e..4018a6b6c3e6 100644 --- a/extensions/source/propctrlr/browserpage.hxx +++ b/extensions/source/propctrlr/browserpage.hxx @@ -41,10 +41,8 @@ namespace pcr ~OBrowserPage(); void SetPageTitle(const OUString& rPageTitle) { m_aPageTitle = rPageTitle; } - const OUString& GetPageTitle() const { return m_aPageTitle; } void SetHelpId(const OString& rHelpId) { m_xContainer->set_help_id(rHelpId); } - OString GetHelpId() const { return m_xContainer->get_help_id(); } OBrowserListBox& getListBox() { return *m_xListBox; } const OBrowserListBox& getListBox() const { return *m_xListBox; } diff --git a/extensions/source/propctrlr/commoncontrol.cxx b/extensions/source/propctrlr/commoncontrol.cxx index b60ecdc8763f..e4c9eac2cd85 100644 --- a/extensions/source/propctrlr/commoncontrol.cxx +++ b/extensions/source/propctrlr/commoncontrol.cxx @@ -65,19 +65,6 @@ namespace pcr } } - void CommonBehaviourControlHelper::activateNextControl() const - { - try - { - if ( m_xContext.is() ) - m_xContext->activateNextControl( &m_rAntiImpl ); - } - catch( const Exception& ) - { - DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); - } - } - IMPL_LINK_NOARG( CommonBehaviourControlHelper, EditModifiedHdl, weld::Entry&, void ) { setModified(); diff --git a/extensions/source/propctrlr/commoncontrol.hxx b/extensions/source/propctrlr/commoncontrol.hxx index 5550435ff963..fc77505352f5 100644 --- a/extensions/source/propctrlr/commoncontrol.hxx +++ b/extensions/source/propctrlr/commoncontrol.hxx @@ -84,17 +84,12 @@ namespace pcr /// @throws css::uno::RuntimeException void notifyModifiedValue( ); - /** (fail-safe) wrapper around calling our context's activateNextControl - */ - void activateNextControl() const; - virtual weld::Widget* getWidget() = 0; /// may be used by derived classes, they forward the event to the PropCtrListener DECL_LINK( ModifiedHdl, weld::ComboBox&, void ); DECL_LINK( ColorModifiedHdl, ColorListBox&, void ); DECL_LINK( EditModifiedHdl, weld::Entry&, void ); - DECL_LINK( TextViewModifiedHdl, weld::TextView&, void ); DECL_LINK( MetricModifiedHdl, weld::MetricSpinButton&, void ); DECL_LINK( FormattedModifiedHdl, weld::FormattedSpinButton&, void ); DECL_LINK( TimeModifiedHdl, weld::TimeSpinButton&, void ); diff --git a/extensions/source/propctrlr/propertyeditor.cxx b/extensions/source/propctrlr/propertyeditor.cxx index 0b0de48a2b12..41a7be1d3547 100644 --- a/extensions/source/propctrlr/propertyeditor.cxx +++ b/extensions/source/propctrlr/propertyeditor.cxx @@ -170,19 +170,6 @@ namespace pcr return m_xTabControl->get_current_page_ident().toUInt32(); } - void OPropertyEditor::Update(const std::function<void(OBrowserListBox *)>& _aUpdateFunction) - { - // forward this to all our pages - int nCount = m_xTabControl->get_n_pages(); - for (int i = 0; i < nCount; ++i) - { - sal_uInt16 nID = m_xTabControl->get_page_ident(i).toUInt32(); - OBrowserPage* pPage = getPage(nID); - if (pPage) - _aUpdateFunction(&pPage->getListBox()); - } - } - void OPropertyEditor::forEachPage( PageOperation _pOperation ) { int nCount = m_xTabControl->get_n_pages(); diff --git a/extensions/source/propctrlr/propertyeditor.hxx b/extensions/source/propctrlr/propertyeditor.hxx index 3d9265c67cb8..d04ab25fc9c0 100644 --- a/extensions/source/propctrlr/propertyeditor.hxx +++ b/extensions/source/propctrlr/propertyeditor.hxx @@ -104,7 +104,6 @@ namespace pcr Size get_preferred_size() const; weld::Container* getWidget() const { return m_xTabControl.get(); } - weld::Container* getControlHoldingParent() const { return m_xControlHoldingParent.get(); } void Show() { m_xTabControl->show(); } void Hide() { m_xTabControl->hide(); } @@ -119,8 +118,6 @@ namespace pcr OBrowserPage* getPage( const OUString& _rPropertyName ); const OBrowserPage* getPage( const OUString& _rPropertyName ) const; - void Update(const std::function<void(OBrowserListBox *)>& _aUpdateFunction); - typedef void (OPropertyEditor::*PageOperation)( OBrowserPage&, const void* ); void forEachPage( PageOperation _pOperation ); diff --git a/extensions/source/propctrlr/standardcontrol.hxx b/extensions/source/propctrlr/standardcontrol.hxx index 27f09e99ae62..3eaf71f5a1f7 100644 --- a/extensions/source/propctrlr/standardcontrol.hxx +++ b/extensions/source/propctrlr/standardcontrol.hxx @@ -36,38 +36,6 @@ namespace pcr { - //= ListLikeControlWithModifyHandler - - /** Very small helper class which adds a SetModifyHdl to a ListBox-derived class, - thus giving this class the same API (as far as the CommonBehaviourControl is concerned) - as all other windows. - */ - template< class TListboxWindow > - class ListLikeControlWithModifyHandler : public TListboxWindow - { - public: - ListLikeControlWithModifyHandler( vcl::Window* pParent, WinBits _nStyle ) - : TListboxWindow( pParent, _nStyle ) - { - TListboxWindow::SetSelectHdl( LINK(this, ListLikeControlWithModifyHandler, OnSelect) ); - } - - void SetModifyHdl( const Link<TListboxWindow&,void>& _rLink ) { aModifyHdl = _rLink; } - private: - DECL_LINK(OnSelect, TListboxWindow&, void); - Link<TListboxWindow&,void> aModifyHdl; - }; - - template< class LISTBOX_WINDOW > - void ListLikeControlWithModifyHandler< LISTBOX_WINDOW >::LinkStubOnSelect(void * instance, LISTBOX_WINDOW& data) { - return static_cast<ListLikeControlWithModifyHandler< LISTBOX_WINDOW > *>(instance)->OnSelect(data); - } - template< class LISTBOX_WINDOW > - void ListLikeControlWithModifyHandler< LISTBOX_WINDOW >::OnSelect(LISTBOX_WINDOW& rListBox) - { - aModifyHdl.Call(rListBox); - } - //= OTimeControl typedef CommonBehaviourControl<css::inspection::XPropertyControl, weld::TimeSpinButton> OTimeControl_Base; class OTimeControl : public OTimeControl_Base diff --git a/extensions/source/propctrlr/usercontrol.hxx b/extensions/source/propctrlr/usercontrol.hxx index b13766c1bc82..3283a6f56f96 100644 --- a/extensions/source/propctrlr/usercontrol.hxx +++ b/extensions/source/propctrlr/usercontrol.hxx @@ -21,7 +21,7 @@ #define INCLUDED_EXTENSIONS_SOURCE_PROPCTRLR_USERCONTROL_HXX #include "commoncontrol.hxx" -#include <svtools/fileurlbox.hxx> +#include <svtools/inettbc.hxx> #include <svl/zforlist.hxx> #include "standardcontrol.hxx" |