diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-10-09 10:28:48 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-10-09 14:47:17 +0200 |
| commit | 7ceee0f1ec0e349d0df4980d7fdedbd13c7917c5 (patch) | |
| tree | 616ab419fe0f01e94740de7faacb393775420589 /extensions | |
| parent | 664db0d945fbb23e115eeea8377e3a4e88541da1 (diff) | |
Extend loplugin:redundantinline to catch inline functions w/o external linkage
...where "inline" (in its meaning of "this function can be defined in multiple
translation units") thus doesn't make much sense. (As discussed in
compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions
in include files for now.)
All the rewriting has been done automatically by the plugin, except for one
instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus
some subsequent solenv/clang-format/reformat-formatted-files.
Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224
Reviewed-on: https://gerrit.libreoffice.org/61573
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/source/logging/csvformatter.cxx | 4 | ||||
| -rw-r--r-- | extensions/source/scanner/sane.cxx | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/extensions/source/logging/csvformatter.cxx b/extensions/source/logging/csvformatter.cxx index 2e98243864a0..12ebce788433 100644 --- a/extensions/source/logging/csvformatter.cxx +++ b/extensions/source/logging/csvformatter.cxx @@ -89,7 +89,7 @@ namespace const sal_Unicode comma_char = ','; const OUString dos_newline = "\r\n"; - inline bool needsQuoting(const OUString& str) + bool needsQuoting(const OUString& str) { static const OUString quote_trigger_chars = "\",\n\r"; sal_Int32 len = str.getLength(); @@ -99,7 +99,7 @@ namespace return false; }; - inline void appendEncodedString(OUStringBuffer& buf, const OUString& str) + void appendEncodedString(OUStringBuffer& buf, const OUString& str) { if(needsQuoting(str)) { diff --git a/extensions/source/scanner/sane.cxx b/extensions/source/scanner/sane.cxx index 1231037d712d..824c0cdf6fc1 100644 --- a/extensions/source/scanner/sane.cxx +++ b/extensions/source/scanner/sane.cxx @@ -40,7 +40,7 @@ #else #define dump_state( a, b, c, d ) ; #endif -static inline void dbg_msg( const char* pString, ... ) +static void dbg_msg( const char* pString, ... ) { #if (OSL_DEBUG_LEVEL > 0) || defined DBG_UTIL va_list ap; @@ -472,7 +472,7 @@ enum FrameStyleType { #define BYTE_BUFFER_SIZE 32768 -static inline sal_uInt8 ReadValue( FILE* fp, int depth ) +static sal_uInt8 ReadValue( FILE* fp, int depth ) { if( depth == 16 ) { |