cppcheck: noExplicitConstructor

Change-Id: Ifdcb1cc12645d6cdba81d16f94f0268696187cde
Reviewed-on: https://gerrit.libreoffice.org/21201
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

14 files changed, 21 insertions, 21 deletions

diff --git a/extensions/source/activex/SOActiveX.cxx b/extensions/source/activex/SOActiveX.cxx
index 09e3f26aa89a..74d82632f8c4 100644
--- a/extensions/source/activex/SOActiveX.cxx
+++ b/extensions/source/activex/SOActiveX.cxx
@@ -946,7 +946,7 @@ class LockingGuard
 {
     BOOL& mbLocked;
 public:
-    LockingGuard( BOOL& bLocked )
+    explicit LockingGuard( BOOL& bLocked )
     : mbLocked( bLocked )
     {
         mbLocked = TRUE;
diff --git a/extensions/source/ole/servprov.hxx b/extensions/source/ole/servprov.hxx
index 06ced5eb136a..8cf9e55c77b1 100644
--- a/extensions/source/ole/servprov.hxx
+++ b/extensions/source/ole/servprov.hxx
@@ -169,7 +169,7 @@ class OleConverter_Impl2 : public WeakImplHelper<XBridgeSupplier2, XInitializati
                             public UnoConversionUtilities<OleConverter_Impl2>
 {
 public:
-    OleConverter_Impl2( const Reference<XMultiServiceFactory>& smgr);
+    explicit OleConverter_Impl2( const Reference<XMultiServiceFactory>& smgr);
     OleConverter_Impl2( const  Reference<XMultiServiceFactory>& smgr, sal_uInt8 unoWrapperClass, sal_uInt8 comWrapperClass );
     virtual ~OleConverter_Impl2();
 
@@ -214,7 +214,7 @@ class OleClient_Impl : public WeakImplHelper<XMultiServiceFactory, css::lang::XS
                        public UnoConversionUtilities<OleClient_Impl>
 {
 public:
-    OleClient_Impl( const Reference<XMultiServiceFactory>& smgr);
+    explicit OleClient_Impl( const Reference<XMultiServiceFactory>& smgr);
     ~OleClient_Impl();
 
     // XMultiServiceFactory
@@ -253,7 +253,7 @@ protected:
 class OleServer_Impl : public cppu::WeakImplHelper<css::lang::XServiceInfo>
 {
 public:
-    OleServer_Impl( const Reference<XMultiServiceFactory> &smgr);
+    explicit OleServer_Impl( const Reference<XMultiServiceFactory> &smgr);
     ~OleServer_Impl();
 
     OUString SAL_CALL getImplementationName()
diff --git a/extensions/source/ole/unoconversionutilities.hxx b/extensions/source/ole/unoconversionutilities.hxx
index 83d3a18078b9..ea857fffafde 100644
--- a/extensions/source/ole/unoconversionutilities.hxx
+++ b/extensions/source/ole/unoconversionutilities.hxx
@@ -101,7 +101,7 @@ template< class >
 class UnoConversionUtilities
 {
 public:
-    UnoConversionUtilities( const Reference<XMultiServiceFactory> & smgr):
+    explicit UnoConversionUtilities( const Reference<XMultiServiceFactory> & smgr):
         m_nUnoWrapperClass( INTERFACE_OLE_WRAPPER_IMPL),
         m_nComWrapperClass( IUNKNOWN_WRAPPER_IMPL),
         m_smgr( smgr)
diff --git a/extensions/source/ole/windata.hxx b/extensions/source/ole/windata.hxx
index 5e6c30abcefe..b8b43ce2ca7a 100644
--- a/extensions/source/ole/windata.hxx
+++ b/extensions/source/ole/windata.hxx
@@ -56,7 +56,7 @@ public:
     CComPtr< ITypeInfo > m_pTypeInfo;
     VARDESC* m_pVarDesc;
 
-    VarDesc(ITypeInfo* pTypeInfo) :
+    explicit VarDesc(ITypeInfo* pTypeInfo) :
       m_pTypeInfo(pTypeInfo),
       m_pVarDesc(NULL)
    {
@@ -96,7 +96,7 @@ class FuncDesc
 
 public:
 
-    FuncDesc(ITypeInfo * pTypeInfo) :
+    explicit FuncDesc(ITypeInfo * pTypeInfo) :
         m_pTypeInfo(pTypeInfo),
         m_pFuncDesc(NULL)
         {
@@ -174,7 +174,7 @@ public:
     CComPtr< ITypeInfo > m_pTypeInfo;
     TYPEATTR* m_pTypeAttr;
 
-    TypeAttr(ITypeInfo* pTypeInfo) :
+    explicit TypeAttr(ITypeInfo* pTypeInfo) :
       m_pTypeInfo( pTypeInfo ),
       m_pTypeAttr( NULL )
    {
diff --git a/extensions/source/propctrlr/pcrunodialogs.hxx b/extensions/source/propctrlr/pcrunodialogs.hxx
index bfd05f67525d..15499438f091 100644
--- a/extensions/source/propctrlr/pcrunodialogs.hxx
+++ b/extensions/source/propctrlr/pcrunodialogs.hxx
@@ -50,7 +50,7 @@ namespace pcr
         // </properties>
 
     public:
-        OTabOrderDialog( const css::uno::Reference< css::uno::XComponentContext >& _rxContext );
+        explicit OTabOrderDialog( const css::uno::Reference< css::uno::XComponentContext >& _rxContext );
         virtual ~OTabOrderDialog();
 
         // XTypeProvider
diff --git a/extensions/source/scanner/grid.cxx b/extensions/source/scanner/grid.cxx
index ccdb44cd8492..4bc1b999046b 100644
--- a/extensions/source/scanner/grid.cxx
+++ b/extensions/source/scanner/grid.cxx
@@ -118,7 +118,7 @@ class GridWindow : public vcl::Window
     virtual Size GetOptimalSize() const override;
     void drawLine(vcl::RenderContext& rRenderContext, double x1, double y1, double x2, double y2);
 public:
-    GridWindow(vcl::Window* pParent);
+    explicit GridWindow(vcl::Window* pParent);
     void Init(double* pXValues, double* pYValues, int nValues, bool bCutValues, const BitmapEx &rMarkerBitmap);
     virtual ~GridWindow();
     virtual void dispose() override;
diff --git a/extensions/source/update/check/download.cxx b/extensions/source/update/check/download.cxx
index 45ac34e76410..292df2011e64 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -54,7 +54,7 @@ struct OutData
     osl::Condition& StopCondition;
     CURL *curl;
 
-    OutData(osl::Condition& rCondition) : FileHandle(nullptr), Offset(0), StopCondition(rCondition), curl(nullptr) {};
+    explicit OutData(osl::Condition& rCondition) : FileHandle(nullptr), Offset(0), StopCondition(rCondition), curl(nullptr) {};
 };
 
 
diff --git a/extensions/source/update/check/updatecheck.cxx b/extensions/source/update/check/updatecheck.cxx
index 600e408b45ab..4f93a77d3d8d 100644
--- a/extensions/source/update/check/updatecheck.cxx
+++ b/extensions/source/update/check/updatecheck.cxx
@@ -303,7 +303,7 @@ public:
 class MenuBarButtonJob : public ::cppu::WeakImplHelper< task::XJob >
 {
 public:
-    MenuBarButtonJob(const rtl::Reference< UpdateCheck >& rUpdateCheck);
+    explicit MenuBarButtonJob(const rtl::Reference< UpdateCheck >& rUpdateCheck);
 
     // XJob
     virtual uno::Any SAL_CALL execute(const uno::Sequence<beans::NamedValue>&)
@@ -341,7 +341,7 @@ private:
 class ShutdownThread :  public osl::Thread
 {
 public:
-    ShutdownThread( const uno::Reference<uno::XComponentContext>& xContext );
+    explicit ShutdownThread(const uno::Reference<uno::XComponentContext>& xContext);
 
     virtual void SAL_CALL run() override;
     virtual void SAL_CALL onTerminated() override;
diff --git a/extensions/source/update/check/updatecheckconfig.hxx b/extensions/source/update/check/updatecheckconfig.hxx
index df8b4fcd386c..d4a9a55094ce 100644
--- a/extensions/source/update/check/updatecheckconfig.hxx
+++ b/extensions/source/update/check/updatecheckconfig.hxx
@@ -37,7 +37,7 @@ class NamedValueByNameAccess
     const css::uno::Sequence< css::beans::NamedValue >& m_rValues;
 
 public:
-    NamedValueByNameAccess(
+    explicit NamedValueByNameAccess(
         const css::uno::Sequence< css::beans::NamedValue >& rValues) :
         m_rValues(rValues) {} ;
 
@@ -53,7 +53,7 @@ public:
 class UpdateCheckROModel
 {
 public:
-    UpdateCheckROModel(NamedValueByNameAccess& aNameAccess) : m_aNameAccess(aNameAccess) {};
+    explicit UpdateCheckROModel(NamedValueByNameAccess& aNameAccess) : m_aNameAccess(aNameAccess) {};
 
     bool isAutoCheckEnabled() const;
     bool isDownloadPaused() const;
diff --git a/extensions/source/update/feed/updatefeed.cxx b/extensions/source/update/feed/updatefeed.cxx
index 699cf8d2ebe6..1e459c999259 100644
--- a/extensions/source/update/feed/updatefeed.cxx
+++ b/extensions/source/update/feed/updatefeed.cxx
@@ -80,7 +80,7 @@ class InputStreamWrapper : public ::cppu::WeakImplHelper< io::XInputStream >
     uno::Reference< io::XInputStream > m_xStream;
 
 public:
-    InputStreamWrapper(const uno::Reference< io::XInputStream >& rxStream) :
+    explicit InputStreamWrapper(const uno::Reference< io::XInputStream >& rxStream) :
         m_xStream(rxStream) {};
 
     virtual sal_Int32 SAL_CALL readBytes(uno::Sequence< sal_Int8 >& aData, sal_Int32 nBytesToRead)
@@ -296,7 +296,7 @@ private:
 class SingleUpdateInformationEnumeration : public ::cppu::WeakImplHelper< container::XEnumeration >
 {
 public:
-    SingleUpdateInformationEnumeration(const uno::Reference< xml::dom::XElement >& xElement)
+    explicit SingleUpdateInformationEnumeration(const uno::Reference< xml::dom::XElement >& xElement)
         : m_nCount(0) { m_aEntry.UpdateDocument = xElement; };
     virtual ~SingleUpdateInformationEnumeration() {};
 
diff --git a/extensions/source/update/ui/updatecheckui.cxx b/extensions/source/update/ui/updatecheckui.cxx
index a168e5e8acec..804819137069 100644
--- a/extensions/source/update/ui/updatecheckui.cxx
+++ b/extensions/source/update/ui/updatecheckui.cxx
@@ -157,7 +157,7 @@ private:
     Image           GetBubbleImage( OUString &rURL );
 
 public:
-                    UpdateCheckUI(const uno::Reference<uno::XComponentContext>&);
+    explicit        UpdateCheckUI(const uno::Reference<uno::XComponentContext>&);
     virtual        ~UpdateCheckUI();
 
     // XServiceInfo
diff --git a/extensions/test/ole/OleClient/axhost.hxx b/extensions/test/ole/OleClient/axhost.hxx
index ea62befd2754..759b6eff4bba 100644
--- a/extensions/test/ole/OleClient/axhost.hxx
+++ b/extensions/test/ole/OleClient/axhost.hxx
@@ -32,7 +32,7 @@ class HostWin: public CWindowImpl<HostWin, CWindow,
     CComBSTR controlName;
     CComPtr<IUnknown> spControl;
 public:
-    HostWin(LPWSTR progid);
+    explicit HostWin(LPWSTR progid);
 
     ~HostWin();
 
diff --git a/extensions/workben/pythonautotest.cxx b/extensions/workben/pythonautotest.cxx
index a7ee631e8a75..3fe5365210de 100644
--- a/extensions/workben/pythonautotest.cxx
+++ b/extensions/workben/pythonautotest.cxx
@@ -214,7 +214,7 @@ public:
     }
 
 
-    TestListener( XDebuggingRef *p )
+    explicit TestListener( XDebuggingRef *p )
     {
         attach( p  );
     }
diff --git a/extensions/workben/testpgp.cxx b/extensions/workben/testpgp.cxx
index a95cba91c227..743b08f6fb39 100644
--- a/extensions/workben/testpgp.cxx
+++ b/extensions/workben/testpgp.cxx
@@ -64,7 +64,7 @@ class DataSource_Impl :
     int                m_fd;
 
 public:
-    DataSource_Impl (int fd = 0);
+    explicit DataSource_Impl(int fd = 0);
     virtual ~DataSource_Impl();
 
     void setBuffer (const Sequence<sal_Int8> &rBuffer);