tdf#164225: Only install MAR update_service when it will be needed

...where "will be needed" is approximated by "install location is under
C:\Program Files" (i.e., where admin privileges will be necessary to do an
update)

Change-Id: I00c93df8c0c2c5132fffa4056b88af098cb4a644
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178679
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins

1 files changed, 18 insertions, 0 deletions

diff --git a/external/onlineupdate/install_updateservice.cxx b/external/onlineupdate/install_updateservice.cxx
index c1d547156098..47c90bc148d6 100644
--- a/external/onlineupdate/install_updateservice.cxx
+++ b/external/onlineupdate/install_updateservice.cxx
@@ -18,6 +18,7 @@
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 #include <msiquery.h>
+#include <shlobj.h>
 
 #include <pathhash.h>
 
@@ -80,6 +81,23 @@ CloseHandleGuard guard(HANDLE handle) { return CloseHandleGuard(handle, CloseHan
 
 bool runExecutable(std::wstring const& installLocation, wchar_t const* argument)
 {
+    bool use = false;
+    PWSTR progPath;
+    if (SHGetKnownFolderPath(FOLDERID_ProgramFiles, 0, nullptr, &progPath) == S_OK)
+    {
+        auto const n = wcslen(progPath);
+        // For SHGetKnownFolderPath it is guaranteed that "The returned path does not include a
+        // trailing backslash":
+        use = (installLocation.size() == n
+               || (installLocation.size() > n && installLocation[n] == L'\\'))
+              && _wcsnicmp(progPath, installLocation.data(), n) == 0;
+    }
+    CoTaskMemFree(progPath);
+    if (!use)
+    {
+        return true;
+    }
+
     std::wstring cmdline(L"\"");
     cmdline += installLocation;
     cmdline += L"\\program\\update_service.exe\" ";