diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2021-03-17 11:54:12 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2021-03-29 21:21:18 +0200 |
| commit | fb376fb7cfd8559c89f89af967e5ca2bbb138e52 (patch) | |
| tree | aeca2291eb939ce417b2ec3554fb09cbb499b183 /external | |
| parent | 67e53dfeadbbc4f4ab207af0d2cd4e8f556b73d4 (diff) | |
speed up SkiaHelper::dump() in Skia debug builds
Change-Id: Ic5c4bb38e9b8c0c1bb0e3efc2c5ee7a3fa787d93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113320
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'external')
| -rw-r--r-- | external/skia/Library_skia.mk | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/external/skia/Library_skia.mk b/external/skia/Library_skia.mk index 7ab2877d55ae..a1f1f1c30ef6 100644 --- a/external/skia/Library_skia.mk +++ b/external/skia/Library_skia.mk @@ -30,6 +30,8 @@ $(eval $(call gb_Library_add_defs,skia,\ # This controls whether to build with compiler optimizations, normally yes, --enable-skia=debug # allows to build non-optimized. We normally wouldn't debug a 3rd-party library, and Skia # performance is relatively important (it may be the drawing engine used in software mode). +# Some code may be always built with optimizations, even with Skia debug enabled (see +# $(gb_COMPILEROPTFLAGS) usage). ifeq ($(ENABLE_SKIA_DEBUG),) $(eval $(call gb_Library_add_cxxflags,skia, \ $(gb_COMPILEROPTFLAGS) \ @@ -896,8 +898,14 @@ $(eval $(call gb_Library_add_generated_exception_objects,skia,\ endif $(eval $(call gb_Library_add_generated_exception_objects,skia,\ - UnpackedTarball/skia/third_party/skcms/skcms \ UnpackedTarball/skia/third_party/vulkanmemoryallocator/GrVulkanMemoryAllocator \ )) +# Skcms code is used by png writer, which is used by SkiaHelper::dump(). Building +# this without optimizations would mean having each pixel of saved images be +# processed by unoptimized code. +$(eval $(call gb_Library_add_generated_exception_objects,skia,\ + UnpackedTarball/skia/third_party/skcms/skcms, $(gb_COMPILEROPTFLAGS) \ +)) + # vim: set noet sw=4 ts=4: |