diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-20 08:11:58 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-20 07:34:27 +0000 |
| commit | f255c3e96e25a43a4724d80287554d892d7ffd70 (patch) | |
| tree | d254a6911479fcea98ec5c04569951219bb68501 /external | |
| parent | 60b6b1eae563c727160724a8671844bf8136f5d5 (diff) | |
[API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always true
* GCC documents -fvisibility at least as far back as the GCC 4.0 online
documentation at
<https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>.
* For external code, odk/settings/settings.mk unconditionally set
HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows.
Make this a fatal configure error for now. The check should be removed
completely after LO 5.3 branch-off.
Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112
Reviewed-on: https://gerrit.libreoffice.org/29073
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'external')
| -rw-r--r-- | external/clew/source/include/clew/clew.h | 4 | ||||
| -rw-r--r-- | external/openssl/ExternalProject_openssl.mk | 5 |
2 files changed, 3 insertions, 6 deletions
diff --git a/external/clew/source/include/clew/clew.h b/external/clew/source/include/clew/clew.h index b23dc6041543..7b325d1ddf4e 100644 --- a/external/clew/source/include/clew/clew.h +++ b/external/clew/source/include/clew/clew.h @@ -1015,10 +1015,8 @@ typedef CL_API_ENTRY void * (CL_API_CALL * PFNCLGETEXTENSIONFUNCTIONADDRESS)(con # ifdef CLEW_BUILD # if defined(_WIN32) # define CLEWAPI extern __declspec(dllexport) -# elif defined(HAVE_GCC_VISIBILITY_FEATURE) -# define CLEWAPI extern __attribute__ ((visibility("default"))) # else -# define CLEWAPI extern +# define CLEWAPI extern __attribute__ ((visibility("default"))) # endif # else # if defined(_WIN32) diff --git a/external/openssl/ExternalProject_openssl.mk b/external/openssl/ExternalProject_openssl.mk index 9ae7a1395cc6..aa25c3a776de 100644 --- a/external/openssl/ExternalProject_openssl.mk +++ b/external/openssl/ExternalProject_openssl.mk @@ -86,9 +86,8 @@ $(call gb_ExternalProject_get_state_target,openssl,build): $(if $(SYSBASE),-I$(SYSBASE)/usr/include -L$(SYSBASE)/usr/lib)) \ $(if $(filter MACOSX,$(OS)),--prefix=/@.__________________________________________________OOO) \ && $(MAKE) build_libs \ - CC="$(CC) -fPIC $(if $(filter-out WNT MACOSX,$(OS)),\ - $(if $(filter TRUE,$(HAVE_GCC_VISIBILITY_FEATURE)),\ - -fvisibility=hidden))" \ + CC="$(CC) -fPIC \ + $(if $(filter-out WNT MACOSX,$(OS)),-fvisibility=hidden)" \ ) endif |