diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2017-01-26 12:28:58 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2017-01-26 12:54:43 +0000 |
commit | e57ca02849c3d87142ff5ff9099a212e72b8139c (patch) | |
tree | bcce66b27261553c308779f3e8663a269ed3a671 /filter/source/graphic | |
parent | 8802ebd5172ec4bc412a59d136c82b77ab452281 (diff) |
Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'filter/source/graphic')
-rw-r--r-- | filter/source/graphic/GraphicExportDialog.cxx | 10 | ||||
-rw-r--r-- | filter/source/graphic/GraphicExportDialog.hxx | 15 | ||||
-rw-r--r-- | filter/source/graphic/GraphicExportFilter.cxx | 5 | ||||
-rw-r--r-- | filter/source/graphic/GraphicExportFilter.hxx | 8 |
4 files changed, 14 insertions, 24 deletions
diff --git a/filter/source/graphic/GraphicExportDialog.cxx b/filter/source/graphic/GraphicExportDialog.cxx index a6f74f735688..1c86d6bc2588 100644 --- a/filter/source/graphic/GraphicExportDialog.cxx +++ b/filter/source/graphic/GraphicExportDialog.cxx @@ -47,11 +47,11 @@ GraphicExportDialog::~GraphicExportDialog() } // XInitialization -void SAL_CALL GraphicExportDialog::initialize( const Sequence<Any>& ) throw ( Exception, RuntimeException, std::exception ) +void SAL_CALL GraphicExportDialog::initialize( const Sequence<Any>& ) {} // XPropertyAccess -Sequence<PropertyValue> GraphicExportDialog::getPropertyValues() throw ( RuntimeException, std::exception ) +Sequence<PropertyValue> GraphicExportDialog::getPropertyValues() { sal_Int32 i; sal_Int32 nCount = maMediaDescriptor.getLength(); @@ -76,8 +76,6 @@ Sequence<PropertyValue> GraphicExportDialog::getPropertyValues() throw ( Runtime } void GraphicExportDialog::setPropertyValues( const Sequence<PropertyValue>& aProps ) - throw ( UnknownPropertyException, PropertyVetoException, IllegalArgumentException, - WrappedTargetException, RuntimeException, std::exception ) { maMediaDescriptor = aProps; @@ -97,12 +95,11 @@ void GraphicExportDialog::setPropertyValues( const Sequence<PropertyValue>& aPro // XExecutableDialog void GraphicExportDialog::setTitle( const OUString& aTitle ) - throw ( uno::RuntimeException, std::exception ) { maDialogTitle = aTitle; } -sal_Int16 GraphicExportDialog::execute() throw ( RuntimeException, std::exception ) +sal_Int16 GraphicExportDialog::execute() { sal_Int16 nReturn = ui::dialogs::ExecutableDialogResults::CANCEL; ScopedVclPtrInstance< GraphicExportOptionsDialog > graphicExportOptionsDialog( Application::GetDefDialogParent(), mxSourceDocument ); @@ -116,7 +113,6 @@ sal_Int16 GraphicExportDialog::execute() throw ( RuntimeException, std::exceptio // XEmporter void GraphicExportDialog::setSourceDocument( const Reference<XComponent>& xDocument ) - throw ( IllegalArgumentException, RuntimeException, std::exception ) { mxSourceDocument = xDocument; diff --git a/filter/source/graphic/GraphicExportDialog.hxx b/filter/source/graphic/GraphicExportDialog.hxx index d6aead53f278..54e7117c8cce 100644 --- a/filter/source/graphic/GraphicExportDialog.hxx +++ b/filter/source/graphic/GraphicExportDialog.hxx @@ -56,21 +56,18 @@ public: virtual ~GraphicExportDialog() override; // XInitialization - virtual void SAL_CALL initialize( const Sequence<Any>& aArguments ) throw (Exception, RuntimeException, std::exception ) override; + virtual void SAL_CALL initialize( const Sequence<Any>& aArguments ) override; // XPropertyAccess - virtual Sequence<PropertyValue> SAL_CALL getPropertyValues() throw ( RuntimeException, std::exception ) override; - virtual void SAL_CALL setPropertyValues( const Sequence<PropertyValue>& aProps ) - throw ( UnknownPropertyException, PropertyVetoException, - lang::IllegalArgumentException, lang::WrappedTargetException, - RuntimeException, std::exception ) override; + virtual Sequence<PropertyValue> SAL_CALL getPropertyValues() override; + virtual void SAL_CALL setPropertyValues( const Sequence<PropertyValue>& aProps ) override; // XExecuteDialog - virtual sal_Int16 SAL_CALL execute() throw ( RuntimeException, std::exception ) override; - virtual void SAL_CALL setTitle( const OUString& aTitle ) throw ( RuntimeException, std::exception ) override; + virtual sal_Int16 SAL_CALL execute() override; + virtual void SAL_CALL setTitle( const OUString& aTitle ) override; // XExporter - virtual void SAL_CALL setSourceDocument( const Reference<lang::XComponent>& xDocument ) throw ( lang::IllegalArgumentException, RuntimeException, std::exception ) override; + virtual void SAL_CALL setSourceDocument( const Reference<lang::XComponent>& xDocument ) override; }; diff --git a/filter/source/graphic/GraphicExportFilter.cxx b/filter/source/graphic/GraphicExportFilter.cxx index b4141f474f78..b161e0b5cd84 100644 --- a/filter/source/graphic/GraphicExportFilter.cxx +++ b/filter/source/graphic/GraphicExportFilter.cxx @@ -102,7 +102,6 @@ void GraphicExportFilter::gatherProperties( const Sequence<PropertyValue>& rProp } sal_Bool SAL_CALL GraphicExportFilter::filter( const Sequence<PropertyValue>& rDescriptor ) - throw (RuntimeException, std::exception) { gatherProperties(rDescriptor); @@ -146,18 +145,16 @@ sal_Bool SAL_CALL GraphicExportFilter::filter( const Sequence<PropertyValue>& rD return false; } -void SAL_CALL GraphicExportFilter::cancel( ) throw (RuntimeException, std::exception) +void SAL_CALL GraphicExportFilter::cancel( ) { } void SAL_CALL GraphicExportFilter::setSourceDocument( const Reference<XComponent>& xDocument ) - throw (IllegalArgumentException, RuntimeException, std::exception) { mxDocument = xDocument; } void SAL_CALL GraphicExportFilter::initialize( const Sequence<Any>& ) - throw (Exception, RuntimeException, std::exception) { } diff --git a/filter/source/graphic/GraphicExportFilter.hxx b/filter/source/graphic/GraphicExportFilter.hxx index d998befe99ef..7c7d95c4431b 100644 --- a/filter/source/graphic/GraphicExportFilter.hxx +++ b/filter/source/graphic/GraphicExportFilter.hxx @@ -59,14 +59,14 @@ public: virtual ~GraphicExportFilter() override; // XFilter - virtual sal_Bool SAL_CALL filter( const Sequence<PropertyValue>& rDescriptor ) throw(RuntimeException, std::exception) override; - virtual void SAL_CALL cancel( ) throw (RuntimeException, std::exception) override; + virtual sal_Bool SAL_CALL filter( const Sequence<PropertyValue>& rDescriptor ) override; + virtual void SAL_CALL cancel( ) override; // XExporter - virtual void SAL_CALL setSourceDocument( const Reference< XComponent >& xDocument ) throw(IllegalArgumentException, RuntimeException, std::exception) override; + virtual void SAL_CALL setSourceDocument( const Reference< XComponent >& xDocument ) override; // XInitialization - virtual void SAL_CALL initialize( const Sequence<Any>& aArguments ) throw(Exception, RuntimeException, std::exception) override; + virtual void SAL_CALL initialize( const Sequence<Any>& aArguments ) override; }; #endif |