diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-06 20:01:50 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-11 11:58:37 +0100 |
| commit | 93c64a61f2c84e684050294a1391cd32425b7837 (patch) | |
| tree | 00aad2cb8f3ee29ba4ac99e159e26fb8d71d2f33 /filter/source/graphicfilter | |
| parent | 1fde62018c8d3344a3408c7b6317120aefc778fb (diff) | |
loplugin:stringview
Add new methods "subView" to O(U)String to return substring views
of the underlying data.
Add a clang plugin to warn when replacing existing calls to copy()
would be better to use subView().
Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'filter/source/graphicfilter')
| -rw-r--r-- | filter/source/graphicfilter/idxf/dxfreprd.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/filter/source/graphicfilter/idxf/dxfreprd.cxx b/filter/source/graphicfilter/idxf/dxfreprd.cxx index e20e407cc013..d03bf4cf702f 100644 --- a/filter/source/graphicfilter/idxf/dxfreprd.cxx +++ b/filter/source/graphicfilter/idxf/dxfreprd.cxx @@ -459,7 +459,7 @@ OUString DXFRepresentation::ToOUString(const OString& s) const { char ch = static_cast<char>(asciiNum.toUInt32()); OUString codePt(&ch, 1, mEnc); - result = result.replaceAll(result.copy(pos, 5), codePt, pos); + result = result.replaceAll(result.subView(pos, 5), codePt, pos); } pos = result.indexOf("%%", pos + 1); } @@ -473,7 +473,7 @@ OUString DXFRepresentation::ToOUString(const OString& s) const lcl_isHex(codePtNum[3])) { OUString codePt(static_cast<sal_Unicode>(codePtNum.toUInt32(16))); - result = result.replaceAll(result.copy(pos, 7), codePt, pos); + result = result.replaceAll(result.subView(pos, 7), codePt, pos); } pos = result.indexOf("\\U+", pos + 1); } |