ref-counting vcl::Window subclasses

Points of discussion
--------------------

(*) where in the Window destructor should dispose() be called?
It's a seriously large method.

(*) we're going to need similar typedefs and declarations for every
single sub-class of vcl::Window, I assume that I will need to create a
macro to make it less verbose.

TODO
----

Update clang plugin to verify that:
(a) dispose() methods always call their superclass dispose()
(b) dispose() methods don't forget to clear any references owned
by that class.

Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30

12 files changed, 2 insertions, 11 deletions

diff --git a/filter/source/flash/swfdialog.cxx b/filter/source/flash/swfdialog.cxx
index 1b5f5fa287f4..2af211dc8728 100644
--- a/filter/source/flash/swfdialog.cxx
+++ b/filter/source/flash/swfdialog.cxx
@@ -29,7 +29,6 @@
 #include <com/sun/star/frame/XController.hpp>
 #include <com/sun/star/view/XSelectionSupplier.hpp>
 
-using namespace ::rtl;
 using namespace ::vcl;
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
diff --git a/filter/source/flash/swfwriter1.cxx b/filter/source/flash/swfwriter1.cxx
index 13b38c1040df..e2c34c10f8ef 100644
--- a/filter/source/flash/swfwriter1.cxx
+++ b/filter/source/flash/swfwriter1.cxx
@@ -40,7 +40,6 @@
 
 using namespace ::swf;
 using namespace ::std;
-using namespace ::rtl;
 using namespace ::com::sun::star::i18n;
 using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::lang;
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index b2e6cec13135..20e0350a80ac 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -54,6 +54,7 @@ PDFFilterResId::PDFFilterResId( sal_uInt32 nId ) : ResId( nId, getPDFFilterResMg
 
 
 using namespace ::com::sun::star;
+using namespace ::com::sun::star::uno;
 
 
 // tabbed PDF dialog implementation
diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx
index 244d4b904552..42f5c2ac3ec1 100644
--- a/filter/source/pdf/impdialog.hxx
+++ b/filter/source/pdf/impdialog.hxx
@@ -167,7 +167,7 @@ public:
 
     ImpPDFTabDialog( vcl::Window* pParent,
                      Sequence< PropertyValue >& rFilterData,
-                     const Reference< XComponent >& rDoc
+                     const css::uno::Reference< XComponent >& rDoc
                      );
     virtual ~ImpPDFTabDialog();
 
diff --git a/filter/source/pdf/pdfdialog.cxx b/filter/source/pdf/pdfdialog.cxx
index 02d6a8e374e2..9db0eb60f8a7 100644
--- a/filter/source/pdf/pdfdialog.cxx
+++ b/filter/source/pdf/pdfdialog.cxx
@@ -25,7 +25,6 @@
 #include <svl/solar.hrc>
 #include <com/sun/star/view/XRenderable.hpp>
 
-using namespace ::rtl;
 using namespace ::vcl;
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index 749dbb8cc1bf..9fdc626d6320 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -76,7 +76,6 @@
 #include "com/sun/star/graphic/XGraphicProvider.hpp"
 #include <boost/scoped_ptr.hpp>
 
-using namespace ::rtl;
 using namespace ::vcl;
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
diff --git a/filter/source/pdf/pdffilter.hxx b/filter/source/pdf/pdffilter.hxx
index 584405aab73d..c4b28faedc82 100644
--- a/filter/source/pdf/pdffilter.hxx
+++ b/filter/source/pdf/pdffilter.hxx
@@ -44,7 +44,6 @@
 #include <unotools/ucbstreamhelper.hxx>
 #include <unotools/streamwrap.hxx>
 
-using namespace ::rtl;
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::lang;
diff --git a/filter/source/pdf/pdfinteract.hxx b/filter/source/pdf/pdfinteract.hxx
index cbe46a106dfc..fc4d852a656d 100644
--- a/filter/source/pdf/pdfinteract.hxx
+++ b/filter/source/pdf/pdfinteract.hxx
@@ -25,7 +25,6 @@
 #include "com/sun/star/lang/XMultiServiceFactory.hpp"
 #include "com/sun/star/task/XInteractionHandler2.hpp"
 
-using namespace ::rtl;
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::lang;
diff --git a/filter/source/svg/svgdialog.cxx b/filter/source/svg/svgdialog.cxx
index ee307a3c27ff..3243eb5f8670 100644
--- a/filter/source/svg/svgdialog.cxx
+++ b/filter/source/svg/svgdialog.cxx
@@ -32,7 +32,6 @@
 #define SVG_DIALOG_IMPLEMENTATION_NAME  SVG_DIALOG_SERVICE_NAME
 #define SVG_FILTER_DATA_NAME            "FilterData"
 
-using namespace ::rtl;
 using namespace ::vcl;
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
diff --git a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
index 6e55c266787d..7c62fd803efe 100644
--- a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
+++ b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
@@ -44,7 +44,6 @@
 
 #include "xmlfiltersettingsdialog.hxx"
 
-using namespace ::rtl;
 using namespace ::cppu;
 using namespace ::osl;
 using namespace ::com::sun::star::uno;
diff --git a/filter/source/xsltfilter/LibXSLTTransformer.hxx b/filter/source/xsltfilter/LibXSLTTransformer.hxx
index cfdead8b11f2..cc078b9eb5c4 100644
--- a/filter/source/xsltfilter/LibXSLTTransformer.hxx
+++ b/filter/source/xsltfilter/LibXSLTTransformer.hxx
@@ -37,7 +37,6 @@
 #include <com/sun/star/beans/NamedValue.hpp>
 #include <com/sun/star/xml/xslt/XXSLTTransformer.hpp>
 
-using namespace ::rtl;
 using namespace ::cppu;
 using namespace ::osl;
 using namespace ::com::sun::star::beans;
diff --git a/filter/source/xsltfilter/OleHandler.hxx b/filter/source/xsltfilter/OleHandler.hxx
index 799226fb9d11..d1d9ad8acea8 100644
--- a/filter/source/xsltfilter/OleHandler.hxx
+++ b/filter/source/xsltfilter/OleHandler.hxx
@@ -41,7 +41,6 @@ using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::lang;
 using namespace ::com::sun::star::container;
 using namespace ::com::sun::star::io;
-using namespace ::rtl;
 
 namespace XSLT
 {