diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-19 13:23:27 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-20 07:41:29 +0100 |
commit | e725836ec19858be83bf6f7f251dd52dbcdf31d6 (patch) | |
tree | ec8aafe6e546a35dff6c3349e9644a6d6b94eea9 /filter | |
parent | 73139fe600fc1399ae828077981a2498cb0a0b0c (diff) |
loplugin:unused-returns in filter,tools,xmloff
Change-Id: I7a57be7e241883adac4417baa699a97d6304a631
Reviewed-on: https://gerrit.libreoffice.org/48188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'filter')
-rw-r--r-- | filter/source/flash/swffilter.cxx | 20 | ||||
-rw-r--r-- | filter/source/storagefilterdetect/filterdetect.hxx | 2 | ||||
-rw-r--r-- | filter/source/textfilterdetect/filterdetect.hxx | 2 |
3 files changed, 9 insertions, 15 deletions
diff --git a/filter/source/flash/swffilter.cxx b/filter/source/flash/swffilter.cxx index 029c84930937..8812065fd744 100644 --- a/filter/source/flash/swffilter.cxx +++ b/filter/source/flash/swffilter.cxx @@ -156,8 +156,8 @@ public: // XFilter virtual sal_Bool SAL_CALL filter( const Sequence< PropertyValue >& aDescriptor ) override; - bool ExportAsMultipleFiles( const Sequence< PropertyValue >& aDescriptor ); - bool ExportAsSingleFile( const Sequence< PropertyValue >& aDescriptor ); + void ExportAsMultipleFiles( const Sequence< PropertyValue >& aDescriptor ); + void ExportAsSingleFile( const Sequence< PropertyValue >& aDescriptor ); virtual void SAL_CALL cancel( ) override; @@ -302,21 +302,21 @@ sal_Bool SAL_CALL FlashExportFilter::filter( const css::uno::Sequence< css::bean // AS: HACK! Right now, I create a directory as a sibling to the swf file selected in the Export // dialog. This directory is called presentation.sxi-swf-files. The name of the swf file selected // in the Export dialog has no impact on this. All files created are placed in this directory. -bool FlashExportFilter::ExportAsMultipleFiles(const Sequence< PropertyValue >& aDescriptor) +void FlashExportFilter::ExportAsMultipleFiles(const Sequence< PropertyValue >& aDescriptor) { Reference< XDrawPagesSupplier > xDrawPagesSupplier(mxDoc, UNO_QUERY); if(!xDrawPagesSupplier.is()) - return false; + return; Reference< XIndexAccess > xDrawPages( xDrawPagesSupplier->getDrawPages(), UNO_QUERY ); if(!xDrawPages.is()) - return false; + return; Reference< XDesktop2 > rDesktop = Desktop::create( mxContext ); Reference< XStorable > xStorable(rDesktop->getCurrentComponent(), UNO_QUERY); if (!xStorable.is()) - return false; + return; Reference< XDrawPage > xDrawPage; @@ -438,11 +438,9 @@ bool FlashExportFilter::ExportAsMultipleFiles(const Sequence< PropertyValue >& a if (bExportAll) osl_closeFile(aBackgroundConfig); - - return true; } -bool FlashExportFilter::ExportAsSingleFile(const Sequence< PropertyValue >& aDescriptor) +void FlashExportFilter::ExportAsSingleFile(const Sequence< PropertyValue >& aDescriptor) { Reference < XOutputStream > xOutputStream = findPropertyValue<Reference<XOutputStream> >(aDescriptor, "OutputStream", nullptr); Sequence< PropertyValue > aFilterData; @@ -450,7 +448,7 @@ bool FlashExportFilter::ExportAsSingleFile(const Sequence< PropertyValue >& aDes if (!xOutputStream.is() ) { OSL_ASSERT ( false ); - return false; + return; } FlashExporter aFlashExporter( @@ -460,7 +458,7 @@ bool FlashExportFilter::ExportAsSingleFile(const Sequence< PropertyValue >& aDes findPropertyValue<sal_Int32>(aFilterData, "CompressMode", 75), findPropertyValue<bool>(aFilterData, "ExportOLEAsJPEG", false)); - return aFlashExporter.exportAll( mxDoc, xOutputStream, mxStatusIndicator ); + aFlashExporter.exportAll( mxDoc, xOutputStream, mxStatusIndicator ); } diff --git a/filter/source/storagefilterdetect/filterdetect.hxx b/filter/source/storagefilterdetect/filterdetect.hxx index b2959851964f..8c13868ff817 100644 --- a/filter/source/storagefilterdetect/filterdetect.hxx +++ b/filter/source/storagefilterdetect/filterdetect.hxx @@ -55,8 +55,6 @@ public: OUString StorageFilterDetect_getImplementationName(); -bool StorageFilterDetect_supportsService(const OUString& ServiceName); - css::uno::Sequence<OUString> StorageFilterDetect_getSupportedServiceNames(); css::uno::Reference<css::uno::XInterface> diff --git a/filter/source/textfilterdetect/filterdetect.hxx b/filter/source/textfilterdetect/filterdetect.hxx index 6ae26db71043..173a0bf81cc9 100644 --- a/filter/source/textfilterdetect/filterdetect.hxx +++ b/filter/source/textfilterdetect/filterdetect.hxx @@ -56,8 +56,6 @@ public: OUString PlainTextFilterDetect_getImplementationName(); -bool PlainTextFilterDetect_supportsService(const OUString& ServiceName); - css::uno::Sequence<OUString> PlainTextFilterDetect_getSupportedServiceNames(); #endif |