diff options
| author | Jochen Nitschke <j.nitschke+logerrit@ok.de> | 2017-06-28 10:23:09 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-28 14:20:44 +0200 |
| commit | 594331cc811fb9a684b5f1c871b679444b8cd51d (patch) | |
| tree | 56a26754e766bf6a8b0dc67bbe9e3597d9b8fd2f /filter | |
| parent | 8a6ed98b00cb91dbe5b807051715858a2dc90883 (diff) | |
remove default-able copy ctors and copy operators
The implicit defined ctors and operators will copy all members
(and bases).
Since C++11 implicit copy is depreciated if there is a non-default
dtor, keep such copies.
This commit includes only types that had either copy ctor or
copy operator and were found by cppcheck.
Change-Id: I93ee687fb3b3c5884f475a2c6054955cdde57ed7
Reviewed-on: https://gerrit.libreoffice.org/39351
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'filter')
| -rw-r--r-- | filter/source/graphicfilter/idxf/dxfvec.hxx | 17 | ||||
| -rw-r--r-- | filter/source/xsltdialog/xmlfiltercommon.hxx | 1 | ||||
| -rw-r--r-- | filter/source/xsltdialog/xmlfiltersettingsdialog.cxx | 22 |
3 files changed, 0 insertions, 40 deletions
diff --git a/filter/source/graphicfilter/idxf/dxfvec.hxx b/filter/source/graphicfilter/idxf/dxfvec.hxx index 03e88e166e6d..6dd5f3de5eaf 100644 --- a/filter/source/graphicfilter/idxf/dxfvec.hxx +++ b/filter/source/graphicfilter/idxf/dxfvec.hxx @@ -43,16 +43,6 @@ public: nDotCount(0), fDotLen(0), fDistance(0) {} - - DXFLineInfo(const DXFLineInfo& x) : - eStyle(x.eStyle), - fWidth(x.fWidth), - nDashCount(x.nDashCount), - fDashLen(x.fDashLen), - nDotCount(x.nDotCount), - fDotLen(x.fDotLen), - fDistance(x.fDistance) {} - }; @@ -67,7 +57,6 @@ public: double fx,fy,fz; // public ! - why not? inline DXFVector(double fX=0.0, double fY=0.0, double fZ=0.0); - inline DXFVector(const DXFVector & rV); // summation/subtraktion: DXFVector & operator += (const DXFVector & rV); @@ -171,12 +160,6 @@ inline DXFVector::DXFVector(double fX, double fY, double fZ) } -inline DXFVector::DXFVector(const DXFVector & rV) -{ - fx=rV.fx; fy=rV.fy; fz=rV.fz; -} - - inline DXFVector & DXFVector::operator += (const DXFVector & rV) { fx+=rV.fx; fy+=rV.fy; fz+=rV.fz; diff --git a/filter/source/xsltdialog/xmlfiltercommon.hxx b/filter/source/xsltdialog/xmlfiltercommon.hxx index f29111a4912c..0f0a26c66418 100644 --- a/filter/source/xsltdialog/xmlfiltercommon.hxx +++ b/filter/source/xsltdialog/xmlfiltercommon.hxx @@ -62,7 +62,6 @@ public: bool mbNeedsXSLT2; filter_info_impl(); - filter_info_impl( const filter_info_impl& rInfo ); bool operator==( const filter_info_impl& ) const; css::uno::Sequence< OUString > getFilterUserData() const; diff --git a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx index 06c80142a184..09850c095b04 100644 --- a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx +++ b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx @@ -1538,28 +1538,6 @@ filter_info_impl::filter_info_impl() { } -filter_info_impl::filter_info_impl( const filter_info_impl& rInfo ) : - maFilterName( rInfo.maFilterName ), - maType( rInfo.maType ), - maDocumentService( rInfo.maDocumentService ), - maFilterService( rInfo.maFilterService ), - maInterfaceName( rInfo.maInterfaceName ), - maComment( rInfo.maComment ), - maExtension( rInfo.maExtension ), - maExportXSLT( rInfo.maExportXSLT ), - maImportXSLT( rInfo.maImportXSLT ), - maImportTemplate( rInfo.maImportTemplate ), - maDocType( rInfo.maDocType ), - maImportService( rInfo.maImportService ), - maExportService( rInfo.maExportService ), - maFlags( rInfo.maFlags ), - maFileFormatVersion( rInfo.maFileFormatVersion ), - mnDocumentIconID( rInfo.mnDocumentIconID ), - mbReadonly( rInfo.mbReadonly ), - mbNeedsXSLT2( rInfo.mbNeedsXSLT2 ) -{ -} - bool filter_info_impl::operator==( const filter_info_impl& r ) const { return maFilterName == r.maFilterName && |