summaryrefslogtreecommitdiff
path: root/filter
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-11-02 09:42:24 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-11-02 12:38:30 +0100
commit12c7643c5129e3db9200f2564793188ddb5a3917 (patch)
treef0534b2c5ecd776ec2f25e4f15857938837cd6d8 /filter
parente335dab103f1f917c527664f8c7ff9babe5e83cb (diff)
loplugin:finalclasses in filter,extensions
Change-Id: I2822b8c5a91feaf47466356c01728d32a85bbae9 Reviewed-on: https://gerrit.libreoffice.org/44190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'filter')
-rw-r--r--filter/source/config/cache/configflush.hxx7
-rw-r--r--filter/source/graphicfilter/icgm/chart.hxx3
-rw-r--r--filter/source/pdf/impdialog.hxx6
-rw-r--r--filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx5
-rw-r--r--filter/source/xmlfilterdetect/filterdetect.hxx3
5 files changed, 6 insertions, 18 deletions
diff --git a/filter/source/config/cache/configflush.hxx b/filter/source/config/cache/configflush.hxx
index f2cd8bd9ee3e..5d0d8de84195 100644
--- a/filter/source/config/cache/configflush.hxx
+++ b/filter/source/config/cache/configflush.hxx
@@ -37,17 +37,12 @@ namespace filter{
@descr Such refresh listener will be called in case the
type/filter configuration will be changed at runtime.
*/
-class ConfigFlush : public BaseLock
+class ConfigFlush final : public BaseLock
, public ::cppu::WeakImplHelper<
css::util::XRefreshable,
css::lang::XServiceInfo
>
{
-
- // member
-
- protected:
-
/** @short holds all listener, which are registered at this instance. */
::cppu::OMultiTypeInterfaceContainerHelper m_lListener;
diff --git a/filter/source/graphicfilter/icgm/chart.hxx b/filter/source/graphicfilter/icgm/chart.hxx
index f22e526de86a..445d558978d3 100644
--- a/filter/source/graphicfilter/icgm/chart.hxx
+++ b/filter/source/graphicfilter/icgm/chart.hxx
@@ -58,12 +58,11 @@ struct DataNode
class CGM;
class CGMImpressOutAct;
-class CGMChart
+class CGMChart final
{
friend class CGM;
friend class CGMImpressOutAct;
- protected:
sal_Int8 mnCurrentFileType;
::std::vector< TextEntry* > maTextEntryList;
DataNode mDataNode[ 7 ];
diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx
index 526fa0cdf96f..e6d332cbaa3e 100644
--- a/filter/source/pdf/impdialog.hxx
+++ b/filter/source/pdf/impdialog.hxx
@@ -64,9 +64,8 @@ class ImpPDFTabLinksPage;
/// Class tabbed dialog
-class ImpPDFTabDialog : public SfxTabDialog
+class ImpPDFTabDialog final : public SfxTabDialog
{
-private:
FilterConfigItem maConfigItem;
FilterConfigItem maConfigI18N;
@@ -81,7 +80,6 @@ private:
sal_uInt16 mnViewPageId;
sal_uInt16 mnGeneralPageId;
-protected:
// the following data are the configuration used throughout the dialog and pages
bool mbIsPresentation;
bool mbIsSpreadsheet;
@@ -176,7 +174,7 @@ public:
ImpPDFTabLinksPage* getLinksPage() const;
ImpPDFTabGeneralPage* getGeneralPage() const;
-protected:
+private:
virtual void PageCreated( sal_uInt16 _nId, SfxTabPage& _rPage ) override;
virtual short Ok() override;
};
diff --git a/filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx b/filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx
index 5bab49ee71e8..b33af42f9c16 100644
--- a/filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx
+++ b/filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx
@@ -41,7 +41,7 @@ enum FilterType
* setSourceDocument or setTargetDocument determines which Impl function the filter
* member calls */
-class XmlFilterAdaptor : public cppu::WeakImplHelper
+class XmlFilterAdaptor final : public cppu::WeakImplHelper
<
css::document::XFilter,
css::document::XExporter,
@@ -50,9 +50,6 @@ class XmlFilterAdaptor : public cppu::WeakImplHelper
css::lang::XServiceInfo
>
{
-
-protected:
-
css::uno::Reference< css::uno::XComponentContext > mxContext;
css::uno::Reference< css::lang::XComponent > mxDoc;
OUString msFilterName;
diff --git a/filter/source/xmlfilterdetect/filterdetect.hxx b/filter/source/xmlfilterdetect/filterdetect.hxx
index 886fb1c64f72..5db916d76e5e 100644
--- a/filter/source/xmlfilterdetect/filterdetect.hxx
+++ b/filter/source/xmlfilterdetect/filterdetect.hxx
@@ -29,14 +29,13 @@ namespace com { namespace sun { namespace star { namespace uno {
class XComponentContext;
} } } }
-class FilterDetect : public cppu::WeakImplHelper <
+class FilterDetect final : public cppu::WeakImplHelper <
css::document::XExtendedFilterDetection,
css::lang::XInitialization,
css::lang::XServiceInfo
>
{
-protected:
css::uno::Reference< css::uno::XComponentContext > mxCtx;
public: