loplugin:referencecasting in forms..fpicker

Change-Id: I0aa040b6d3264d2efde5797f79994d3d65ceaddf
Reviewed-on: https://gerrit.libreoffice.org/75957
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 10 insertions, 14 deletions

diff --git a/forms/source/xforms/binding.cxx b/forms/source/xforms/binding.cxx
index b36d2bf074df..d2c1be56aa7b 100644
--- a/forms/source/xforms/binding.cxx
+++ b/forms/source/xforms/binding.cxx
@@ -543,10 +543,8 @@ void Binding::bind( bool bForceRebind )
                           aContext.mxNamespaces ) )
         {
             aContext.mxContextNode->appendChild(
-                Reference<XNode>(
                     aContext.mxContextNode->getOwnerDocument()->createElement(
-                        maBindingExpression.getExpression() ),
-                    UNO_QUERY ) );
+                        maBindingExpression.getExpression() ) );
             maBindingExpression.evaluate( aContext );
             OSL_ENSURE( maBindingExpression.getNode().is(),
                         "we should bind to the newly inserted node!" );
@@ -751,8 +749,8 @@ css::uno::Reference<css::xsd::XDataType> Binding::getDataType()
     OSL_ENSURE( getModel().is(), "need model" );
     OSL_ENSURE( getModel()->getDataTypeRepository().is(), "need types" );
 
-    Reference<XDataTypeRepository> xRepository(
-        getModel()->getDataTypeRepository(), UNO_QUERY );
+    Reference<XDataTypeRepository> xRepository =
+        getModel()->getDataTypeRepository();
     OUString sTypeName = maMIP.getTypeName();
 
     return ( xRepository.is() && xRepository->hasByName( sTypeName ) )
diff --git a/forms/source/xforms/model.cxx b/forms/source/xforms/model.cxx
index 2bddfea5db30..0b5b4cbd245f 100644
--- a/forms/source/xforms/model.cxx
+++ b/forms/source/xforms/model.cxx
@@ -113,7 +113,7 @@ EvaluationContext Model::getEvaluationContext()
     // the default context is the top-level element node. A default
     // node (instanceData' is inserted when there is no default node
     Reference<XDocument> xInstance = getDefaultInstance();
-    Reference<XNode> xElement( xInstance->getDocumentElement(), UNO_QUERY );
+    Reference<XNode> xElement = xInstance->getDocumentElement();
 
     // no element found? Then insert default element 'instanceData'
     if( ! xElement.is() )
diff --git a/forms/source/xforms/model_ui.cxx b/forms/source/xforms/model_ui.cxx
index e37dfa3d490b..b2ffffa2ec0c 100644
--- a/forms/source/xforms/model_ui.cxx
+++ b/forms/source/xforms/model_ui.cxx
@@ -550,8 +550,7 @@ css::uno::Reference<css::xml::dom::XNode> Model::createElement( const css::uno::
         && isValidXMLName( sName ) )
     {
         // TODO: implement proper namespace handling
-        xNode.set( xParent->getOwnerDocument()->createElement( sName ),
-                   UNO_QUERY );
+        xNode = xParent->getOwnerDocument()->createElement( sName );
     }
     return xNode;
 }
@@ -575,8 +574,7 @@ css::uno::Reference<css::xml::dom::XNode> Model::createAttribute( const css::uno
         }
 
         // TODO: implement proper namespace handling
-        xNode.set( xParent->getOwnerDocument()->createAttribute( sUniqueName ),
-                   UNO_QUERY );
+        xNode = xParent->getOwnerDocument()->createAttribute( sUniqueName );
     }
     return xNode;
 }
@@ -603,7 +601,7 @@ css::uno::Reference<css::xml::dom::XNode> Model::renameNode( const css::uno::Ref
     if( xNode->getNodeType() == NodeType_ELEMENT_NODE )
     {
         Reference<XElement> xElem = xDoc->createElement( sName );
-        xNew.set( xElem, UNO_QUERY );
+        xNew = xElem;
 
         // iterate over all attributes and append them to the new element
         Reference<XElement> xOldElem( xNode, UNO_QUERY );
diff --git a/forms/source/xforms/submission.cxx b/forms/source/xforms/submission.cxx
index c4d786877674..f20b72f11973 100644
--- a/forms/source/xforms/submission.cxx
+++ b/forms/source/xforms/submission.cxx
@@ -558,7 +558,7 @@ Reference< XDocumentFragment > Submission::createSubmissionDocument(const Refere
         {
             aListItem = aList->item(i);
             if (aListItem->getNodeType()==NodeType_DOCUMENT_NODE)
-                aListItem.set( (Reference< XDocument >(aListItem, UNO_QUERY))->getDocumentElement(), UNO_QUERY);
+                aListItem = (Reference< XDocument >(aListItem, UNO_QUERY))->getDocumentElement();
             // copy relevant nodes from instance into fragment
             cloneNodes(*getModelImpl(), aFragment, aListItem, bRemoveWSNodes);
         }
diff --git a/forms/source/xforms/submission/serialization_app_xml.cxx b/forms/source/xforms/submission/serialization_app_xml.cxx
index c8ad9ef642e3..afe23e63c426 100644
--- a/forms/source/xforms/submission/serialization_app_xml.cxx
+++ b/forms/source/xforms/submission/serialization_app_xml.cxx
@@ -67,7 +67,7 @@ CSerializationAppXML::getInputStream()
 {
     // The pipes output is provided through it's
     // XOutputStream interface aspect
-    return Reference< css::io::XInputStream >(m_xBuffer, UNO_QUERY);
+    return m_xBuffer;
 }
 
 void
diff --git a/forms/source/xforms/submission/serialization_urlencoded.cxx b/forms/source/xforms/submission/serialization_urlencoded.cxx
index 43dafdc714c6..51d29ceed0c9 100644
--- a/forms/source/xforms/submission/serialization_urlencoded.cxx
+++ b/forms/source/xforms/submission/serialization_urlencoded.cxx
@@ -173,7 +173,7 @@ void CSerializationURLEncoded::serialize()
 
 Reference< XInputStream > CSerializationURLEncoded::getInputStream()
 {
-    return Reference< XInputStream >(m_aPipe, UNO_QUERY);
+    return m_aPipe;
 }