diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-10-12 16:00:24 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-10-12 16:05:32 +0200 |
| commit | 802f2a420859f6787c86a960aa331245423d5820 (patch) | |
| tree | 7bb46760ca0371c958a4a36c966d253f2c59383c /forms/source/xforms | |
| parent | e510e9893d5ce99c8dfa9478d6972469fcc339d2 (diff) | |
Don't allow O[U]StringBuffer in string concatenation
...as
OStringBuffer b("foo"); b = "bar" + b;
doesn't work as one might expect (see the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html>
"concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And
of the affected places, MethodDescriptor::getSignature
(codemaker/source/javamaker/javatype.cxx) was the only one that would actually
have benefitted.
Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
Diffstat (limited to 'forms/source/xforms')
| -rw-r--r-- | forms/source/xforms/model_ui.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/forms/source/xforms/model_ui.cxx b/forms/source/xforms/model_ui.cxx index 482fe7ade8a1..f8f5784c06bd 100644 --- a/forms/source/xforms/model_ui.cxx +++ b/forms/source/xforms/model_ui.cxx @@ -293,7 +293,7 @@ OUString Model::getNodeDisplayName( const XNode_t& xNode, OUString sContent = xNode->getNodeValue(); if( bDetail || ! lcl_isWhitespace( sContent ) ) { - aBuffer = aBuffer + "\"" + Convert::collapseWhitespace( sContent ) + "\""; + aBuffer.append("\"" + Convert::collapseWhitespace( sContent ) + "\""); } } break; @@ -866,7 +866,7 @@ static OUString lcl_serializeForDisplay( const Reference<XXPathObject>& xResult break; case XPathObjectType_XPATH_STRING: - aBuffer = aBuffer + "\"" + xResult->getString() + "\""; + aBuffer.append("\"" + xResult->getString() + "\""); break; case XPathObjectType_XPATH_NODESET: |