clang-tidy performance-unnecessary-value-param in various

Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

7 files changed, 13 insertions, 13 deletions

diff --git a/forms/source/component/GroupManager.cxx b/forms/source/component/GroupManager.cxx
index 46cc2ca84100..4bde4ddf7085 100644
--- a/forms/source/component/GroupManager.cxx
+++ b/forms/source/component/GroupManager.cxx
@@ -420,7 +420,7 @@ void OGroupManager::RemoveElement( const Reference<XPropertySet>& xSet )
     removeFromGroupMap(sGroupName,xSet);
 }
 
-OUString OGroupManager::GetGroupName( css::uno::Reference< css::beans::XPropertySet> xComponent )
+OUString OGroupManager::GetGroupName( const css::uno::Reference< css::beans::XPropertySet>& xComponent )
 {
     if (!xComponent.is())
         return OUString();
diff --git a/forms/source/component/GroupManager.hxx b/forms/source/component/GroupManager.hxx
index 8567ebb1e02d..e2f3b68f4b2e 100644
--- a/forms/source/component/GroupManager.hxx
+++ b/forms/source/component/GroupManager.hxx
@@ -194,7 +194,7 @@ public:
     void getGroupByName(const OUString& Name, css::uno::Sequence< css::uno::Reference< css::awt::XControlModel> >& _rGroup);
     css::uno::Sequence< css::uno::Reference< css::awt::XControlModel> > getControlModels();
 
-    static OUString GetGroupName( css::uno::Reference< css::beans::XPropertySet> xComponent );
+    static OUString GetGroupName( const css::uno::Reference< css::beans::XPropertySet>& xComponent );
 };
 
 
diff --git a/forms/source/component/propertybaghelper.cxx b/forms/source/component/propertybaghelper.cxx
index b0774a37a929..ab73d42b575d 100644
--- a/forms/source/component/propertybaghelper.cxx
+++ b/forms/source/component/propertybaghelper.cxx
@@ -245,7 +245,7 @@ namespace frm
 
         struct PropertyValueLessByName : public ::std::binary_function< PropertyValue, PropertyValue, bool >
         {
-            bool operator()( const PropertyValue& _lhs, const PropertyValue _rhs ) const
+            bool operator()( const PropertyValue& _lhs, const PropertyValue& _rhs ) const
             {
                 return _lhs.Name < _rhs.Name;
             }
diff --git a/forms/source/richtext/richtextimplcontrol.cxx b/forms/source/richtext/richtextimplcontrol.cxx
index 6bb684994acb..708b13c935ed 100644
--- a/forms/source/richtext/richtextimplcontrol.cxx
+++ b/forms/source/richtext/richtextimplcontrol.cxx
@@ -98,7 +98,7 @@ namespace frm
     }
 
 
-    void RichTextControlImpl::implUpdateAttribute( AttributeHandlerPool::const_iterator _pHandler )
+    void RichTextControlImpl::implUpdateAttribute( const AttributeHandlerPool::const_iterator& _pHandler )
     {
         if  (  ( _pHandler->first == SID_ATTR_CHAR_WEIGHT )
             || ( _pHandler->first == SID_ATTR_CHAR_POSTURE )
diff --git a/forms/source/richtext/richtextimplcontrol.hxx b/forms/source/richtext/richtextimplcontrol.hxx
index 265427428873..761bd9b1b0fe 100644
--- a/forms/source/richtext/richtextimplcontrol.hxx
+++ b/forms/source/richtext/richtextimplcontrol.hxx
@@ -149,7 +149,7 @@ namespace frm
 
     private:
         // updates the cache with the state provided by the given attribute handler
-        void    implUpdateAttribute( AttributeHandlerPool::const_iterator _pHandler );
+        void    implUpdateAttribute( const AttributeHandlerPool::const_iterator& _pHandler );
 
         // updates the cache with the given state, and calls listeners (if necessary)
         void    implCheckUpdateCache( AttributeId _nAttribute, const AttributeState& _rState );
diff --git a/forms/source/runtime/formoperations.cxx b/forms/source/runtime/formoperations.cxx
index 4f9884f78baf..e0f936726ea6 100644
--- a/forms/source/runtime/formoperations.cxx
+++ b/forms/source/runtime/formoperations.cxx
@@ -460,7 +460,7 @@ namespace frm
             return true;
         }
 
-        bool commit1Form(Reference< XFormController > xCntrl, bool &needConfirmation, bool &shouldCommit)
+        bool commit1Form(const Reference< XFormController >& xCntrl, bool &needConfirmation, bool &shouldCommit)
         {
             Reference< XFormOperations > xFrmOps(xCntrl->getFormOperations());
             if (!xFrmOps->commitCurrentControl())
@@ -477,7 +477,7 @@ namespace frm
             return true;
         }
 
-        bool commitFormAndSubforms(Reference< XFormController > xCntrl, bool needConfirmation)
+        bool commitFormAndSubforms(const Reference< XFormController >& xCntrl, bool needConfirmation)
         {
             bool shouldCommit(true);
             assert(xCntrl.is());
@@ -504,7 +504,7 @@ namespace frm
             return true;
         }
 
-        bool commit1Form(Reference< XForm > xFrm, bool &needConfirmation, bool &shouldCommit)
+        bool commit1Form(const Reference< XForm >& xFrm, bool &needConfirmation, bool &shouldCommit)
         {
             Reference< XPropertySet > xProps(xFrm, UNO_QUERY_THROW);
             // nothing to do if the record is not modified
@@ -525,7 +525,7 @@ namespace frm
             return true;
         }
 
-        bool commitFormAndSubforms(Reference< XForm > xFrm, bool needConfirmation)
+        bool commitFormAndSubforms(const Reference< XForm >& xFrm, bool needConfirmation)
         {
             // No control...  do what we can with the models
             bool shouldCommit(true);
diff --git a/forms/source/xforms/binding.cxx b/forms/source/xforms/binding.cxx
index 9a713d483ae7..19d89662d11a 100644
--- a/forms/source/xforms/binding.cxx
+++ b/forms/source/xforms/binding.cxx
@@ -490,8 +490,8 @@ Model* Binding::getModelImpl( const css::uno::Reference<css::xforms::XModel>& xM
     return pModel;
 }
 
-static void lcl_addListenerToNode( Reference<XNode> xNode,
-                            Reference<XEventListener> xListener )
+static void lcl_addListenerToNode( const Reference<XNode>& xNode,
+                                   const Reference<XEventListener>& xListener )
 {
     Reference<XEventTarget> xTarget( xNode, UNO_QUERY );
     if( xTarget.is() )
@@ -511,8 +511,8 @@ static void lcl_addListenerToNode( Reference<XNode> xNode,
     }
 }
 
-static void lcl_removeListenerFromNode( Reference<XNode> xNode,
-                                 Reference<XEventListener> xListener )
+static void lcl_removeListenerFromNode( const Reference<XNode>& xNode,
+                                        const Reference<XEventListener>& xListener )
 {
     Reference<XEventTarget> xTarget( xNode, UNO_QUERY );
     if( xTarget.is() )