Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 3 [API CHANGE]

- Replace all uses of OImplementationId in core with UnoIdInit
- Deprecate OImplementationId in <cppuhelper/typeprovider.hxx>

OImplementationId uses broken double checked locking; additionally,
it uses it at the first call to getImplementationId, not when the
object is constructed. This implementation can't be changed, cince
it's part of published API; it can't rely on C++11, which would be
required for use of thread-safe statics and move the initialization
to ctor.

The class has obsolete _bUseEthernetAddress member, that is unused
and ignored since 4e9fa7e339a1cd6cb2fec643715991bcf5057cec. No need
to implement it when replacing its uses to UnoIdInit.

The deprecation is the API CHANGE. No published API is introduced to
replace it; 3rd-party code should seek alternative solutions, or just
keep using the deprecated functionality.

TODO (in separate commits):
- Change implementations of getSomething to use getSomethingImpl
- Revise uses of getSomething to use getFromUnoTunnel

Change-Id: I8b6e684e5389bc0d5bb3b7f21f72a4c8f684107d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122077
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

4 files changed, 8 insertions, 8 deletions

diff --git a/forms/source/richtext/richtextmodel.cxx b/forms/source/richtext/richtextmodel.cxx
index 3e2930d1bfeb..84c103ae6a2b 100644
--- a/forms/source/richtext/richtextmodel.cxx
+++ b/forms/source/richtext/richtextmodel.cxx
@@ -526,8 +526,8 @@ namespace frm
 
     Sequence<sal_Int8> ORichTextModel::getUnoTunnelId()
     {
-        static cppu::OImplementationId aId;
-        return aId.getImplementationId();
+        static const comphelper::UnoIdInit aId;
+        return aId.getSeq();
     }
 
 
diff --git a/forms/source/xforms/binding.cxx b/forms/source/xforms/binding.cxx
index 6b29e26685b7..0d8add6108d0 100644
--- a/forms/source/xforms/binding.cxx
+++ b/forms/source/xforms/binding.cxx
@@ -301,8 +301,8 @@ EvaluationContext Binding::getEvaluationContext() const
 
 css::uno::Sequence<sal_Int8> Binding::getUnoTunnelId()
 {
-    static cppu::OImplementationId aImplementationId;
-    return aImplementationId.getImplementationId();
+    static const comphelper::UnoIdInit aImplementationId;
+    return aImplementationId.getSeq();
 }
 
 
diff --git a/forms/source/xforms/model.cxx b/forms/source/xforms/model.cxx
index f3bad8a5f323..0668028f5af8 100644
--- a/forms/source/xforms/model.cxx
+++ b/forms/source/xforms/model.cxx
@@ -131,8 +131,8 @@ EvaluationContext Model::getEvaluationContext()
 
 css::uno::Sequence<sal_Int8> Model::getUnoTunnelId()
 {
-    static cppu::OImplementationId aImplementationId;
-    return aImplementationId.getImplementationId();
+    static const comphelper::UnoIdInit aImplementationId;
+    return aImplementationId.getSeq();
 }
 
 
diff --git a/forms/source/xforms/submission.cxx b/forms/source/xforms/submission.cxx
index 64d2e59524e9..909ce530bc9e 100644
--- a/forms/source/xforms/submission.cxx
+++ b/forms/source/xforms/submission.cxx
@@ -256,8 +256,8 @@ bool Submission::doSubmit( const Reference< XInteractionHandler >& xHandler )
 
 Sequence<sal_Int8> Submission::getUnoTunnelId()
 {
-    static cppu::OImplementationId aImplementationId;
-    return aImplementationId.getImplementationId();
+    static const comphelper::UnoIdInit aImplementationId;
+    return aImplementationId.getSeq();
 }