diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-10-14 14:57:54 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-10-14 21:28:40 +0200 |
| commit | 1f9468fc29874eae5100317282ab8b395904406d (patch) | |
| tree | 7da605653b3a979d18c2283f42ac8a3efd9eae63 /forms | |
| parent | 43b0d4f709a3a1446a32e36abb5deaa3bb45ddd9 (diff) | |
use std::vector::insert instead of push_back
because it will pre-allocate space and often is optimised to memcpy
Change-Id: I03ed7915f2762d3d27e378638052a47a28bbf096
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123588
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'forms')
| -rw-r--r-- | forms/source/component/ComboBox.cxx | 3 | ||||
| -rw-r--r-- | forms/source/xforms/binding.cxx | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/forms/source/component/ComboBox.cxx b/forms/source/component/ComboBox.cxx index 9b1bd9b9c7bd..fe3260070d68 100644 --- a/forms/source/component/ComboBox.cxx +++ b/forms/source/component/ComboBox.cxx @@ -632,8 +632,7 @@ void OComboBoxModel::loadData( bool _bForce ) if (xFieldNames.is()) { const Sequence<OUString> aFieldNames = xFieldNames->getElementNames(); - for (const OUString& rustrNames : aFieldNames) - aStringList.push_back(rustrNames); + aStringList.insert(aStringList.end(), aFieldNames.begin(), aFieldNames.end()); } } break; diff --git a/forms/source/xforms/binding.cxx b/forms/source/xforms/binding.cxx index 3b6983f05daf..6d8735f6366c 100644 --- a/forms/source/xforms/binding.cxx +++ b/forms/source/xforms/binding.cxx @@ -552,8 +552,7 @@ void Binding::bind( bool bForceRebind ) lcl_removeListenerFromNode( eventNode, this ); maEventNodes.clear(); if( isSimpleBinding() ) - for (auto const& node : aNodes) - maEventNodes.push_back(node); + maEventNodes.insert(maEventNodes.end(), aNodes.begin(), aNodes.end()); else maEventNodes.emplace_back( aContext.mxContextNode->getOwnerDocument(), UNO_QUERY_THROW ); |