loplugin:stringadd in editeng..framework

after my patch to merge the bufferadd loplugin into stringadd

Change-Id: Ieac16a01fde6467a2f6fe47864069304a3c44e47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 12 insertions, 18 deletions

diff --git a/forms/source/component/DatabaseForm.cxx b/forms/source/component/DatabaseForm.cxx
index d4795414a43d..fccd2367ea17 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -437,9 +437,7 @@ OUString ODatabaseForm::GetDataEncoded(bool _bURLEncoded,const Reference<XContro
         Encode( aName );
         Encode( aValue );
 
-        aResult.append(aName);
-        aResult.append('=');
-        aResult.append(aValue);
+        aResult.append(aName + "=" + aValue);
 
         if (pSuccObj < aSuccObjList.end() - 1)
         {
@@ -905,9 +903,9 @@ void ODatabaseForm::Encode( OUString& rString )
                     short nLo = static_cast<sal_Int16>(nCharCode) - (nHi*16);
                     if( nHi > 9 ) nHi += int('A')-10; else nHi += int('0');
                     if( nLo > 9 ) nLo += int('A')-10; else nLo += int('0');
-                    aResult.append('%');
-                    aResult.append(static_cast<sal_Unicode>(nHi));
-                    aResult.append(static_cast<sal_Unicode>(nLo));
+                    aResult.append("%"
+                        + OUStringChar(static_cast<sal_Unicode>(nHi))
+                        + OUStringChar(static_cast<sal_Unicode>(nLo)) );
                 }
             }
         }
diff --git a/forms/source/component/Filter.cxx b/forms/source/component/Filter.cxx
index bd9b640f1ce3..c59139d0f5d7 100644
--- a/forms/source/component/Filter.cxx
+++ b/forms/source/component/Filter.cxx
@@ -412,18 +412,16 @@ namespace frm
             const Reference< XDatabaseMetaData >  xMeta( xConnection->getMetaData(), UNO_SET_THROW );
             const OUString sQuoteChar = xMeta->getIdentifierQuoteString();
 
-            aStatement.append( "SELECT DISTINCT " );
-            aStatement.append( sQuoteChar );
-            aStatement.append( sRealFieldName );
-            aStatement.append( sQuoteChar );
+            aStatement.append(
+                "SELECT DISTINCT "
+                + sQuoteChar
+                + sRealFieldName
+                + sQuoteChar );
 
             // if the field had an alias in our form's statement, give it this alias in the new statement, too
             if ( !sFieldName.isEmpty() && ( sFieldName != sRealFieldName ) )
             {
-                aStatement.append(" AS ");
-                aStatement.append( sQuoteChar );
-                aStatement.append( sFieldName );
-                aStatement.append( sQuoteChar );
+                aStatement.append(" AS "+ sQuoteChar + sFieldName + sQuoteChar );
             }
 
             aStatement.append( " FROM " );
diff --git a/forms/source/xforms/model_ui.cxx b/forms/source/xforms/model_ui.cxx
index e8208565f4fe..5d56e8b3baa0 100644
--- a/forms/source/xforms/model_ui.cxx
+++ b/forms/source/xforms/model_ui.cxx
@@ -814,8 +814,7 @@ static OUString lcl_serializeForDisplay( const Reference<XNodeList>& xNodes )
         if( !sLine.isEmpty()
             && !sLine.startsWith( "<?xml" ) )
         {
-            sResult.append( sLine );
-            sResult.append( '\n' );
+            sResult.append( sLine + "\n" );
         }
     }
 
diff --git a/forms/source/xforms/submission/submission_get.cxx b/forms/source/xforms/submission/submission_get.cxx
index 5078daf9db29..ae630b504b0c 100644
--- a/forms/source/xforms/submission/submission_get.cxx
+++ b/forms/source/xforms/submission/submission_get.cxx
@@ -76,8 +76,7 @@ CSubmission::SubmissionResult CSubmissionGet::submit(const css::uno::Reference<
             aQueryString.append(reinterpret_cast<char const *>(aByteBuffer.getConstArray()), n);
         if (!aQueryString.isEmpty() && m_aURLObj.GetProtocol() != INetProtocol::File)
         {
-            aUTF8QueryURL.append('?');
-            aUTF8QueryURL.append(aQueryString);
+            aUTF8QueryURL.append("?" + aQueryString);
         }
         OUString aQueryURL = OStringToOUString(aUTF8QueryURL, RTL_TEXTENCODING_UTF8);
         ucbhelper::Content aContent(aQueryURL, aEnvironment, m_xContext);