diff options
| author | Tor Lillqvist <tml@collabora.com> | 2013-10-17 08:25:28 +0300 |
|---|---|---|
| committer | Tor Lillqvist <tml@collabora.com> | 2013-10-17 08:34:01 +0300 |
| commit | 2337bb6b402391983f8f96a8d0bc9e904dd124a9 (patch) | |
| tree | 5fb97527cb29363af854f9ab71b9e53fb498e8f1 /forms | |
| parent | bf6d1f77420dcc9ece4d9f4eae1e37b427d85c6a (diff) | |
WaE: unknown warning group '-Wmaybe-uninitialized'
Seriously, would it be so awful to initialise the value even if strictly
speaking it is unnecessary? Hopefully avoiding that is not an attempt at
manual micro-optmisation? (Or did the initialisation actually cause some
warning?)
Besides, Clang is not just "the MacOS X compiler". I use Clang on Linux,
too. It is great. Our Clang plug-in (which can be easily used only on Linux)
is very useful.
Change-Id: I379afed707d96745ee29979bd79467309adf0147
Diffstat (limited to 'forms')
| -rw-r--r-- | forms/source/component/CheckBox.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/forms/source/component/CheckBox.cxx b/forms/source/component/CheckBox.cxx index d1667ea8a75f..479672948661 100644 --- a/forms/source/component/CheckBox.cxx +++ b/forms/source/component/CheckBox.cxx @@ -211,7 +211,7 @@ bool OCheckBoxModel::DbUseBool() } //------------------------------------------------------------------------------ -#if defined __GNUC__ +#if defined __GNUC__ && ! defined __clang__ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wmaybe-uninitialized" #endif @@ -248,14 +248,14 @@ Any OCheckBoxModel::translateDbColumnToControlValue() // Since above either bValue is initialised, either aValue.hasValue(), // bValue cannot be used uninitialised here. // But GCC does not see/understand that, which breaks -Werror builds. - // Since the MacOS X compiler does not support #pragma GCC diagnostic + // And Clang compiler does not support #pragma GCC diagnostic // within a function, moved them to outside the function. aValue <<= (sal_Int16)( bValue ? STATE_CHECK : STATE_NOCHECK ); } return aValue; } -#if defined __GNUC__ +#if defined __GNUC__ && ! defined __clang__ #pragma GCC diagnostic pop #endif |