diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-22 12:03:24 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-23 08:59:56 +0200 |
commit | 6bbda13286c8f736f35ceb7a377ca15b3fd544b2 (patch) | |
tree | 19bb6c3c85af38bd5787ef140e62f081dc147408 /forms | |
parent | 58ae5fb5ff69a5581cffa583a57ad9381140fa9a (diff) |
loplugin:unusedfields in forms..idlc
Change-Id: If250ff47c1f375fe24c61b5bf271da9a9c330822
Reviewed-on: https://gerrit.libreoffice.org/39133
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'forms')
-rw-r--r-- | forms/source/component/Grid.cxx | 5 | ||||
-rw-r--r-- | forms/source/component/Grid.hxx | 7 | ||||
-rw-r--r-- | forms/source/component/clickableimage.cxx | 8 | ||||
-rw-r--r-- | forms/source/component/clickableimage.hxx | 1 | ||||
-rw-r--r-- | forms/source/xforms/xformsevent.cxx | 2 | ||||
-rw-r--r-- | forms/source/xforms/xformsevent.hxx | 7 |
6 files changed, 2 insertions, 28 deletions
diff --git a/forms/source/component/Grid.cxx b/forms/source/component/Grid.cxx index c8b7f55c476d..0b2bb82bf75f 100644 --- a/forms/source/component/Grid.cxx +++ b/forms/source/component/Grid.cxx @@ -749,7 +749,7 @@ void OGridControlModel::impl_replacedElement( const ContainerEvent& _rEvent, ::o ElementDescription* OGridControlModel::createElementMetaData( ) { - return new ColumnDescription; + return new ElementDescription; } void OGridControlModel::approveNewElement( const Reference< XPropertySet >& _rxObject, ElementDescription* _pElement ) @@ -758,9 +758,6 @@ void OGridControlModel::approveNewElement( const Reference< XPropertySet >& _rxO if ( !pCol ) throw IllegalArgumentException(); OInterfaceContainer::approveNewElement( _rxObject, _pElement ); - // if we're here, the object passed all tests - if ( _pElement ) - static_cast< ColumnDescription* >( _pElement )->pColumn = pCol; } // XPersistObject diff --git a/forms/source/component/Grid.hxx b/forms/source/component/Grid.hxx index 63811a77812e..716aab920ab2 100644 --- a/forms/source/component/Grid.hxx +++ b/forms/source/component/Grid.hxx @@ -40,13 +40,6 @@ namespace frm class OGridColumn; - struct ColumnDescription : public ElementDescription - { - public: - OGridColumn* pColumn; // not owned by this instance! only to prevent duplicate XUnoTunnel usage - }; - - // OGridControlModel typedef ::cppu::ImplHelper7 < css::awt::XControlModel diff --git a/forms/source/component/clickableimage.cxx b/forms/source/component/clickableimage.cxx index 3590d2e3c747..fb8d5b783808 100644 --- a/forms/source/component/clickableimage.cxx +++ b/forms/source/component/clickableimage.cxx @@ -450,7 +450,6 @@ namespace frm ,m_xGraphicObject() ,m_pMedium(nullptr) ,m_bDispatchUrlInternal(false) - ,m_bDownloading(false) ,m_bProdStarted(false) { implConstruct(); @@ -464,7 +463,6 @@ namespace frm ,m_xGraphicObject( _pOriginal->m_xGraphicObject ) ,m_pMedium( nullptr ) ,m_bDispatchUrlInternal(false) - ,m_bDownloading( false ) ,m_bProdStarted( false ) { implConstruct(); @@ -676,7 +674,6 @@ namespace frm else // caution: the medium may be NULL if somebody gave us an invalid URL to work with pImgProd->SetImage(OUString()); - m_bDownloading = false; return; } if (m_pMedium->GetErrorCode()==ERRCODE_NONE) @@ -692,7 +689,6 @@ namespace frm pImgProd->SetImage(OUString()); delete m_pMedium; m_pMedium = nullptr; - m_bDownloading = false; } } @@ -781,9 +777,6 @@ namespace frm } #endif - // Set downloading flag to true. They will be Data Available Links, - // if get to the pending staus. - m_bDownloading = true; m_bProdStarted = false; // Kick off download (caution: can be synchronous). @@ -810,7 +803,6 @@ namespace frm void OClickableImageBaseModel::DownloadDone() { DataAvailable(); - m_bDownloading = false; } diff --git a/forms/source/component/clickableimage.hxx b/forms/source/component/clickableimage.hxx index bb1ac3dfa553..665f2d6ecbeb 100644 --- a/forms/source/component/clickableimage.hxx +++ b/forms/source/component/clickableimage.hxx @@ -69,7 +69,6 @@ namespace frm SfxMedium* m_pMedium; // Download medium rtl::Reference<ImageProducer> m_xProducer; bool m_bDispatchUrlInternal; // property: is not allowed to set : 1 - bool m_bDownloading : 1; // Is a download in progress? bool m_bProdStarted : 1; // XSubmission stuff diff --git a/forms/source/xforms/xformsevent.cxx b/forms/source/xforms/xformsevent.cxx index c11664308295..d65b5b0e73ca 100644 --- a/forms/source/xforms/xformsevent.cxx +++ b/forms/source/xforms/xformsevent.cxx @@ -70,8 +70,6 @@ css::util::Time SAL_CALL XFormsEventConcrete::getTimeStamp() void SAL_CALL XFormsEventConcrete::stopPropagation() { - if(m_cancelable) - m_canceled = true; } void SAL_CALL XFormsEventConcrete::preventDefault() { diff --git a/forms/source/xforms/xformsevent.hxx b/forms/source/xforms/xformsevent.hxx index 3bdfb857cbe3..db163295dc88 100644 --- a/forms/source/xforms/xformsevent.hxx +++ b/forms/source/xforms/xformsevent.hxx @@ -35,8 +35,7 @@ class XFormsEventConcrete : public cppu::WeakImplHelper< XFormsEvent > { public: XFormsEventConcrete() - : m_canceled(false) - , m_bubbles(false) + : m_bubbles(false) , m_cancelable(false) { } @@ -61,10 +60,6 @@ class XFormsEventConcrete : public cppu::WeakImplHelper< XFormsEvent > { sal_Bool canBubbleArg, sal_Bool cancelableArg) override; - private: - - bool m_canceled; - protected: OUString m_eventType; |