update unusedmethods plugin to deal with constructors

and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

5 files changed, 2 insertions, 24 deletions

diff --git a/forms/source/component/DatabaseForm.hxx b/forms/source/component/DatabaseForm.hxx
index 415fb24fb8d9..1138c2a1ee50 100644
--- a/forms/source/component/DatabaseForm.hxx
+++ b/forms/source/component/DatabaseForm.hxx
@@ -107,10 +107,6 @@ public:
         ,nRepresentation( _nRepresent )
     {
     }
-
-    HtmlSuccessfulObj()
-    {
-    }
 };
 
 typedef std::vector<HtmlSuccessfulObj> HtmlSuccessfulObjList;
diff --git a/forms/source/component/FormComponent.cxx b/forms/source/component/FormComponent.cxx
index 27ddd31e27e3..7d66f4213390 100644
--- a/forms/source/component/FormComponent.cxx
+++ b/forms/source/component/FormComponent.cxx
@@ -1104,18 +1104,6 @@ oslInterlockedCount OControlModel::unlockInstance( LockAccess )
     return lockCount;
 }
 
-void OControlModel::firePropertyChanges( const Sequence< sal_Int32 >& _rHandles, const Sequence< Any >& _rOldValues,
-                                        const Sequence< Any >& _rNewValues, LockAccess )
-{
-    OPropertySetHelper::fire(
-        const_cast< Sequence< sal_Int32 >& >( _rHandles ).getArray(),
-        _rNewValues.getConstArray(),
-        _rOldValues.getConstArray(),
-        _rHandles.getLength(),
-        false
-    );
-}
-
 void OControlModel::firePropertyChanges( const std::vector< sal_Int32 >& _rHandles, const std::vector< Any >& _rOldValues,
                                         const std::vector< Any >& _rNewValues, LockAccess )
 {
diff --git a/forms/source/inc/FormComponent.hxx b/forms/source/inc/FormComponent.hxx
index 201cf13f6b97..da3bb20a575e 100644
--- a/forms/source/inc/FormComponent.hxx
+++ b/forms/source/inc/FormComponent.hxx
@@ -501,12 +501,6 @@ public:
                             const std::vector< css::uno::Any >& _rNewValues,
                             LockAccess
                         );
-    void                firePropertyChanges(
-                            const css::uno::Sequence< sal_Int32 >& _rHandles,
-                            const css::uno::Sequence< css::uno::Any >& _rOldValues,
-                            const css::uno::Sequence< css::uno::Any >& _rNewValues,
-                            LockAccess
-                        );
 
     inline ::osl::Mutex&
                         getInstanceMutex() { return m_aMutex; }
diff --git a/forms/source/inc/frm_resource.hxx b/forms/source/inc/frm_resource.hxx
index 78ffa5554120..6597893ab384 100644
--- a/forms/source/inc/frm_resource.hxx
+++ b/forms/source/inc/frm_resource.hxx
@@ -35,7 +35,7 @@ namespace frm
         static SimpleResMgr*    m_pImpl;
     private:
         // no instantiation allowed
-        ResourceManager() { }
+        ResourceManager() = delete;
         ~ResourceManager() { }
 
         // we'll instantiate one static member of the following class, which, in its dtor,
diff --git a/forms/source/inc/property.hxx b/forms/source/inc/property.hxx
index daf86db81231..062e3212dec4 100644
--- a/forms/source/inc/property.hxx
+++ b/forms/source/inc/property.hxx
@@ -50,7 +50,7 @@ class PropertyInfoService
     static PropertyMap      s_AllKnownProperties;
 
 public:
-    PropertyInfoService() { }
+    PropertyInfoService() = delete;
 
     static sal_Int32            getPropertyId(const OUString& _rName);