diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2025-02-17 11:06:55 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2025-02-26 16:56:56 +0100 |
| commit | 09e2627a83d4769983c39fb2cb260e11fce354f3 (patch) | |
| tree | c070d53da0092ef3826a2511d4ae875143576253 /forms | |
| parent | a4ab140ec079b86857145f5370d083b5e2c38440 (diff) | |
use more concrete UNO types in some local vars
found by a little plugin I created.
Plugin parked into store/ folder because it needs hand-holding
when run.
Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Diffstat (limited to 'forms')
| -rw-r--r-- | forms/source/component/FormattedFieldWrapper.cxx | 3 | ||||
| -rw-r--r-- | forms/source/xforms/model_ui.cxx | 5 | ||||
| -rw-r--r-- | forms/source/xforms/submission/submission_get.cxx | 3 |
3 files changed, 4 insertions, 7 deletions
diff --git a/forms/source/component/FormattedFieldWrapper.cxx b/forms/source/component/FormattedFieldWrapper.cxx index 0c3b8103442a..1543a2068d8f 100644 --- a/forms/source/component/FormattedFieldWrapper.cxx +++ b/forms/source/component/FormattedFieldWrapper.cxx @@ -212,10 +212,9 @@ void SAL_CALL OFormattedFieldWrapper::write(const Reference<XObjectOutputStream> // for this we transfer the current props of the formatted part to the edit part Reference<XPropertySet> xFormatProps(m_xFormattedPart, UNO_QUERY); - Reference<XPropertySet> xEditProps = m_pEditPart; Locale aAppLanguage = Application::GetSettings().GetUILanguageTag().getLocale(); - dbtools::TransferFormComponentProperties(xFormatProps, xEditProps, aAppLanguage); + dbtools::TransferFormComponentProperties(xFormatProps, m_pEditPart, aAppLanguage); // then write the edit part, after switching to "fake mode" m_pEditPart->enableFormattedWriteFake(); diff --git a/forms/source/xforms/model_ui.cxx b/forms/source/xforms/model_ui.cxx index 1dd68d9fb84c..8d065f664cbc 100644 --- a/forms/source/xforms/model_ui.cxx +++ b/forms/source/xforms/model_ui.cxx @@ -372,9 +372,8 @@ css::uno::Reference< ::css::beans::XPropertySet > Model::cloneBindingAsGhost( co pBinding->deferNotifications(true); // Copy the propertyset and return result... - XPropertySet_t xNewBinding(pBinding); - copy( xBinding, xNewBinding ); - return xNewBinding; + copy( xBinding, XPropertySet_t(pBinding) ); + return pBinding; } void Model::removeBindingIfUseless( const css::uno::Reference< ::css::beans::XPropertySet >& xBinding ) diff --git a/forms/source/xforms/submission/submission_get.cxx b/forms/source/xforms/submission/submission_get.cxx index 4ee8140b2172..34f34040d39e 100644 --- a/forms/source/xforms/submission/submission_get.cxx +++ b/forms/source/xforms/submission/submission_get.cxx @@ -59,7 +59,6 @@ CSubmission::SubmissionResult CSubmissionGet::submit(const css::uno::Reference< pHelper->m_aProgressHandler.set(pProgressHelper); // UCB has ownership of environment... - css::uno::Reference< XCommandEnvironment > aEnvironment(pHelper); // append query string to the URL try { @@ -77,7 +76,7 @@ CSubmission::SubmissionResult CSubmissionGet::submit(const css::uno::Reference< aUTF8QueryURL.append("?" + aQueryString); } OUString aQueryURL = OStringToOUString(aUTF8QueryURL, RTL_TEXTENCODING_UTF8); - ucbhelper::Content aContent(aQueryURL, aEnvironment, m_xContext); + ucbhelper::Content aContent(aQueryURL, pHelper, m_xContext); // get reply try { m_aResultStream = aContent.openStream(); |