diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-09-05 11:53:35 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-10 17:11:00 +0100 |
| commit | 242320d303d43a34ce2255a07783fbd51e253cd0 (patch) | |
| tree | 14bd7757a57784a18d1aa2b731eb71999d14bf94 /formula | |
| parent | 8523fb2b37a2cdd2c3743795bb33cf30a57c5385 (diff) | |
new loplugin:reducevarscope
Change-Id: Iefe922c2e0d605114d54673d63eccc5e4abd545d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102143
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'formula')
| -rw-r--r-- | formula/source/core/api/FormulaCompiler.cxx | 2 | ||||
| -rw-r--r-- | formula/source/core/api/token.cxx | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index 3829ffe562df..bd1d1f082455 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -2211,9 +2211,9 @@ void FormulaCompiler::CreateStringFromTokenArray( OUStringBuffer& rBuffer ) else if ( FormulaGrammar::isOOXML( meGrammar ) ) { // Scan token array for missing args and rewrite if present. - MissingConventionOOXML aConv; if (pArr->NeedsOoxmlRewrite()) { + MissingConventionOOXML aConv; pArr = pArr->RewriteMissing( aConv ); maArrIterator = FormulaTokenArrayPlainIterator( *pArr ); } diff --git a/formula/source/core/api/token.cxx b/formula/source/core/api/token.cxx index 92f60254ec8f..37dd26979ced 100644 --- a/formula/source/core/api/token.cxx +++ b/formula/source/core/api/token.cxx @@ -1389,12 +1389,11 @@ FormulaTokenArray * FormulaTokenArray::RewriteMissing( const MissingConvention & ++nFn; // all following operations on _that_ function pCtx[ nFn ].mpFunc = aIter.PeekPrevNoSpaces(); pCtx[ nFn ].mnCurArg = 0; - OpCode eOp; if (rConv.isPODF() && pCtx[ nFn ].mpFunc && pCtx[ nFn ].mpFunc->GetOpCode() == ocAddress) pOcas[ nOcas++ ] = nFn; // entering ADDRESS() if PODF else if ((rConv.isODFF() || rConv.isOOXML()) && pCtx[ nFn ].mpFunc) { - eOp = pCtx[ nFn ].mpFunc->GetOpCode(); + OpCode eOp = pCtx[ nFn ].mpFunc->GetOpCode(); if (eOp == ocDBCount || eOp == ocDBCount2) pOcds[ nOcds++ ] = nFn; // entering DCOUNT() or DCOUNTA() if ODFF or OOXML } |