diff options
author | Michael Stahl <mstahl@redhat.com> | 2015-01-08 23:08:34 +0100 |
---|---|---|
committer | Michael Stahl <mstahl@redhat.com> | 2015-01-09 00:00:47 +0100 |
commit | 2f69e16c723aab48ad59d17397d8946ec0a48138 (patch) | |
tree | f59943e7a27ad60eda30cab8cdc3e8e716401db2 /fpicker | |
parent | d7bebc89c19d70344a8d71c729bbcb3a59004114 (diff) |
override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
Diffstat (limited to 'fpicker')
-rw-r--r-- | fpicker/source/office/OfficeControlAccess.cxx | 4 | ||||
-rw-r--r-- | fpicker/source/win32/filepicker/FileOpenDlg.cxx | 5 | ||||
-rw-r--r-- | fpicker/source/win32/filepicker/WinFileOpenImpl.hxx | 2 |
3 files changed, 5 insertions, 6 deletions
diff --git a/fpicker/source/office/OfficeControlAccess.cxx b/fpicker/source/office/OfficeControlAccess.cxx index 2c5bf9ba9996..a5bfde1241e3 100644 --- a/fpicker/source/office/OfficeControlAccess.cxx +++ b/fpicker/source/office/OfficeControlAccess.cxx @@ -188,7 +188,7 @@ namespace svt // URLs should always be UTF8 encoded and escaped OString sID( OUStringToOString( sHelpID, RTL_TEXTENCODING_UTF8 ) ); if ( _bFileView ) - // the file view "overloaded" the SetHelpId + // the file view "overrides" the SetHelpId static_cast< SvtFileView* >( _pControl )->SetHelpId( sID ); else _pControl->SetHelpId( sID ); @@ -199,7 +199,7 @@ namespace svt { OString aHelpId = _pControl->GetHelpId(); if ( _bFileView ) - // the file view "overloaded" the SetHelpId + // the file view "overrides" the SetHelpId aHelpId = static_cast< SvtFileView* >( _pControl )->GetHelpId( ); OUString sHelpURL; diff --git a/fpicker/source/win32/filepicker/FileOpenDlg.cxx b/fpicker/source/win32/filepicker/FileOpenDlg.cxx index 46334643c86c..6e4b24201504 100644 --- a/fpicker/source/win32/filepicker/FileOpenDlg.cxx +++ b/fpicker/source/win32/filepicker/FileOpenDlg.cxx @@ -34,7 +34,7 @@ namespace /* private */ // a lot of files in a large directory we may reach this // limit and don't want to get out of memory; // another much more elegant way would be to subclass the - // FileOpen dialog and overload the BM_CLICK event of the + // FileOpen dialog and override the BM_CLICK event of the // OK button so that we determine the size of the text // currently in the edit field and resize our buffer // appropriately - in the future we will do this @@ -523,8 +523,7 @@ void SAL_CALL CFileOpenDialog::handleInitDialog(HWND hwndDlg, HWND hwndChild) OSL_ASSERT(GetParent(hwndChild) == hwndDlg); - // calling virtual function which the - // client can overload + // calling virtual function which the client can override onInitDialog(hwndDlg); } diff --git a/fpicker/source/win32/filepicker/WinFileOpenImpl.hxx b/fpicker/source/win32/filepicker/WinFileOpenImpl.hxx index dd9a4c2fbf83..8c2f6ce3e6c4 100644 --- a/fpicker/source/win32/filepicker/WinFileOpenImpl.hxx +++ b/fpicker/source/win32/filepicker/WinFileOpenImpl.hxx @@ -164,7 +164,7 @@ protected: virtual void SAL_CALL onFolderChanged(); virtual void SAL_CALL onTypeChanged( sal_uInt32 nFilterIndex ); - // call base class method first when overloading + // call base class method first when overriding virtual void SAL_CALL onInitDialog( HWND hwndDlg ); virtual sal_uInt32 SAL_CALL onCtrlCommand( HWND hwndDlg, sal_uInt16 ctrlId, sal_uInt16 notifyCode ); |