diff options
| author | Noel Grandin <noel@peralex.com> | 2016-04-12 12:08:00 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-04-14 11:37:19 +0000 |
| commit | 62633dfe026bc3badf7066e5fb454036bae9cfdc (patch) | |
| tree | b1a30ddd709ba80b8629d916d54c03d733651d12 /fpicker | |
| parent | aa458c31a5dfa2be8b6bd8f1b4e402ce8c27edde (diff) | |
clang-tidy performance-unnecessary-value-param in various
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'fpicker')
| -rw-r--r-- | fpicker/source/office/PlacesListBox.cxx | 4 | ||||
| -rw-r--r-- | fpicker/source/office/PlacesListBox.hxx | 4 | ||||
| -rw-r--r-- | fpicker/source/office/RemoteFilesDialog.cxx | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/fpicker/source/office/PlacesListBox.cxx b/fpicker/source/office/PlacesListBox.cxx index eda3262cef7f..64fe061eb76c 100644 --- a/fpicker/source/office/PlacesListBox.cxx +++ b/fpicker/source/office/PlacesListBox.cxx @@ -100,7 +100,7 @@ void PlacesListBox::dispose() Control::dispose(); } -void PlacesListBox::AppendPlace( PlacePtr pPlace ) +void PlacesListBox::AppendPlace( const PlacePtr& pPlace ) { maPlaces.push_back( pPlace ); mpImpl->InsertEntry( pPlace->GetName( ), @@ -184,7 +184,7 @@ bool PlacesListBox::Notify( NotifyEvent& rNEvt ) return Control::Notify( rNEvt ); } -Image PlacesListBox::getEntryIcon( PlacePtr pPlace ) +Image PlacesListBox::getEntryIcon( const PlacePtr& pPlace ) { Image theImage = mpDlg->GetButtonImage( IMG_FILEDLG_PLACE_LOCAL ); if ( !pPlace->IsLocal( ) ) diff --git a/fpicker/source/office/PlacesListBox.hxx b/fpicker/source/office/PlacesListBox.hxx index 5f4f21eb69b8..05c2637883aa 100644 --- a/fpicker/source/office/PlacesListBox.hxx +++ b/fpicker/source/office/PlacesListBox.hxx @@ -53,7 +53,7 @@ class PlacesListBox : public Control virtual ~PlacesListBox( ); virtual void dispose() override; - void AppendPlace( PlacePtr pPlace ); + void AppendPlace( const PlacePtr& pPlace ); void RemovePlace( sal_uInt16 nPos ); void RemoveSelectedPlace(); sal_Int32 GetNbEditablePlaces() { return mnNbEditables;} @@ -74,7 +74,7 @@ class PlacesListBox : public Control private: - Image getEntryIcon( PlacePtr pPlace ); + Image getEntryIcon( const PlacePtr& pPlace ); DECL_LINK_TYPED( Selection, SvTreeListBox*, void ); DECL_LINK_TYPED( DoubleClick, SvTreeListBox*, bool ); diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx index dfb17fc58e53..1dc31d51ed2d 100644 --- a/fpicker/source/office/RemoteFilesDialog.cxx +++ b/fpicker/source/office/RemoteFilesDialog.cxx @@ -399,7 +399,7 @@ void RemoteFilesDialog::Show() } } -OUString lcl_GetServiceType( ServicePtr pService ) +OUString lcl_GetServiceType( const ServicePtr& pService ) { INetProtocol aProtocol = pService->GetUrlObject().GetProtocol(); switch( aProtocol ) |