diff options
| author | Markus Mohrhard <markus.mohrhard@googlemail.com> | 2017-07-31 02:22:54 +0200 |
|---|---|---|
| committer | Markus Mohrhard <markus.mohrhard@googlemail.com> | 2017-08-21 03:46:36 +0200 |
| commit | 893298e777decac8671fa24b3083357f31a924eb (patch) | |
| tree | ac7ee754bcd013919c11ad85be07fbf2e4e36463 /fpicker | |
| parent | ad21f8ec355dd356bdfe72c67ebf3c4c5cf3f235 (diff) | |
avoid out of bounds access
Change-Id: I4c7ddf2fcabc231b7250306b4a9255fab1a9ef7c
Diffstat (limited to 'fpicker')
| -rw-r--r-- | fpicker/source/office/RemoteFilesDialog.cxx | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx index ca37b71c8c15..df8e1282e415 100644 --- a/fpicker/source/office/RemoteFilesDialog.cxx +++ b/fpicker/source/office/RemoteFilesDialog.cxx @@ -529,9 +529,10 @@ int RemoteFilesDialog::GetSelectedServicePos() if( m_aServices.empty() ) return -1; - while( nPos < ( int )m_aServices.size() ) + int nServices = static_cast<int>(m_aServices.size()); + while( nPos < nServices ) { - while( m_aServices[nPos]->IsLocal() ) + while( (nPos < nServices) && m_aServices[nPos]->IsLocal() ) nPos++; i++; if( i == nSelected ) |