diff options
| author | David Tardon <dtardon@redhat.com> | 2011-05-12 08:05:42 +0200 |
|---|---|---|
| committer | David Tardon <dtardon@redhat.com> | 2011-05-12 14:32:29 +0200 |
| commit | b7f5f3fea1b240bd03411a0d76fa608b0de1c534 (patch) | |
| tree | 6730a5c9085efef164bc7a9ed249d4b53a4eaceb /fpicker | |
| parent | 6be5742c156ab5f0257dff3006ae079e87c40f08 (diff) | |
do not leak memory
Diffstat (limited to 'fpicker')
| -rw-r--r-- | fpicker/source/office/fpsmartcontent.cxx | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/fpicker/source/office/fpsmartcontent.cxx b/fpicker/source/office/fpsmartcontent.cxx index ae97b365baf7..b69a12f22bbc 100644 --- a/fpicker/source/office/fpsmartcontent.cxx +++ b/fpicker/source/office/fpsmartcontent.cxx @@ -76,8 +76,18 @@ namespace svt //-------------------------------------------------------------------- SmartContent::~SmartContent() { - //Do not delete the content. Because the content will be used by the cache. - //DELETEZ( m_pContent ); + /* This destructor originally contained the following blurb: "Do + not delete the content. Because the content will be used by + the cache." This is just plain silly, because it relies on + the provider caching created contents (which is done by + ucbhelper::ContentProviderImplHelper, but we do not actually + expect all providers to use that, right?) Otherwise we are + just leaking memory. + + TODO: If there is real need for caching the content, it must + be done here. + */ + delete m_pContent; } //-------------------------------------------------------------------- |