cppcheck: noExplicitConstructor

Change-Id: Ifdcb1cc12645d6cdba81d16f94f0268696187cde
Reviewed-on: https://gerrit.libreoffice.org/21201
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

23 files changed, 33 insertions, 34 deletions

diff --git a/fpicker/source/office/OfficeControlAccess.cxx b/fpicker/source/office/OfficeControlAccess.cxx
index 31adbc8c33a6..a42dc2659030 100644
--- a/fpicker/source/office/OfficeControlAccess.cxx
+++ b/fpicker/source/office/OfficeControlAccess.cxx
@@ -153,11 +153,14 @@ namespace svt
         struct ControlPropertyLookup
         {
             OUString m_sLookup;
-            ControlPropertyLookup( const OUString& _rLookup ) : m_sLookup( _rLookup ) { }
+            explicit ControlPropertyLookup(const OUString& rLookup)
+                : m_sLookup(rLookup)
+            {
+            }
 
-            bool operator()( const ControlProperty& _rProp )
+            bool operator()(const ControlProperty& rProp)
             {
-                return m_sLookup.equalsAscii( _rProp.pPropertyName );
+                return m_sLookup.equalsAscii(rProp.pPropertyName);
             }
         };
 
diff --git a/fpicker/source/office/OfficeFilePicker.cxx b/fpicker/source/office/OfficeFilePicker.cxx
index 9bd9724cf187..a4d9dd3e4b9f 100644
--- a/fpicker/source/office/OfficeFilePicker.cxx
+++ b/fpicker/source/office/OfficeFilePicker.cxx
@@ -122,7 +122,7 @@ struct ElementEntry_Impl
     bool        m_bHasLabel     : 1;
     bool        m_bHasEnabled   : 1;
 
-                    ElementEntry_Impl( sal_Int16 nId );
+    explicit        ElementEntry_Impl( sal_Int16 nId );
 
     void            setValue( const Any& rVal ) { m_aValue = rVal; m_bHasValue = true; }
     void            setAction( sal_Int16 nAction ) { m_nControlAction = nAction; }
@@ -337,7 +337,7 @@ namespace {
         const OUString& rTitle;
 
     public:
-        FilterTitleMatch( const OUString& _rTitle ) : rTitle( _rTitle ) { }
+        explicit FilterTitleMatch( const OUString& _rTitle ) : rTitle( _rTitle ) { }
 
 
         bool operator () ( const FilterEntry& _rEntry )
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx
index b5de1d9cde94..e62dd6236775 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -28,7 +28,7 @@ class FileViewContainer : public vcl::Window
     VclPtr<vcl::Window> m_pFocusWidgets[FocusState::FocusCount];
 
     public:
-    FileViewContainer( vcl::Window *pParent )
+    explicit FileViewContainer( vcl::Window *pParent )
         : Window( pParent, WB_TABSTOP )
         , m_pFileView( nullptr )
         , m_pTreeView( nullptr )
diff --git a/fpicker/source/office/fpinteraction.hxx b/fpicker/source/office/fpinteraction.hxx
index bfac7d9bc9e3..28192e0bed9d 100644
--- a/fpicker/source/office/fpinteraction.hxx
+++ b/fpicker/source/office/fpinteraction.hxx
@@ -57,7 +57,7 @@ namespace svt
         EInterceptedInteractions                              m_eInterceptions; // enable/disable interception of some special interactions
 
     public:
-        OFilePickerInteractionHandler( const css::uno::Reference< css::task::XInteractionHandler >& _rxMaster );
+        explicit OFilePickerInteractionHandler( const css::uno::Reference< css::task::XInteractionHandler >& _rxMaster );
 
         // some generic functions
         void     enableInterceptions( EInterceptedInteractions eInterceptions );
diff --git a/fpicker/source/office/fpsmartcontent.hxx b/fpicker/source/office/fpsmartcontent.hxx
index c37db2f933be..d25cdd8a01c0 100644
--- a/fpicker/source/office/fpsmartcontent.hxx
+++ b/fpicker/source/office/fpsmartcontent.hxx
@@ -66,7 +66,7 @@ namespace svt
 
     public:
         SmartContent();
-        SmartContent( const OUString& _rInitialURL );
+        explicit SmartContent( const OUString& _rInitialURL );
         ~SmartContent();
 
     public:
diff --git a/fpicker/source/office/fpsofficeResMgr.hxx b/fpicker/source/office/fpsofficeResMgr.hxx
index 359fc8867f04..8c5137cb18e9 100644
--- a/fpicker/source/office/fpsofficeResMgr.hxx
+++ b/fpicker/source/office/fpsofficeResMgr.hxx
@@ -33,7 +33,7 @@ namespace fpicker
 
     struct SvtResId : public ResId
     {
-        SvtResId (sal_uInt16 nId) : ResId (nId, *ResMgrHolder::getOrCreate()) {}
+        explicit SvtResId (sal_uInt16 nId) : ResId (nId, *ResMgrHolder::getOrCreate()) {}
     };
 }
 
diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index 5b32695884b2..3365bb28ce51 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -366,7 +366,7 @@ class CustomContainer : public vcl::Window
     VclPtr<vcl::Window> m_pFocusWidgets[FocusState::FocusCount];
 
 public:
-    CustomContainer(vcl::Window *pParent)
+    explicit CustomContainer(vcl::Window *pParent)
         : Window(pParent)
         , _pImp(nullptr)
         , _pFileView(nullptr)
@@ -1696,7 +1696,7 @@ private:
     VclPtr<vcl::Window> _pOld;
 
 public:
-    SvtDefModalDialogParent_Impl( vcl::Window *pNew ) :
+    explicit SvtDefModalDialogParent_Impl( vcl::Window *pNew ) :
         _pOld( Application::GetDefDialogParent() )
         { Application::SetDefDialogParent( pNew ); }
 
diff --git a/fpicker/source/office/iodlgimp.cxx b/fpicker/source/office/iodlgimp.cxx
index c5e0552a7970..ae511ecb53a6 100644
--- a/fpicker/source/office/iodlgimp.cxx
+++ b/fpicker/source/office/iodlgimp.cxx
@@ -65,7 +65,7 @@ namespace
 
     struct SvtSimpleResId : public ResId
     {
-        SvtSimpleResId (sal_uInt16 nId) : ResId (nId, *ResMgrHolder::getOrCreate()) {}
+        explicit SvtSimpleResId (sal_uInt16 nId) : ResId (nId, *ResMgrHolder::getOrCreate()) {}
     };
 }
 
diff --git a/fpicker/source/office/iodlgimp.hxx b/fpicker/source/office/iodlgimp.hxx
index 5452c94da62b..38aa8bdb8e11 100644
--- a/fpicker/source/office/iodlgimp.hxx
+++ b/fpicker/source/office/iodlgimp.hxx
@@ -181,7 +181,7 @@ public:
     // remember sizes
     OUString                        _aIniKey;
 
-                            SvtExpFileDlg_Impl( WinBits nBits );
+    explicit                SvtExpFileDlg_Impl( WinBits nBits );
                             ~SvtExpFileDlg_Impl();
 
 
diff --git a/fpicker/source/win32/filepicker/FilePicker.hxx b/fpicker/source/win32/filepicker/FilePicker.hxx
index 1c68cf029d4b..63029ef4bbf5 100644
--- a/fpicker/source/win32/filepicker/FilePicker.hxx
+++ b/fpicker/source/win32/filepicker/FilePicker.hxx
@@ -58,7 +58,7 @@ class CFilePicker :
 public:
 
     // ctor
-    CFilePicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceMgr );
+    explicit CFilePicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceMgr );
 
     // XFilePickerNotifier
 
diff --git a/fpicker/source/win32/filepicker/VistaFilePicker.hxx b/fpicker/source/win32/filepicker/VistaFilePicker.hxx
index 01b6da335893..b14eb124dc69 100644
--- a/fpicker/source/win32/filepicker/VistaFilePicker.hxx
+++ b/fpicker/source/win32/filepicker/VistaFilePicker.hxx
@@ -67,7 +67,7 @@ public:
     // ctor/dtor
 
 
-             VistaFilePicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xSMGR );
+    explicit VistaFilePicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xSMGR );
     virtual ~VistaFilePicker();
 
 
diff --git a/fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx b/fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx
index 98a61afc0b24..bb63b55b0050 100644
--- a/fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx
+++ b/fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx
@@ -61,7 +61,7 @@ class VistaFilePickerEventHandler : public ::cppu::BaseMutex
         // ctor/dtor
 
 
-                 VistaFilePickerEventHandler(IVistaFilePickerInternalNotify* pInternalNotify);
+        explicit VistaFilePickerEventHandler(IVistaFilePickerInternalNotify* pInternalNotify);
         virtual ~VistaFilePickerEventHandler();
 
 
diff --git a/fpicker/source/win32/filepicker/asynceventnotifier.hxx b/fpicker/source/win32/filepicker/asynceventnotifier.hxx
index b5d4d1735c86..335608d2645d 100644
--- a/fpicker/source/win32/filepicker/asynceventnotifier.hxx
+++ b/fpicker/source/win32/filepicker/asynceventnotifier.hxx
@@ -43,7 +43,7 @@
 class CAsyncEventNotifier
 {
 public:
-    CAsyncEventNotifier(cppu::OBroadcastHelper& rBroadcastHelper);
+    explicit CAsyncEventNotifier(cppu::OBroadcastHelper& rBroadcastHelper);
     ~CAsyncEventNotifier();
 
     bool SAL_CALL startup(bool bCreateSuspended = true);
diff --git a/fpicker/source/win32/filepicker/controlcommand.hxx b/fpicker/source/win32/filepicker/controlcommand.hxx
index c843589c8617..497286344b22 100644
--- a/fpicker/source/win32/filepicker/controlcommand.hxx
+++ b/fpicker/source/win32/filepicker/controlcommand.hxx
@@ -32,14 +32,10 @@ class CFilePickerState;
 class CControlCommandRequest;
 class CControlCommandResult;
 
-
-
-
-
 class CControlCommand
 {
 public:
-    CControlCommand( sal_Int16 aControlId );
+    explicit CControlCommand( sal_Int16 aControlId );
     virtual ~CControlCommand( );
 
     virtual void SAL_CALL exec( CFilePickerState* aFilePickerState ) = 0;
diff --git a/fpicker/source/win32/filepicker/controlcommandrequest.hxx b/fpicker/source/win32/filepicker/controlcommandrequest.hxx
index f62cfd3a35c7..6fc95a3027ee 100644
--- a/fpicker/source/win32/filepicker/controlcommandrequest.hxx
+++ b/fpicker/source/win32/filepicker/controlcommandrequest.hxx
@@ -29,7 +29,7 @@
 class CControlCommandRequest
 {
 public:
-    CControlCommandRequest( sal_Int16 aControlId ) :
+    explicit CControlCommandRequest( sal_Int16 aControlId ) :
         m_aControlId( aControlId )
     {
     }
diff --git a/fpicker/source/win32/filepicker/controlcommandresult.hxx b/fpicker/source/win32/filepicker/controlcommandresult.hxx
index f32fff6ad79a..cdc09ec8c626 100644
--- a/fpicker/source/win32/filepicker/controlcommandresult.hxx
+++ b/fpicker/source/win32/filepicker/controlcommandresult.hxx
@@ -31,7 +31,7 @@
 class CControlCommandResult
 {
 public:
-    CControlCommandResult( sal_Bool bResult = sal_False ) :
+    explicit CControlCommandResult( sal_Bool bResult = sal_False ) :
         m_bResult( bResult )
     {
     }
diff --git a/fpicker/source/win32/filepicker/filepickereventnotification.hxx b/fpicker/source/win32/filepicker/filepickereventnotification.hxx
index bb9a0582055e..132e4e937371 100644
--- a/fpicker/source/win32/filepicker/filepickereventnotification.hxx
+++ b/fpicker/source/win32/filepicker/filepickereventnotification.hxx
@@ -35,7 +35,7 @@ public:
     typedef void (SAL_CALL css::ui::dialogs::XFilePickerListener::*EventListenerMethod_t)();
 
 public:
-    CFilePickerEventNotification(EventListenerMethod_t EventListenerMethod);
+    explicit CFilePickerEventNotification(EventListenerMethod_t EventListenerMethod);
 
     virtual void SAL_CALL notifyEventListener( css::uno::Reference< css::uno::XInterface > xListener );
 
@@ -52,7 +52,7 @@ class CFilePickerParamEventNotification : public CEventNotification
 public:
     typedef void (SAL_CALL css::ui::dialogs::XFilePickerListener::*EventListenerMethod_t)(const css::ui::dialogs::FilePickerEvent&);
 
-    CFilePickerParamEventNotification(EventListenerMethod_t EventListenerMethod, const css::ui::dialogs::FilePickerEvent& FilePickerEvent);
+    explicit CFilePickerParamEventNotification(EventListenerMethod_t EventListenerMethod, const css::ui::dialogs::FilePickerEvent& FilePickerEvent);
 
     virtual void SAL_CALL notifyEventListener( css::uno::Reference< css::uno::XInterface > xListener );
 
diff --git a/fpicker/source/win32/filepicker/filepickerstate.hxx b/fpicker/source/win32/filepicker/filepickerstate.hxx
index fbf15f62747c..24e6ba1edf77 100644
--- a/fpicker/source/win32/filepicker/filepickerstate.hxx
+++ b/fpicker/source/win32/filepicker/filepickerstate.hxx
@@ -108,7 +108,7 @@ private:
 class CExecuteFilePickerState : public CFilePickerState
 {
 public:
-    CExecuteFilePickerState( HWND hwndDlg = NULL );
+    explicit CExecuteFilePickerState( HWND hwndDlg = NULL );
 
     virtual void SAL_CALL setValue( sal_Int16 aControlId, sal_Int16 aControlAction, const css::uno::Any& aValue );
 
diff --git a/fpicker/source/win32/filepicker/previewadapter.cxx b/fpicker/source/win32/filepicker/previewadapter.cxx
index 1180d8856f29..981fde0ff882 100644
--- a/fpicker/source/win32/filepicker/previewadapter.cxx
+++ b/fpicker/source/win32/filepicker/previewadapter.cxx
@@ -44,7 +44,7 @@ using namespace ::com::sun::star::lang;
 class CPreviewAdapterImpl
 {
 public:
-    CPreviewAdapterImpl(HINSTANCE instance);
+    explicit CPreviewAdapterImpl(HINSTANCE instance);
 
     virtual ~CPreviewAdapterImpl();
 
@@ -402,7 +402,7 @@ HWND SAL_CALL CPreviewAdapterImpl::findFileListbox() const
 class CWin95NTPreviewAdapterImpl : public CPreviewAdapterImpl
 {
 public:
-    CWin95NTPreviewAdapterImpl(HINSTANCE instance);
+    explicit CWin95NTPreviewAdapterImpl(HINSTANCE instance);
 
     virtual void SAL_CALL notifyParentShow(sal_Bool bShow);
 };
diff --git a/fpicker/source/win32/filepicker/previewadapter.hxx b/fpicker/source/win32/filepicker/previewadapter.hxx
index c3cfe171b0f7..634b9b7c0494 100644
--- a/fpicker/source/win32/filepicker/previewadapter.hxx
+++ b/fpicker/source/win32/filepicker/previewadapter.hxx
@@ -50,7 +50,7 @@ class CPreviewAdapter
 public:
 
     // ctor
-    CPreviewAdapter(HINSTANCE instance);
+    explicit CPreviewAdapter(HINSTANCE instance);
 
     ~CPreviewAdapter();
 
diff --git a/fpicker/source/win32/folderpicker/FolderPicker.hxx b/fpicker/source/win32/folderpicker/FolderPicker.hxx
index d5612ee1095d..331cfee37e36 100644
--- a/fpicker/source/win32/folderpicker/FolderPicker.hxx
+++ b/fpicker/source/win32/folderpicker/FolderPicker.hxx
@@ -43,7 +43,7 @@ class CFolderPicker :
 public:
 
     // ctor/dtor
-    CFolderPicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceMgr );
+    explicit CFolderPicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceMgr );
 
 
     // XExecutableDialog
diff --git a/fpicker/source/win32/folderpicker/MtaFop.hxx b/fpicker/source/win32/folderpicker/MtaFop.hxx
index 62a01df6034b..c85d6b420332 100644
--- a/fpicker/source/win32/folderpicker/MtaFop.hxx
+++ b/fpicker/source/win32/folderpicker/MtaFop.hxx
@@ -51,7 +51,7 @@
 class CAutoPathBuff
 {
 public:
-    CAutoPathBuff( size_t size = 0 )
+    explicit CAutoPathBuff( size_t size = 0 )
     {
         if (0 == size)
             size = 32000; // max path length under Win2000
@@ -96,7 +96,7 @@ private:
 class CMtaFolderPicker
 {
 public:
-    CMtaFolderPicker( sal_uInt32 Flags );
+    explicit CMtaFolderPicker( sal_uInt32 Flags );
     virtual ~CMtaFolderPicker( );
 
     // shell functions
diff --git a/fpicker/source/win32/folderpicker/WinFOPImpl.hxx b/fpicker/source/win32/folderpicker/WinFOPImpl.hxx
index ecfe8ff4b8b8..e5336b3adb85 100644
--- a/fpicker/source/win32/folderpicker/WinFOPImpl.hxx
+++ b/fpicker/source/win32/folderpicker/WinFOPImpl.hxx
@@ -33,7 +33,7 @@ class CFolderPicker;
 class CWinFolderPickerImpl : public CMtaFolderPicker
 {
 public:
-    CWinFolderPickerImpl( CFolderPicker* aFolderPicker );
+    explicit CWinFolderPickerImpl( CFolderPicker* aFolderPicker );
 
 
     // XExecutableDialog