diff options
author | Norbert Thiebaud <nthiebaud@gmail.com> | 2014-07-01 10:24:05 +0200 |
---|---|---|
committer | Norbert Thiebaud <nthiebaud@gmail.com> | 2014-07-01 12:44:04 +0200 |
commit | 5371bc50c0ea931e9859186f0f05644bbdb51246 (patch) | |
tree | 1cf3bb9cead88c828fc5dd25d40b923427aabaef /fpicker | |
parent | 1f7a67083dddee3550e9dd6be8e0d592ed69d28b (diff) |
coverity#703963 Unchecked return value
also avoid pointless double Guard
Change-Id: Ie7707fc3baf46f9363fdef6213df098123183ab9
Diffstat (limited to 'fpicker')
-rw-r--r-- | fpicker/source/office/commonpicker.cxx | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/fpicker/source/office/commonpicker.cxx b/fpicker/source/office/commonpicker.cxx index 963a7fb46568..6e70b78d2eea 100644 --- a/fpicker/source/office/commonpicker.cxx +++ b/fpicker/source/office/commonpicker.cxx @@ -99,12 +99,12 @@ namespace svt void OCommonPicker::prepareDialog() { - if ( !getDialog() ) - createPicker(); - - // set the title - if ( !m_aTitle.isEmpty() ) - getDialog()->SetText( m_aTitle ); + if(createPicker()) + { + // set the title + if ( !m_aTitle.isEmpty() ) + m_pDlg->SetText( m_aTitle ); + } } @@ -199,8 +199,6 @@ namespace svt bool OCommonPicker::createPicker() { - SolarMutexGuard aGuard; - if ( !m_pDlg ) { m_pDlg = implCreateDialog( VCLUnoHelper::GetWindow( m_xDialogParent ) ); |