diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-11-01 15:11:01 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-11-02 07:41:11 +0100 |
commit | 27d75c3986a257c121d6612413a4d1f59cd1425d (patch) | |
tree | 4433653012f213d2f4a6ec178bac6e1e3df0e0bb /framework/inc/helper | |
parent | 270596b0e98ee32f1d4224751a8be51a4af9ac91 (diff) |
loplugin:finalclasses in framework
Change-Id: Ic060a8ec60c1209511c376f31e2dc45a48973294
Reviewed-on: https://gerrit.libreoffice.org/44166
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'framework/inc/helper')
-rw-r--r-- | framework/inc/helper/ocomponentenumeration.hxx | 8 | ||||
-rw-r--r-- | framework/inc/helper/oframes.hxx | 8 |
2 files changed, 4 insertions, 12 deletions
diff --git a/framework/inc/helper/ocomponentenumeration.hxx b/framework/inc/helper/ocomponentenumeration.hxx index d0e801270fdb..3f30a2ef2b75 100644 --- a/framework/inc/helper/ocomponentenumeration.hxx +++ b/framework/inc/helper/ocomponentenumeration.hxx @@ -48,7 +48,7 @@ namespace framework{ @threadsafe yes *//*-*************************************************************************************************************/ -class OComponentEnumeration : public ::cppu::WeakImplHelper< css::container::XEnumeration,css::lang::XEventListener > +class OComponentEnumeration final : public ::cppu::WeakImplHelper< css::container::XEnumeration,css::lang::XEventListener > { // public methods @@ -112,7 +112,7 @@ class OComponentEnumeration : public ::cppu::WeakImplHelper< css::container::X // protected methods - protected: + private: /*-**************************************************************************************************** @short standard destructor @@ -138,8 +138,6 @@ class OComponentEnumeration : public ::cppu::WeakImplHelper< css::container::X void impl_resetObject(); - private: - // debug methods // (should be private everyway!) @@ -155,8 +153,6 @@ class OComponentEnumeration : public ::cppu::WeakImplHelper< css::container::X sal_True otherway *//*-*****************************************************************************************************/ - private: - sal_uInt32 m_nPosition; /// current position in enumeration std::vector< css::uno::Reference< css::lang::XComponent > > m_seqComponents; /// list of current components diff --git a/framework/inc/helper/oframes.hxx b/framework/inc/helper/oframes.hxx index a018f00a5fa5..091b757b7e22 100644 --- a/framework/inc/helper/oframes.hxx +++ b/framework/inc/helper/oframes.hxx @@ -44,7 +44,7 @@ namespace framework{ @ATTENTION Don't use this class as direct member - use it dynamically. Do not derive from this class. We hold a weakreference to our owner not to our superclass. */ -class OFrames : public ::cppu::WeakImplHelper< css::frame::XFrames > +class OFrames final : public ::cppu::WeakImplHelper< css::frame::XFrames > { public: @@ -146,7 +146,7 @@ class OFrames : public ::cppu::WeakImplHelper< css::frame::XFrames > */ virtual sal_Bool SAL_CALL hasElements() override; - protected: + private: /** @short standard destructor @@ -168,8 +168,6 @@ class OFrames : public ::cppu::WeakImplHelper< css::frame::XFrames > */ void impl_resetObject(); - private: - /** @short append one sequence to another @descr There is no operation to add to sequences! Use this helper-method to do this. @@ -183,13 +181,11 @@ class OFrames : public ::cppu::WeakImplHelper< css::frame::XFrames > void impl_appendSequence( css::uno::Sequence< css::uno::Reference< css::frame::XFrame > >& seqDestination , const css::uno::Sequence< css::uno::Reference< css::frame::XFrame > >& seqSource ); - private: static bool impldbg_checkParameter_queryFrames ( sal_Int32 nSearchFlags ); css::uno::WeakReference< css::frame::XFrame > m_xOwner; /// reference to owner of this instance (Hold no hard reference!) FrameContainer* m_pFrameContainer; /// with owner shared list to hold all direct children of an XFramesSupplier bool m_bRecursiveSearchProtection; /// flag to protect against recursive searches of frames at parents - }; } |