diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-01-14 10:12:35 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-01-14 15:27:00 +0100 |
commit | 47c0d10b02f6f89ef11f5eb6ce86efb5edb69f30 (patch) | |
tree | bbab4b1fd61b28b27ad31e6b6a326eea471256ca /framework/inc/helper | |
parent | af4f3bd896bb554b71972da5379a490b869f24bb (diff) |
loplugin:finalclasses in framework
Change-Id: I5405a123e887173fe4b90d66dab6225bf43883ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86740
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'framework/inc/helper')
-rw-r--r-- | framework/inc/helper/dockingareadefaultacceptor.hxx | 2 | ||||
-rw-r--r-- | framework/inc/helper/mischelper.hxx | 6 | ||||
-rw-r--r-- | framework/inc/helper/ocomponentaccess.hxx | 6 | ||||
-rw-r--r-- | framework/inc/helper/persistentwindowstate.hxx | 2 | ||||
-rw-r--r-- | framework/inc/helper/statusindicator.hxx | 2 | ||||
-rw-r--r-- | framework/inc/helper/statusindicatorfactory.hxx | 5 | ||||
-rw-r--r-- | framework/inc/helper/tagwindowasmodified.hxx | 2 | ||||
-rw-r--r-- | framework/inc/helper/titlebarupdate.hxx | 2 | ||||
-rw-r--r-- | framework/inc/helper/vclstatusindicator.hxx | 2 | ||||
-rw-r--r-- | framework/inc/helper/wakeupthread.hxx | 2 |
10 files changed, 14 insertions, 17 deletions
diff --git a/framework/inc/helper/dockingareadefaultacceptor.hxx b/framework/inc/helper/dockingareadefaultacceptor.hxx index 281c9811499a..16423fb6e838 100644 --- a/framework/inc/helper/dockingareadefaultacceptor.hxx +++ b/framework/inc/helper/dockingareadefaultacceptor.hxx @@ -28,7 +28,7 @@ namespace framework{ -class DockingAreaDefaultAcceptor : public ::cppu::WeakImplHelper< css::ui::XDockingAreaAcceptor > +class DockingAreaDefaultAcceptor final : public ::cppu::WeakImplHelper< css::ui::XDockingAreaAcceptor > { public: diff --git a/framework/inc/helper/mischelper.hxx b/framework/inc/helper/mischelper.hxx index 4d7b3a5a3bee..00f8689487e6 100644 --- a/framework/inc/helper/mischelper.hxx +++ b/framework/inc/helper/mischelper.hxx @@ -136,7 +136,7 @@ FWI_DLLPUBLIC void FillLangItems( std::set< OUString > &rLangItems, //OriginalListener owns the Broadcaster which "owns" the WeakContainerListener //which forwards the events to the OriginalListener without taking ownership of //it. -class WeakContainerListener : public ::cppu::WeakImplHelper<css::container::XContainerListener> +class WeakContainerListener final : public ::cppu::WeakImplHelper<css::container::XContainerListener> { private: css::uno::WeakReference<css::container::XContainerListener> mxOwner; @@ -183,7 +183,7 @@ class WeakContainerListener : public ::cppu::WeakImplHelper<css::container::XCon } }; -class WeakChangesListener : public ::cppu::WeakImplHelper<css::util::XChangesListener> +class WeakChangesListener final : public ::cppu::WeakImplHelper<css::util::XChangesListener> { private: css::uno::WeakReference<css::util::XChangesListener> mxOwner; @@ -214,7 +214,7 @@ class WeakChangesListener : public ::cppu::WeakImplHelper<css::util::XChangesLis } }; -class WeakDocumentEventListener : public ::cppu::WeakImplHelper<css::document::XDocumentEventListener> +class WeakDocumentEventListener final : public ::cppu::WeakImplHelper<css::document::XDocumentEventListener> { private: css::uno::WeakReference<css::document::XDocumentEventListener> mxOwner; diff --git a/framework/inc/helper/ocomponentaccess.hxx b/framework/inc/helper/ocomponentaccess.hxx index 0ab674a33156..ed11756c08ef 100644 --- a/framework/inc/helper/ocomponentaccess.hxx +++ b/framework/inc/helper/ocomponentaccess.hxx @@ -49,7 +49,7 @@ namespace framework{ @devstatus ready to use *//*-*************************************************************************************************************/ -class OComponentAccess : public ::cppu::WeakImplHelper< css::container::XEnumerationAccess > +class OComponentAccess final : public ::cppu::WeakImplHelper< css::container::XEnumerationAccess > { // public methods @@ -110,7 +110,7 @@ class OComponentAccess : public ::cppu::WeakImplHelper< css::container::XEnum // protected methods - protected: + private: /*-**************************************************************************************************** @short standard destructor @@ -125,8 +125,6 @@ class OComponentAccess : public ::cppu::WeakImplHelper< css::container::XEnum virtual ~OComponentAccess() override; - private: - /*-**************************************************************************************************** @short recursive method (!) to collect all components of all frames from the subtree of given node @descr This is necessary to create the enumeration. diff --git a/framework/inc/helper/persistentwindowstate.hxx b/framework/inc/helper/persistentwindowstate.hxx index ce6f0ed434ba..f467ef9a2286 100644 --- a/framework/inc/helper/persistentwindowstate.hxx +++ b/framework/inc/helper/persistentwindowstate.hxx @@ -46,7 +46,7 @@ namespace framework{ @devstatus ready @threadsafe yes *//*-*************************************************************************************************************/ -class PersistentWindowState : public ::cppu::WeakImplHelper< +class PersistentWindowState final : public ::cppu::WeakImplHelper< css::lang::XInitialization, css::frame::XFrameActionListener > // => XEventListener { diff --git a/framework/inc/helper/statusindicator.hxx b/framework/inc/helper/statusindicator.hxx index a97cfe952062..66d5b1e7535a 100644 --- a/framework/inc/helper/statusindicator.hxx +++ b/framework/inc/helper/statusindicator.hxx @@ -48,7 +48,7 @@ namespace framework{ @devstatus ready to use @threadsafe yes */ -class StatusIndicator : public ::cppu::WeakImplHelper< css::task::XStatusIndicator > +class StatusIndicator final : public ::cppu::WeakImplHelper< css::task::XStatusIndicator > { // member diff --git a/framework/inc/helper/statusindicatorfactory.hxx b/framework/inc/helper/statusindicatorfactory.hxx index 467c1ccd84bf..8472aaec20c2 100644 --- a/framework/inc/helper/statusindicatorfactory.hxx +++ b/framework/inc/helper/statusindicatorfactory.hxx @@ -116,7 +116,7 @@ typedef ::std::vector< IndicatorInfo > IndicatorStack; @devstatus ready to use @threadsafe yes */ -class StatusIndicatorFactory : public ::cppu::WeakImplHelper< +class StatusIndicatorFactory final : public ::cppu::WeakImplHelper< css::lang::XServiceInfo , css::lang::XInitialization , css::task::XStatusIndicatorFactory @@ -214,12 +214,11 @@ class StatusIndicatorFactory : public ::cppu::WeakImplHelper< // specials - protected: + private: virtual ~StatusIndicatorFactory() override; // helper - private: /** @short show the parent window of this progress ... if it's allowed to do so. diff --git a/framework/inc/helper/tagwindowasmodified.hxx b/framework/inc/helper/tagwindowasmodified.hxx index ef749f030cfc..f466803a0a20 100644 --- a/framework/inc/helper/tagwindowasmodified.hxx +++ b/framework/inc/helper/tagwindowasmodified.hxx @@ -41,7 +41,7 @@ namespace framework{ @devstatus draft @threadsafe yes *//*-*************************************************************************************************************/ -class TagWindowAsModified : public ::cppu::WeakImplHelper< +class TagWindowAsModified final : public ::cppu::WeakImplHelper< css::lang::XInitialization, css::frame::XFrameActionListener, // => XEventListener css::util::XModifyListener > // => XEventListener diff --git a/framework/inc/helper/titlebarupdate.hxx b/framework/inc/helper/titlebarupdate.hxx index 88030f9cee88..c06d23976ed4 100644 --- a/framework/inc/helper/titlebarupdate.hxx +++ b/framework/inc/helper/titlebarupdate.hxx @@ -36,7 +36,7 @@ namespace framework{ @devstatus draft @threadsafe yes *//*-*************************************************************************************************************/ -class TitleBarUpdate : public ::cppu::WeakImplHelper< +class TitleBarUpdate final : public ::cppu::WeakImplHelper< css::lang::XInitialization , css::frame::XTitleChangeListener // => XEventListener , css::frame::XFrameActionListener > // => XEventListener diff --git a/framework/inc/helper/vclstatusindicator.hxx b/framework/inc/helper/vclstatusindicator.hxx index f3ea3d9c4944..ba0a84a0e2f4 100644 --- a/framework/inc/helper/vclstatusindicator.hxx +++ b/framework/inc/helper/vclstatusindicator.hxx @@ -30,7 +30,7 @@ namespace framework { // declaration -class VCLStatusIndicator : public ::cppu::WeakImplHelper< css::task::XStatusIndicator > +class VCLStatusIndicator final : public ::cppu::WeakImplHelper< css::task::XStatusIndicator > { // member diff --git a/framework/inc/helper/wakeupthread.hxx b/framework/inc/helper/wakeupthread.hxx index 6632d4b049f3..97c462c84e28 100644 --- a/framework/inc/helper/wakeupthread.hxx +++ b/framework/inc/helper/wakeupthread.hxx @@ -34,7 +34,7 @@ namespace com { namespace sun { namespace star { namespace util { namespace framework{ -class WakeUpThread: public salhelper::Thread { +class WakeUpThread final : public salhelper::Thread { css::uno::WeakReference<css::util::XUpdatable> updatable_; osl::Condition condition_; |