diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-13 14:29:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-17 09:57:35 +0100 |
| commit | 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 (patch) | |
| tree | f4cca1a99ba97683b14fa6fe0f1f45f75bf855c2 /framework/inc | |
| parent | 75bada928cf08d2afc6efe52ba99b45088bc9eec (diff) | |
loplugin:stringviewparam check methods too
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'framework/inc')
| -rw-r--r-- | framework/inc/addonmenu.hxx | 2 | ||||
| -rw-r--r-- | framework/inc/uielement/toolbarmerger.hxx | 10 | ||||
| -rw-r--r-- | framework/inc/uifactory/menubarfactory.hxx | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/framework/inc/addonmenu.hxx b/framework/inc/addonmenu.hxx index 1f6443b48a79..461f81af2fc6 100644 --- a/framework/inc/addonmenu.hxx +++ b/framework/inc/addonmenu.hxx @@ -41,7 +41,7 @@ class AddonMenuManager static bool HasAddonMenuElements(); // Check if the context string matches the provided xModel context - static bool IsCorrectContext(const OUString& rModuleIdentifier, const OUString& rContext); + static bool IsCorrectContext(std::u16string_view rModuleIdentifier, const OUString& rContext); // Create the Add-Ons menu static VclPtr<PopupMenu> CreateAddonMenu( const css::uno::Reference< css::frame::XFrame >& rFrame ); diff --git a/framework/inc/uielement/toolbarmerger.hxx b/framework/inc/uielement/toolbarmerger.hxx index d3ccc1c8cbcb..03b9a1d8325e 100644 --- a/framework/inc/uielement/toolbarmerger.hxx +++ b/framework/inc/uielement/toolbarmerger.hxx @@ -59,7 +59,7 @@ struct ReferenceToolbarPathInfo class ToolBarMerger { public: - static bool IsCorrectContext( const OUString& aContext, const OUString& aModuleIdentifier ); + static bool IsCorrectContext( const OUString& aContext, std::u16string_view aModuleIdentifier ); static void ConvertSeqSeqToVector( const css::uno::Sequence< css::uno::Sequence< css::beans::PropertyValue > >& rSequence, AddonToolbarItemContainer& rContainer ); @@ -79,7 +79,7 @@ class ToolBarMerger ToolBox::ImplToolItems::size_type nPos, sal_uInt16& rItemId, CommandToInfoMap& rCommandMap, - const OUString& rModuleIdentifier, + std::u16string_view rModuleIdentifier, const OUString& rMergeCommand, const OUString& rMergeCommandParameter, const AddonToolbarItemContainer& rItems ); @@ -87,7 +87,7 @@ class ToolBarMerger static bool ProcessMergeFallback( ToolBox* pToolbar, sal_uInt16& rItemId, CommandToInfoMap& rCommandMap, - const OUString& rModuleIdentifier, + std::u16string_view rModuleIdentifier, const OUString& rMergeCommand, const OUString& rMergeFallback, const AddonToolbarItemContainer& rItems ); @@ -97,14 +97,14 @@ class ToolBarMerger sal_uInt16 nModIndex, sal_uInt16& rItemId, CommandToInfoMap& rCommandMap, - const OUString& rModuleIdentifier, + std::u16string_view rModuleIdentifier, const AddonToolbarItemContainer& rAddonToolbarItems ); static void ReplaceItem( ToolBox* pToolbar, ToolBox::ImplToolItems::size_type nPos, sal_uInt16& rItemId, CommandToInfoMap& rCommandMap, - const OUString& rModuleIdentifier, + std::u16string_view rModuleIdentifier, const AddonToolbarItemContainer& rAddonToolbarItems ); static void RemoveItems( ToolBox* pToolbar, diff --git a/framework/inc/uifactory/menubarfactory.hxx b/framework/inc/uifactory/menubarfactory.hxx index cadb67363edd..661b5887760f 100644 --- a/framework/inc/uifactory/menubarfactory.hxx +++ b/framework/inc/uifactory/menubarfactory.hxx @@ -62,7 +62,7 @@ typedef ::cppu::WeakImplHelper< static void CreateUIElement(const OUString& ResourceURL ,const css::uno::Sequence< css::beans::PropertyValue >& Args - ,const OUString& ResourceType + ,std::u16string_view ResourceType ,const css::uno::Reference< css::ui::XUIElement >& _xMenuBar ,const css::uno::Reference< css::uno::XComponentContext >& _rxContext); |