loplugin:unusedmethods unused return value in framework

Change-Id: I6e02f34702ba59a961c3fec3d025e775f4e26760

3 files changed, 5 insertions, 11 deletions

diff --git a/framework/inc/classes/fwktabwindow.hxx b/framework/inc/classes/fwktabwindow.hxx
index a13ed5487cc5..6fdea7a3f0e9 100644
--- a/framework/inc/classes/fwktabwindow.hxx
+++ b/framework/inc/classes/fwktabwindow.hxx
@@ -114,10 +114,10 @@ public:
 
     void            AddEventListener( const Link<VclWindowEvent&,void>& rEventListener );
     void            RemoveEventListener( const Link<VclWindowEvent&,void>& rEventListener );
-    FwkTabPage*     AddTabPage( sal_Int32 nIndex, const css::uno::Sequence< css::beans::NamedValue >& rProperties );
+    void            AddTabPage( sal_Int32 nIndex, const css::uno::Sequence< css::beans::NamedValue >& rProperties );
     void            ActivatePage( sal_Int32 nIndex );
     void            RemovePage( sal_Int32 nIndex );
-    virtual void        Resize() override;
+    virtual void    Resize() override;
 };
 
 } // namespace framework
diff --git a/framework/inc/threadhelp/gate.hxx b/framework/inc/threadhelp/gate.hxx
index cb4a3fb12b9e..9ba5db898c56 100644
--- a/framework/inc/threadhelp/gate.hxx
+++ b/framework/inc/threadhelp/gate.hxx
@@ -108,17 +108,13 @@ class Gate : private boost::noncopyable
             @seealso    method open()
 
             @param      "pTimeOut", optional parameter to wait a certain time
-            @return     true, if wait was successful (gate was opened)
-                        false, if condition has an error or timeout was reached!
 
-            @onerror    We return false.
         *//*-*****************************************************************************************************/
-        bool wait(const TimeValue* pTimeOut = nullptr)
+        void wait(const TimeValue* pTimeOut = nullptr)
         {
             // We must safe access to our internal member!
             ::osl::ClearableMutexGuard aLock( m_aAccessLock );
             // If gate not closed - caller can pass it.
-            bool bSuccessful = true;
             if( m_bClosed )
             {
                 // Then we must release used access lock -
@@ -126,10 +122,8 @@ class Gate : private boost::noncopyable
                 // and if we hold the access lock nobody else can use this object without a deadlock!
                 aLock.clear();
                 // Wait for opening gate...
-                bSuccessful = ( m_aPassage.wait( pTimeOut ) == ::osl::Condition::result_ok );
+                m_aPassage.wait( pTimeOut );
             }
-
-            return bSuccessful;
         }
 
     //  private member
diff --git a/framework/inc/uielement/toolbarmanager.hxx b/framework/inc/uielement/toolbarmanager.hxx
index 90f66edb5efd..cd912f1adb3d 100644
--- a/framework/inc/uielement/toolbarmanager.hxx
+++ b/framework/inc/uielement/toolbarmanager.hxx
@@ -146,7 +146,7 @@ class ToolBarManager : public ToolbarManager_Base
         ToolBoxItemBits ConvertStyleToToolboxItemBits( sal_Int32 nStyle );
         css::uno::Reference< css::frame::XModel > GetModelFromFrame() const;
         bool IsPluginMode() const;
-        long HandleClick(void ( SAL_CALL css::frame::XToolbarController::*_pClick )(  ));
+        void HandleClick(void ( SAL_CALL css::frame::XToolbarController::*_pClick )(  ));
         void setToolBarImage(const Image& _aImage,const CommandToInfoMap::const_iterator& _pIter);
         void impl_elementChanged(bool _bRemove,const css::ui::ConfigurationEvent& Event );