diff options
| author | Noel Grandin <noel@peralex.com> | 2013-10-25 16:43:20 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2013-10-31 08:34:21 +0200 |
| commit | e2451bd729d0f1d795a5b689deba65bc4e9d92c6 (patch) | |
| tree | 4f2356107b0e58db7afda0fc324b9eac49ff68c0 /framework/source/layoutmanager | |
| parent | 460b52838fdad0352188bdd877b69cbb5f17ca63 (diff) | |
Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
Diffstat (limited to 'framework/source/layoutmanager')
| -rw-r--r-- | framework/source/layoutmanager/helpers.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/framework/source/layoutmanager/helpers.cxx b/framework/source/layoutmanager/helpers.cxx index 1ad507d0464c..5cc82710aed0 100644 --- a/framework/source/layoutmanager/helpers.cxx +++ b/framework/source/layoutmanager/helpers.cxx @@ -199,7 +199,7 @@ OUString getElementTypeFromResourceURL( const OUString& aResourceURL ) OUString aType; OUString aUIResourceURL( UIRESOURCE_URL ); - if ( aResourceURL.indexOf( aUIResourceURL ) == 0 ) + if ( aResourceURL.startsWith( aUIResourceURL ) ) { sal_Int32 nIndex = 0; OUString aPathPart = aResourceURL.copy( aUIResourceURL.getLength() ); @@ -214,7 +214,7 @@ OUString getElementTypeFromResourceURL( const OUString& aResourceURL ) void parseResourceURL( const OUString& aResourceURL, OUString& aElementType, OUString& aElementName ) { OUString aUIResourceURL( UIRESOURCE_URL ); - if ( aResourceURL.indexOf( aUIResourceURL ) == 0 ) + if ( aResourceURL.startsWith( aUIResourceURL ) ) { sal_Int32 nIndex = 0; OUString aPathPart = aResourceURL.copy( aUIResourceURL.getLength() ); |