loplugin:checkunusedparams in framework

Change-Id: I963159550da9d735bb70636917ecc290744298b4
Reviewed-on: https://gerrit.libreoffice.org/37142
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

3 files changed, 26 insertions, 32 deletions

diff --git a/framework/source/services/autorecovery.cxx b/framework/source/services/autorecovery.cxx
index b3849d54cc20..827e045629ff 100644
--- a/framework/source/services/autorecovery.cxx
+++ b/framework/source/services/autorecovery.cxx
@@ -837,7 +837,7 @@ private:
     };
 
     // TODO document me
-    void implts_resetHandleStates(bool bLoadCache);
+    void implts_resetHandleStates();
 
     // TODO document me
     void implts_specifyDefaultFilterAndExtension(AutoRecovery::TDocumentInfo& rInfo);
@@ -868,7 +868,7 @@ private:
     void implts_doSessionSave(const DispatchParams& aParams);
 
     // TODO document me
-    void implts_doSessionQuietQuit(const DispatchParams& aParams);
+    void implts_doSessionQuietQuit();
 
     // TODO document me
     void implts_doSessionRestore(const DispatchParams& aParams);
@@ -1445,7 +1445,7 @@ void AutoRecovery::implts_dispatch(const DispatchParams& aParams)
         {
             SAL_INFO("fwk.autorecovery", "... do session quiet quit ...");
             bAllowAutoSaveReactivation = false;
-            implts_doSessionQuietQuit(aParams);
+            implts_doSessionQuietQuit();
         }
         else
         if (
@@ -2358,7 +2358,7 @@ IMPL_LINK_NOARG(AutoRecovery, implts_timerExpired, Timer *, void)
             (eSuggestedTimer == AutoRecovery::E_NORMAL_AUTOSAVE_INTERVALL)
            )
         {
-            implts_resetHandleStates(false);
+            implts_resetHandleStates();
         }
 
         implts_informListener(AutoRecovery::E_AUTO_SAVE,
@@ -3642,7 +3642,7 @@ css::frame::FeatureStateEvent AutoRecovery::implst_createFeatureStateEvent(
     return aEvent;
 }
 
-void AutoRecovery::implts_resetHandleStates(bool /*bLoadCache*/)
+void AutoRecovery::implts_resetHandleStates()
 {
     CacheLockGuard aCacheLock(this, cppu::WeakComponentImplHelperBase::rBHelper.rMutex, m_nDocCacheLock, LOCK_FOR_CACHE_USE);
 
@@ -3713,7 +3713,7 @@ void AutoRecovery::implts_doEmergencySave(const DispatchParams& aParams)
     // was already saved during the THIS(!) EmergencySave session.
     // Of course following recovery session must be started without
     // any "handle" state ...
-    implts_resetHandleStates(false);
+    implts_resetHandleStates();
 
     // flush config cached back to disc.
     impl_flushALLConfigChanges();
@@ -3738,7 +3738,7 @@ void AutoRecovery::implts_doRecovery(const DispatchParams& aParams)
     // was already saved during the THIS(!) Recovery session.
     // Of course a may be following EmergencySave session must be started without
     // any "handle" state ...
-    implts_resetHandleStates(true);
+    implts_resetHandleStates();
 
     // Reset the configuration hint "we was crashed"!
     ::comphelper::ConfigurationHelper::writeDirectKey(
@@ -3782,13 +3782,13 @@ void AutoRecovery::implts_doSessionSave(const DispatchParams& aParams)
     // was already saved during the THIS(!) save session.
     // Of course following restore session must be started without
     // any "handle" state ...
-    implts_resetHandleStates(false);
+    implts_resetHandleStates();
 
     // flush config cached back to disc.
     impl_flushALLConfigChanges();
 }
 
-void AutoRecovery::implts_doSessionQuietQuit(const DispatchParams& /*aParams*/)
+void AutoRecovery::implts_doSessionQuietQuit()
 {
     SAL_INFO("fwk.autorecovery", "AutoRecovery::implts_doSessionQuietQuit()");
 
@@ -3834,7 +3834,7 @@ void AutoRecovery::implts_doSessionRestore(const DispatchParams& aParams)
     // was already saved during the THIS(!) Restore session.
     // Of course a may be following save session must be started without
     // any "handle" state ...
-    implts_resetHandleStates(true);
+    implts_resetHandleStates();
 
     // make all opened documents visible
     implts_changeAllDocVisibility(true);
diff --git a/framework/source/services/frame.cxx b/framework/source/services/frame.cxx
index 132334ebdcd7..954eb9c38c29 100644
--- a/framework/source/services/frame.cxx
+++ b/framework/source/services/frame.cxx
@@ -306,12 +306,10 @@ public:
 
 private:
 
-    void SAL_CALL impl_setPropertyValue(const OUString& sProperty,
-                                        sal_Int32 nHandle,
+    void SAL_CALL impl_setPropertyValue(sal_Int32 nHandle,
                                         const css::uno::Any& aValue);
 
-    css::uno::Any SAL_CALL impl_getPropertyValue(const OUString& sProperty,
-                                                 sal_Int32 nHandle);
+    css::uno::Any SAL_CALL impl_getPropertyValue(sal_Int32 nHandle);
 
     /** set a new owner for this helper.
      *
@@ -1860,7 +1858,7 @@ void SAL_CALL Frame::setPropertyValue(const OUString& sProperty,
 
     css::beans::Property aPropInfo = pIt->second;
 
-    css::uno::Any aCurrentValue = impl_getPropertyValue(aPropInfo.Name, aPropInfo.Handle);
+    css::uno::Any aCurrentValue = impl_getPropertyValue(aPropInfo.Handle);
 
     bool bWillBeChanged = (aCurrentValue != aValue);
     if (! bWillBeChanged)
@@ -1877,7 +1875,7 @@ void SAL_CALL Frame::setPropertyValue(const OUString& sProperty,
     if (impl_existsVeto(aEvent))
         throw css::beans::PropertyVetoException();
 
-    impl_setPropertyValue(aPropInfo.Name, aPropInfo.Handle, aValue);
+    impl_setPropertyValue(aPropInfo.Handle, aValue);
 
     impl_notifyChangeListener(aEvent);
 }
@@ -1895,7 +1893,7 @@ css::uno::Any SAL_CALL Frame::getPropertyValue(const OUString& sProperty)
 
     css::beans::Property aPropInfo = pIt->second;
 
-    return impl_getPropertyValue(aPropInfo.Name, aPropInfo.Handle);
+    return impl_getPropertyValue(aPropInfo.Handle);
 }
 
 void SAL_CALL Frame::addPropertyChangeListener(
@@ -2707,8 +2705,7 @@ sal_Int16 SAL_CALL Frame::resetActionLocks()
     return nCurrentLocks;
 }
 
-void SAL_CALL Frame::impl_setPropertyValue(const OUString& /*sProperty*/,
-                                           sal_Int32 nHandle,
+void SAL_CALL Frame::impl_setPropertyValue(sal_Int32 nHandle,
                                            const css::uno::Any& aValue)
 
 {
@@ -2765,8 +2762,7 @@ void SAL_CALL Frame::impl_setPropertyValue(const OUString& /*sProperty*/,
     }
 }
 
-css::uno::Any SAL_CALL Frame::impl_getPropertyValue(const OUString& /*sProperty*/,
-                                                          sal_Int32 nHandle)
+css::uno::Any SAL_CALL Frame::impl_getPropertyValue(sal_Int32 nHandle)
 {
     /* There is no need to lock any mutex here. Because we share the
        solar mutex with our base class. And we said to our base class: "don't release it on calling us" .-)
diff --git a/framework/source/services/pathsettings.cxx b/framework/source/services/pathsettings.cxx
index 0c632ef8194f..a002758d46a4 100644
--- a/framework/source/services/pathsettings.cxx
+++ b/framework/source/services/pathsettings.cxx
@@ -417,10 +417,9 @@ private:
 
     css::uno::Sequence< sal_Int32 > impl_mapPathName2IDList(const OUString& sPath);
 
-    void impl_notifyPropListener(      PathSettings::EChangeOp eOp     ,
-                                       const OUString&        sPath   ,
-                                       const PathSettings::PathInfo* pPathOld,
-                                       const PathSettings::PathInfo* pPathNew);
+    void impl_notifyPropListener( const OUString&        sPath   ,
+                                  const PathSettings::PathInfo* pPathOld,
+                                  const PathSettings::PathInfo* pPathNew);
 
     //  OPropertySetHelper
     virtual sal_Bool SAL_CALL convertFastPropertyValue( css::uno::Any&  aConvertedValue,
@@ -782,7 +781,7 @@ PathSettings::EChangeOp PathSettings::impl_updatePath(const OUString& sPath
                 {
                     pPathOld = nullptr;
                     pPathNew = &aPath;
-                    impl_notifyPropListener(eOp, sPath, pPathOld, pPathNew);
+                    impl_notifyPropListener(sPath, pPathOld, pPathNew);
                 }
                 m_lPaths[sPath] = aPath;
              }
@@ -794,7 +793,7 @@ PathSettings::EChangeOp PathSettings::impl_updatePath(const OUString& sPath
                 {
                     pPathOld = &(pPath->second);
                     pPathNew = &aPath;
-                    impl_notifyPropListener(eOp, sPath, pPathOld, pPathNew);
+                    impl_notifyPropListener(sPath, pPathOld, pPathNew);
                 }
                 m_lPaths[sPath] = aPath;
              }
@@ -808,7 +807,7 @@ PathSettings::EChangeOp PathSettings::impl_updatePath(const OUString& sPath
                     {
                         pPathOld = &(pPath->second);
                         pPathNew = nullptr;
-                        impl_notifyPropListener(eOp, sPath, pPathOld, pPathNew);
+                        impl_notifyPropListener(sPath, pPathOld, pPathNew);
                     }
                     m_lPaths.erase(pPath);
                 }
@@ -864,10 +863,9 @@ css::uno::Sequence< sal_Int32 > PathSettings::impl_mapPathName2IDList(const OUSt
     return lIDs;
 }
 
-void PathSettings::impl_notifyPropListener(      PathSettings::EChangeOp /*eOp*/     ,
-                                           const OUString&        sPath   ,
-                                           const PathSettings::PathInfo* pPathOld,
-                                           const PathSettings::PathInfo* pPathNew)
+void PathSettings::impl_notifyPropListener( const OUString&               sPath,
+                                            const PathSettings::PathInfo* pPathOld,
+                                            const PathSettings::PathInfo* pPathNew)
 {
     css::uno::Sequence< sal_Int32 >     lHandles(1);
     css::uno::Sequence< css::uno::Any > lOldVals(1);